Skip to content

Use System.Text.Json to replace Newtonsoft.Json for better performance #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Use System.Text.Json to replace Newtonsoft.Json for better performance #3174

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad02700
Use System.Text.Json to replace Newtonsoft.Json for better performance
Jack251970 Jan 9, 2025
95b4c4c
Improve code quality
Jack251970 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions Plugins/Flow.Launcher.Plugin.PluginsManager/Utilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
using Flow.Launcher.Core.ExternalPlugins;
using Flow.Launcher.Infrastructure.UserSettings;
using ICSharpCode.SharpZipLib.Zip;
using Newtonsoft.Json;
using System.IO;
using System.IO.Compression;
using System.Linq;
using System.Text.Json;

namespace Flow.Launcher.Plugin.PluginsManager
{
Expand Down Expand Up @@ -72,12 +71,10 @@ internal static UserPlugin GetPluginInfoFromZip(string filePath)

if (pluginJsonEntry != null)
{
using (StreamReader reader = new StreamReader(pluginJsonEntry.Open()))
{
string pluginJsonContent = reader.ReadToEnd();
plugin = JsonConvert.DeserializeObject<UserPlugin>(pluginJsonContent);
plugin.IcoPath = "Images\\zipfolder.png";
}
using StreamReader reader = new StreamReader(pluginJsonEntry.Open());
string pluginJsonContent = reader.ReadToEnd();
plugin = JsonSerializer.Deserialize<UserPlugin>(pluginJsonContent);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there's an overload for stream directly so we don't need to read it as string before deserializing it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, please check.

plugin.IcoPath = "Images\\zipfolder.png";
}
}

Expand Down
Loading