Skip to content

Conversation

@CreeperAWA
Copy link

Update the Chinese translation of "new window" from "新窗户" to "新窗口" for accuracy.
将“new window”的中文翻译从“新窗户”更改为“新窗口”,以确保准确性。

@prlabeler prlabeler bot added the bug Something isn't working label Jun 1, 2025
@github-actions
Copy link

github-actions bot commented Jun 1, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 1, 2025

📝 Walkthrough

Walkthrough

This update corrects the Chinese translation for the phrase "new window" across three resource files in the Flow Launcher application and its plugins. The term "新窗户" was replaced with the more accurate "新窗口" in all occurrences. No changes were made to logic, functionality, or exported entities.

Changes

File(s) Change Summary
Flow.Launcher/Languages/zh-cn.xaml Corrected translation for "defaultBrowser_newWindow"
Plugins/Flow.Launcher.Plugin.Url/Languages/zh-cn.xaml,
Plugins/Flow.Launcher.Plugin.WebSearch/Languages/zh-cn.xaml
Corrected translation for "new window" string

Suggested labels

kind/i18n

Suggested reviewers

  • jjw24

Poem

A window once called "窗户"—oh dear,
Now "窗口" brings clarity near!
Across plugins and core,
The right words we restore,
So users in China may cheer!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43227d8 and ff39cd4.

📒 Files selected for processing (3)
  • Flow.Launcher/Languages/zh-cn.xaml (1 hunks)
  • Plugins/Flow.Launcher.Plugin.Url/Languages/zh-cn.xaml (1 hunks)
  • Plugins/Flow.Launcher.Plugin.WebSearch/Languages/zh-cn.xaml (1 hunks)
🔇 Additional comments (3)
Plugins/Flow.Launcher.Plugin.WebSearch/Languages/zh-cn.xaml (1)

6-6: Correct Chinese term for "new window"
The updated translation changes "新窗户" to the standard and accurate term "新窗口", which better reflects the intended meaning in this context. This aligns with established terminology in the core application.

Flow.Launcher/Languages/zh-cn.xaml (1)

391-391: Fix translation for defaultBrowser_newWindow
The key defaultBrowser_newWindow now uses "新窗口" instead of the incorrect "新窗户", ensuring consistency with Chinese UI terminology and plugin translations.

Plugins/Flow.Launcher.Plugin.Url/Languages/zh-cn.xaml (1)

5-5: Update Chinese localization for "new window"
Changing the value to "新窗口" corrects the previous mistranslation and matches the main app and WebSearch plugin localization.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jack251970
Copy link
Member

你好,首先感谢你对Flow Launcher字符串本地化的改进!然而,我们的项目采用Crowdin自动配置字符串本地化的内容,因此,能否请你将这些改进在我们项目的Crowdin中进行贡献?感谢!链接在我们项目README.md的Localized标签处:https://crowdin.com/project/flow-launcher。

@CreeperAWA
Copy link
Author

我修改后点击保存就可以了吧?我是第一次使用这个网站,这个网站在中国大陆访问有些困难,我们的政府屏蔽了很多网站,GitHub有时候也会遭到屏蔽

@Jack251970
Copy link
Member

我修改后点击保存就可以了吧?我是第一次使用这个网站,这个网站在中国大陆访问有些困难,我们的政府屏蔽了很多网站,GitHub有时候也会遭到屏蔽

我也是第一次使用,应该这样就可以了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants