Skip to content

Use Debug instead of Info when manifest fetch cancelled #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

Use Debug instead of Info when manifest fetch cancelled #3993

merged 1 commit into from
Sep 19, 2025

Conversation

Jack251970
Copy link
Member

Follow on with #3975

@prlabeler prlabeler bot added the bug Something isn't working label Sep 18, 2025
@Jack251970 Jack251970 requested a review from jjw24 September 18, 2025 13:06
@github-actions github-actions bot added this to the 2.1.0 milestone Sep 18, 2025
@Jack251970 Jack251970 mentioned this pull request Sep 18, 2025
Merged
@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented Sep 18, 2025

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher.Core/ExternalPlugins/CommunityPluginSource.cs

Activity based on git-commit:

Jack251970
SEP
AUG
JUL
JUN
MAY
APR 61 additions & 39 deletions

Knowledge based on git-blame:
Jack251970: 45%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented Sep 18, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 18, 2025

📝 Walkthrough

Walkthrough

Adjusted logging level for cancellation in CommunityPluginSource.FetchAsync: OperationCanceledException when the token is canceled is now logged at Debug instead of Info. No control-flow or public API changes.

Changes

Cohort / File(s) Summary
Logging level adjustment
Flow.Launcher.Core/ExternalPlugins/CommunityPluginSource.cs		 In FetchAsync, changed cancellation catch block to log at Debug level instead of Info; returns null unchanged; no signature or behavior changes beyond log verbosity.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description Check ❓ Inconclusive The description "Follow on with #3975" shows the PR is related to a previous change but does not describe what was changed, why, or how it was tested, so it is too vague to be useful on its own. Because it provides only linkage and no substantive summary, it is insufficient under the "very vague or generic" criterion. Request the author to expand the PR description to briefly state what was changed (e.g., changed cancellation log level from Info to Debug and the file/function affected), the rationale for the change, any impact or risk, and reference how this follows on from PR #3975 so reviewers can evaluate the change without inspecting all files.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Use Debug instead of Info" clearly and concisely reflects the primary change in the changeset, which is lowering the log level for cancellation handling from Info to Debug in FetchAsync (Flow.Launcher.Core/ExternalPlugins/CommunityPluginSource.cs). It is short, focused, and relevant for a reviewer scanning PR titles. While accurate, it could be slightly more specific by naming the file or function for extra context.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch improve_log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Sep 18, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Flow.Launcher.Core/ExternalPlugins/CommunityPluginSource.cs (1)

76-80: Downgrading cancellation to Debug is correct; minor spelling nit.

Change “cancelled” → “canceled” to match .NET spelling. Search found no remaining API.LogInfo cancellation logs.

-                API.LogDebug(ClassName, $"Fetching from {ManifestFileUrl} was cancelled by caller.");
+                API.LogDebug(ClassName, $"Fetching from {ManifestFileUrl} was canceled by caller.");
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1689571 and 7a5e55e.

📒 Files selected for processing (1)
  • Flow.Launcher.Core/ExternalPlugins/CommunityPluginSource.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-06T12:21:37.947Z 
Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3572
File: Flow.Launcher/App.xaml.cs:214-216
Timestamp: 2025-07-06T12:21:37.947Z
Learning: In Flow Launcher, the UpdatePluginManifestAsync method in PluginsManifest.cs already has comprehensive internal try-catch handling that logs exceptions and returns false on failure rather than throwing, making external try-catch wrappers unnecessary.

Applied to files:

  • Flow.Launcher.Core/ExternalPlugins/CommunityPluginSource.cs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: gitStream.cm
  • GitHub Check: build

@Jack251970 Jack251970 added Dev branch only An issue or fix for the Dev branch build and removed bug Something isn't working labels Sep 18, 2025
@Jack251970 Jack251970 merged commit 89fca85 into dev Sep 19, 2025
13 checks passed
@Jack251970 Jack251970 deleted the improve_log branch September 19, 2025 05:27
@jjw24 jjw24 changed the title Use Debug instead of Info Use Debug instead of Info when manifest fetch cancelled Sep 20, 2025
@prlabeler prlabeler bot added the bug Something isn't working label Sep 20, 2025
@jjw24 jjw24 removed the bug Something isn't working label Sep 20, 2025
@jjw24 jjw24 modified the milestones: 2.1.0, 2.0.1 Sep 21, 2025
jjw24 pushed a commit that referenced this pull request Sep 21, 2025
@Jack251970 @jjw24
Merge pull request #3993 from Flow-Launcher/improve_log
cabdb7c 
Use Debug instead of Info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@onesounds onesounds onesounds approved these changes

@jjw24 jjw24 Awaiting requested review from jjw24

Assignees

@Jack251970 Jack251970

Labels
Dev branch only An issue or fix for the Dev branch build
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Jack251970 @onesounds @jjw24