Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/nb.xaml (7)

9-9: Localize the English fallback ("copy failed") to Norwegian.

Current value is English; inconsistent with the NB locale.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Kunne ikke kopiere nettadresse til utklippstavlen</system:String>

---

31-31: Localize the favicons setting string.

English text in NB file.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Last inn favikoner (kan være tidkrevende ved oppstart)</system:String>

---

16-16: Fix Norwegian wording ("banen" → "sti").

“Bane” is incorrect for filesystem path.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_setBrowserFromPath">Angi nettleser fra banen:</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_setBrowserFromPath">Angi nettleser fra sti:</system:String>

---

20-20: Clarify intent: load bookmarks, not the browser.

Wording suggests loading the browser itself.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_loadBrowserFrom">Last nettleser fra:</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_loadBrowserFrom">Last bokmerker fra:</system:String>

---

26-26: Prefer “Bla gjennom” for browse action.

More idiomatic button label.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_browseBrowserBookmark">Bla</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_browseBrowserBookmark">Bla gjennom</system:String>

---

30-30: Norwegian possessive for “Brave's”.

Use “Braves motor”.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage02">For eksempel: Brave's motor er Chromium; og standardplasseringen av bokmerker er: &quot;%LOCALAPPDATA%\BraveSoftware\Brave-Browser\UserData&quot;. For Firefox-motoren er bokmerkekatalogen brukerdatamappen som inneholder places.sqlite-filen.</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage02">For eksempel: Braves motor er Chromium; og standardplasseringen av bokmerker er: &quot;%LOCALAPPDATA%\BraveSoftware\Brave-Browser\UserData&quot;. For Firefox-motoren er bokmerkekatalogen brukerdatamappen som inneholder places.sqlite-filen.</system:String>

---

2-33: Verify resource key prefix vs. plugin rename; confirm Crowdin path updates.

Keys retain “browserbookmark” (singular) prefix while project is “BrowserBookmarks” (plural). Fine if code/XAML still reference these keys, but please verify to avoid missing strings. Also confirm Crowdin/source extraction jobs track the new plugin directory so NB (and other locales) continue to sync.

If helpful, I can provide a grep script to confirm key usage across the new project and check Crowdin config changes.

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/uk-UA.xaml (2)

31-31: Update favicon setting copy to reflect background/parallel fetching.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Завантажити піктограми (може зайняти багато часу під час запуску)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Увімкнути значки сайтів; відсутні значки можуть завантажуватися у фоновому режимі</system:String>

---

9-9: Ukrainian microcopy: use “скопіювати” (not “вставити”) and uppercase “URL”.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Не вдалося вставити Url-адресу в буфер обміну</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Не вдалося скопіювати URL-адресу до буфера обміну</system:String>

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/sk.xaml (2)

31-31: Favicon setting text implies slower startup; now favicons load async.

Adjust wording to reflect background/async favicon loading and optional web fetch, not startup latency.

---

1-1: Byte Order Mark present. Consider removing to reduce diff churn.

The leading BOM before the XML declaration can cause noisy diffs across locales. Prefer UTF‑8 without BOM unless your tooling requires it.

If the repo standardizes on no‑BOM, apply “Save without BOM” to all XAML locale files in this plugin for consistency.

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/ko.xaml (2)

9-10: Untranslated string and casing (URL) — localize for ko-KR.

Line 9 is English and uses "url" instead of "URL". Recommend Korean translation consistent with other entries.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">클립보드에 URL을 복사하지 못했습니다</system:String>

---

13-16: Several English strings left in Korean resource file — translate for consistency.

Localize these labels to avoid mixed-language UI.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_openBookmarks">Open bookmarks in:</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_openBookmarks">북마크를 열 위치:</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_setBrowserFromPath">Set browser from path:</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_setBrowserFromPath">경로에서 브라우저 지정:</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_others">Others</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_others">기타</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">파비콘 로드(시작 시 시간이 오래 걸릴 수 있음)</system:String>

Also applies to: 27-27, 31-31

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/cs.xaml (3)

9-9: Untranslated string in Czech locale.

Failed to set url in clipboard is English and “url” casing is inconsistent. Suggest Czech + URL casing.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Nepodařilo se zkopírovat adresu URL do schránky</system:String>

---

31-31: Untranslated + possibly outdated performance note.

Localize and avoid implying startup blocking if work is now async/parallel.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Načítat favikony (první načtení může chvíli trvat)</system:String>

---

18-19: Consistency: use “URL” casing in Czech strings.

Keep “URL” uppercase for consistency with other entries.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Kopírovat URL</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Zkopírovat adresu URL záložky do schránky</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Kopírovat URL</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Zkopírovat adresu URL záložky do schránky</system:String>

(If already consistent across locales, ignore.)

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/vi.xaml (4)

9-9: Untranslated/error‑case string; fix capitalization and locale terms.

Use Vietnamese and “URL” capitalization; prefer “bộ nhớ tạm” for clipboard.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Không thể sao chép URL vào bộ nhớ tạm</system:String>

---

18-19: Copy URL strings: capitalize “URL” and localize “clipboard”.

Keeps terminology consistent across vi locale.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Sao chép url</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Sao chép url của dấu trang vào clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Sao chép URL</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Sao chép URL của dấu trang vào bộ nhớ tạm</system:String>

---

15-15: UI wording nit: drop “Thêm” for the option label.

“Tab mới” reads more natural in settings.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_newTab">Thêm Tab mới</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_newTab">Tab mới</system:String>

---

31-31: Untranslated setting; provide Vietnamese.

Translate and keep “favicon” product term unlocalized.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Tải favicon (có thể tốn thời gian khi khởi động)</system:String>

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/es-419.xaml (1)

9-31: Untranslated strings in es-419; propose Spanish localizations and minor copy fixes (URL casing).

Several entries remain in English and “url” should be “URL”. Suggested changes below.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">No se pudo copiar la URL al portapapeles</system:String>
@@
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Copiar url</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Copiar la url del marcador al portapapeles</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Copiar URL</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Copiar la URL del marcador al portapapeles</system:String>
@@
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_browseBrowserBookmark">Browse</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_others">Others</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_browserEngine">Browser Engine</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage01">If you are not using Chrome, Firefox or Edge, or you are using their portable version, you need to add bookmarks data directory and select correct browser engine to make this plugin work.</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage02">For example: Brave's engine is Chromium; and its default bookmarks data location is: &quot;%LOCALAPPDATA%\BraveSoftware\Brave-Browser\UserData&quot;. For Firefox engine, the bookmarks directory is the userdata folder contains the places.sqlite file.</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_browseBrowserBookmark">Examinar</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_others">Otros</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_browserEngine">Motor del navegador</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage01">Si no usas Chrome, Firefox o Edge, o utilizas sus versiones portátiles, debes añadir la carpeta de datos de marcadores y seleccionar el motor de navegador correcto para que este complemento funcione.</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage02">Por ejemplo: el motor de Brave es Chromium y su ubicación predeterminada de datos de marcadores es: &quot;%LOCALAPPDATA%\BraveSoftware\Brave-Browser\UserData&quot;. Para Firefox, la carpeta de marcadores es la de usuario que contiene el archivo places.sqlite.</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Cargar favicons (puede tardar durante el inicio)</system:String>

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/pl.xaml (2)

9-9: English string left in Polish locale.

Provide Polish translation.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Nie udało się skopiować adresu URL do schowka</system:String>

---

18-19: Normalize “URL” capitalization in PL strings.

Minor copy polish for consistency.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Kopiuj adres url</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Skopiuj adres url zakładki do schowka</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Kopiuj adres URL</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Skopiuj adres URL zakładki do schowka</system:String>

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/ru.xaml (5)

1-1: Normalize UTF‑8 BOM usage across language files

The leading BOM appears intentional. Please confirm all language XAMLs use the same encoding to avoid noisy diffs and potential tooling quirks.

---

9-9: Untranslated string → provide RU translation

Replace the English fallback with Russian.

Apply this diff:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Не удалось скопировать URL-адрес в буфер обмена</system:String>

---

31-31: Untranslated string → provide RU translation

Localize the favicon setting.

Apply this diff:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Загружать значки сайтов (может замедлить запуск)</system:String>

---

17-17: Wording: use imperative “Выбрать” instead of noun “Выбор”

Improves UI tone consistency with other actions.

Apply this diff:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_choose">Выбор</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_settings_choose">Выбрать</system:String>

---

22-22: Clarify label to explicitly mention bookmarks

More specific and consistent with other strings.

Apply this diff:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_browserBookmarkDataDirectory">Путь к каталогу данных</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_browserBookmarkDataDirectory">Путь к каталогу данных закладок</system:String>

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/zh-cn.xaml (5)

9-9: Fix trailing space and terminology (“剪切板” → “剪贴板”).

There’s a trailing space and a common typo. Recommend consistent wording across related strings.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">无法复制 URL 到剪切板 </system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">无法将网址复制到剪贴板</system:String>

---

29-30: Chinese spacing/wording polish in guide messages.

Remove unnecessary spaces around punctuation and consider “便携版” over “绿色版” for zh-CN UI.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage01">如果你没有使用 Chrome、 Firefox 或 Edge，或者正在使用它们的绿色版， 那么你需要添加书签数据目录并选择正确的浏览器引擎才能使此插件正常工作。</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage01">如果你没有使用 Chrome、Firefox 或 Edge，或者正在使用它们的便携版，那么需要添加书签数据目录并选择正确的浏览器引擎才能使此插件正常工作。</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage02">例如：Brave 浏览器的引擎是 Chromium；其默认书签数据位置是 &quot;%LOCALAPPDATA%\BraveSoftware\Brave-Browser\UserData&quot;。 对于 Firefox 引擎的浏览器，书签目录是 places.sqlite 文件所在的用户数据文件夹。</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage02">例如：Brave 浏览器的引擎是 Chromium；其默认书签数据位置是“%LOCALAPPDATA%\BraveSoftware\Brave-Browser\UserData”。对于 Firefox 引擎的浏览器，书签目录是 places.sqlite 文件所在的用户数据文件夹。</system:String>

---

31-31: “收藏夹图标”/paren style consistency (“网站图标（favicon）”).

Prefer consistent terminology with other locales and full-width parentheses in zh-CN.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">载入收藏夹图标 (启动时可能十分耗时)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">加载网站图标（favicon）（启动时可能较慢）</system:String>

---

1-3: Optional: use x:String and drop mscorlib assembly hint.

In modern WPF on .NET, x:String is sufficient and avoids mscorlib binding. Not required if consistent with the rest of the repo.

-<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:system="clr-namespace:System;assembly=mscorlib">
+<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">

And replace system:String with x:String throughout this file.

---

5-33: Crowdin and settings/cache migration check due to plugin rename.

Since the directory/namespace changed, ensure:

• Crowdin path mapping is updated so zh-CN continues to sync.
• Plugin ID/Action keywords migration (if changed) won’t drop user settings/caches without a migration step.

If needed, I can draft a simple migration routine to copy old settings/caches from Flow.Launcher.Plugin.BrowserBookmark to Flow.Launcher.Plugin.BrowserBookmarks.

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/de.xaml (5)

12-29: Copy may be outdated vs. “automatic engine detection”.

Strings reference manual engine selection; PR states engine detection is automatic. Align the guidance to avoid confusing users, or clarify that manual settings are only for portable/custom installs.

If manual selection is no longer exposed, I can propose updated German copy inline. Want me to draft it?

---

9-9: German phrasing improvement for error message.

Apply this diff:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">URL in Zwischenablage konnte nicht festgelegt werden</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">URL konnte nicht in die Zwischenablage kopiert werden</system:String>

---

22-22: Grammar nit.

Apply this diff:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_browserBookmarkDataDirectory">Pfad zu Datenverzeichnis</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_browserBookmarkDataDirectory">Pfad zum Datenverzeichnis</system:String>

---

32-32: Label may not reflect new async favicon behavior.

If favicons now load in background and not strictly on startup, rephrase to set expectations.

Apply this diff (if accurate):

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Favicons laden (kann während des Starts zeitaufwendig sein)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Favicons laden (wird im Hintergrund verarbeitet; der erste Durchlauf kann länger dauern)</system:String>

---

2-2: Crowdin/GitHub Actions path alignment.

The plugin moved to Plugins/Flow.Launcher.Plugin.BrowserBookmarks/. Ensure l10n pipelines (Crowdin config, extraction/upload/download jobs) include this new path, otherwise translations won’t update.

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/he.xaml (3)

9-9: Translate the remaining English strings for consistency (and RTL rendering).

Two keys are still in English; translate to improve UX and avoid LTR/RTL mixing.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">העתקת הכתובת ללוח נכשלה</system:String>

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">טעינת סמלי אתרים (עשויה להאט את ההפעלה)</system:String>

Also applies to: 31-31

---

29-30: Optional RTL polish for mixed-direction text (paths/env vars).

Long Hebrew sentences with Latin paths can render awkwardly. Consider adding LRM around the path/env variable to stabilize direction.

Example:

<system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage02">
לדוגמה: המנוע של Brave הוא Chromium, ומיקום ברירת המחדל של נתוני הסימניות שלו הוא: &#x200E;%LOCALAPPDATA%\BraveSoftware\Brave-Browser\UserData&#x200E;. עבור מנוע Firefox, ספריית הסימניות היא תיקיית המשתמש שמכילה את הקובץ &#x200E;places.sqlite&#x200E;.
</system:String>

---

16-17: Remove stale "Set browser from path" / "Choose" localization keys or clarify as manual override

No XAML/C# references found for flowlauncher_plugin_browserbookmark_settings_setBrowserFromPath or flowlauncher_plugin_browserbookmark_settings_choose; engine auto‑detection is implemented (CustomBrowserSettingViewModel.DetectedEngineText uses engine_detection_* and CustomBrowserSetting.xaml displays it). Remove these keys from Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/*.xaml (all locales) or change the copy to explicitly indicate a manual/portable‑browser override (e.g., “Manual path for portable/advanced browsers”).

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/sr.xaml (3)

9-9: Microcopy/grammar: capitalize “URL” and fix phrasing.

Use consistent capitalization and clearer wording.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to copy URL to clipboard</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Copy url</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Copy URL</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Copy the bookmark's url to clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Copy the bookmark's URL to clipboard</system:String>

Also applies to: 18-19

---

31-31: Wording conflicts with async favicon pipeline.

“time consuming during startup” suggests blocking startup; new plugin claims background/parallel favicon work. Adjust to set expectations.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (cached in background; initial caching may take time)</system:String>

---

20-30: Guide messages: minor clarity and locale.

These lengthy English guide strings in sr.xaml likely need translation; also consider breaking into shorter, translatable sentences in en.xaml first.

I can propose concise EN base strings to simplify translation if helpful.

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/es.xaml (1)

9-9: Spanish typo: “portapeles” → “portapapeles”; also capitalize URL.

Fix improves consistency with Line 19.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">No se ha podido establecer la url en el portapeles</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">No se ha podido establecer la URL en el portapapeles</system:String>

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/pt-pt.xaml (3)

5-6: Confirm key prefix vs. new plugin ID (possible lookup mismatch).

All keys still use the flowlauncher_plugin_browserbookmark_* prefix, while this PR renames the project to BrowserBookmarks. If the plugin ID or resource lookup prefix changed (e.g., to browserbookmarks), these strings may not be resolved. Please confirm the plugin ID in plugin.json and how resources are looked up. If the old prefix is intentionally kept for continuity, ignore. Otherwise, consider adding temporary alias keys to ease migration.

Option (non-breaking alias if moving to browserbookmarks prefix):

@@
-</ResourceDictionary>
+  <!-- Transitional aliases if the resource lookup expects `browserbookmarks_*` -->
+  <system:String x:Key="flowlauncher_plugin_browserbookmarks_plugin_name">
+    {StaticResource flowlauncher_plugin_browserbookmark_plugin_name}
+  </system:String>
+  <system:String x:Key="flowlauncher_plugin_browserbookmarks_plugin_description">
+    {StaticResource flowlauncher_plugin_browserbookmark_plugin_description}
+  </system:String>
+</ResourceDictionary>

---

9-9: Portuguese phrasing: “copiar” instead of “definir”.

More natural and consistent with the title “Copiar URL”.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Falha ao definir o URL na área de transferência</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Falha ao copiar o URL para a área de transferência</system:String>

---

1-1: BOM/encoding churn across language files.

This file includes a BOM and appears to be a reformat‑only change. To reduce noisy diffs and Crowdin churn, normalize language files to UTF‑8 (consistently with/without BOM) and a single indentation style across all locales.

Would you like a script to scan the Languages folder and report encoding/BOM inconsistencies?

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/zh-tw.xaml (2)

5-6: Key prefix still “browserbookmark” while project renamed; confirm consistency/migration.

Keys retain the old “browserbookmark” prefix. If plugin ID/namespace changed to BrowserBookmarks, verify:

• Settings/localization loaders still resolve these keys.
• Any planned settings migration from the old plugin isn’t blocked by ID or path changes.

If the intent is seamless replacement, consider keeping the old PluginID or add a migration step that copies settings/cache from the previous path. I can draft a migration helper if needed.

---

1-3: Encoding/BOM and Crowdin path check.

• File starts with BOM; acceptable for XAML, but ensure your Crowdin config and build tooling expect UTF‑8 with BOM or normalize consistently across language files.
• The directory path changed to “BrowserBookmarks”; confirm Crowdin mappings and GitHub Actions are updated so translations continue to sync.

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/ar.xaml (2)

9-9: Untranslated string (“copy failed”).

This should be localized for AR.

Apply:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">تعذّر نسخ الرابط إلى الحافظة</system:String>

---

31-31: Untranslated string (“Load favicons”).

Localize to AR.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">تحميل الأيقونات المفضلة (قد يستغرق وقتاً عند بدء التشغيل)</system:String>

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/fr.xaml (1)

9-9: French casing/wording nits (“url” → “URL”).

Minor copy polish.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Impossible de mettre l'url dans le presse-papiers</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Impossible de copier l’URL dans le presse-papiers</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Copier l'url</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_title">Copier l’URL</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Copier l'Url du favori dans le presse-papier</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copyurl_subtitle">Copier l’URL du favori dans le presse‑papiers</system:String>

Also applies to: 18-19

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/nl.xaml (1)

5-31: Mixed EN/NL strings — inconsistent localization.

Many entries remain English (name/description, main/guide texts). Either translate here or leave placeholders and rely on Crowdin.

If you want, I can propose NL translations for the unchanged keys.

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/pt-br.xaml (1)

9-9: Untranslated EN strings (“copy failed”, “Load favicons”).

Localize to PT‑BR.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Falha ao copiar a URL para a área de transferência</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Carregar favicons (pode demorar na inicialização)</system:String>

Also applies to: 31-31

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/ja.xaml (1)

9-9: Untranslated string (“copy failed”).

Localize to JA.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">Failed to set url in clipboard</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_copy_failed">クリップボードにURLをコピーできませんでした</system:String>

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Services/BookmarkWatcherService.cs (1)

42-51: Consider buffer overflow handling.

Set InternalBufferSize and handle watcher.Error to recover from overflows on heavy writes.

             var watcher = new FileSystemWatcher(directory)
             {
                 Filter = fileName,
-                NotifyFilter = NotifyFilters.LastWrite | NotifyFilters.FileName | NotifyFilters.Size
+                NotifyFilter = NotifyFilters.LastWrite | NotifyFilters.FileName | NotifyFilters.Size,
+                InternalBufferSize = 64 * 1024 // 64KB to reduce overflow risk
             };
+            watcher.Error += (_, __) => TriggerDebouncedReload();

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Models/Settings.cs (1)

14-48: Guard setters to avoid redundant PropertyChanged churn.

Early‑return when value unchanged. Reduces unnecessary reloads.

-        set { _loadChromeBookmark = value; OnPropertyChanged(); }
+        set { if (_loadChromeBookmark == value) return; _loadChromeBookmark = value; OnPropertyChanged(); }
@@
-        set { _loadFirefoxBookmark = value; OnPropertyChanged(); }
+        set { if (_loadFirefoxBookmark == value) return; _loadFirefoxBookmark = value; OnPropertyChanged(); }
@@
-        set { _loadEdgeBookmark = value; OnPropertyChanged(); }
+        set { if (_loadEdgeBookmark == value) return; _loadEdgeBookmark = value; OnPropertyChanged(); }
@@
-        set { _loadChromiumBookmark = value; OnPropertyChanged(); }
+        set { if (_loadChromiumBookmark == value) return; _loadChromiumBookmark = value; OnPropertyChanged(); }
@@
-        set { _enableFavicons = value; OnPropertyChanged(); }
+        set { if (_enableFavicons == value) return; _enableFavicons = value; OnPropertyChanged(); }
@@
-        set { _fetchMissingFavicons = value; OnPropertyChanged(); }
+        set { if (_fetchMissingFavicons == value) return; _fetchMissingFavicons = value; OnPropertyChanged(); }

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/it.xaml (1)

1-34: Inconsistent localization - Line 31 remains in English.

While most strings are properly localized to Italian, the favicon loading setting remains in English: "Load favicons (can be time consuming during startup)". This should be translated to Italian for consistency.

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Carica favicons (può richiedere tempo durante l'avvio)</system:String>

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Services/IBookmarkLoader.cs (1)

9-9: Consider more descriptive property name.

The Name property could be more specific about what it represents (e.g., LoaderName, BrowserName, or SourceName) to avoid confusion with bookmark names.

-    string Name { get; }
+    string LoaderName { get; }

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Flow.Launcher.Plugin.BrowserBookmarks.csproj (2)

86-99: Duplicate copy of Languages\en.xaml (None + Content)

en.xaml is copied twice (None Update and Content Include). Remove the explicit None entry; the Content wildcard already covers it.

   <ItemGroup>
-    <None Update="plugin.json">
-      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-    </None>
-    <None Update="Languages\en.xaml">
-      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-    </None>
+    <None Update="plugin.json">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
     <None Update="Images\bookmark.png">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
     <None Update="Images\copylink.png">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
   </ItemGroup>

Also applies to: 100-105

---

41-61: Optional: prune non‑Windows runtimes is redundant for netX‑windows TFM

With net9.0‑windows, NuGet should not bring non‑Windows assets. These RemoveDir targets add build time and complexity.

Consider dropping the non‑Windows entries or the entire target unless you’ve measured size wins.

Also applies to: 63-84

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Services/BrowserDetector.cs (1)

15-25: Harden against IO exceptions and add Chromium “User Data” fallback

Directory enumeration and file checks can throw; also consider when users select the browser root that contains “User Data”.

     public static BrowserType DetectBrowserType(string dataDirectoryPath)
     {
         if (string.IsNullOrEmpty(dataDirectoryPath) || !Directory.Exists(dataDirectoryPath))
             return BrowserType.Unknown;

-        // Check for Chromium-based browsers by looking for the 'Bookmarks' file.
+        // Check for Chromium-based browsers by looking for the 'Bookmarks' file.
         // This includes checking common profile subdirectories.
-        var profileDirectories = Directory.EnumerateDirectories(dataDirectoryPath, "Profile *").ToList();
-        var defaultProfile = Path.Combine(dataDirectoryPath, "Default");
-        if (Directory.Exists(defaultProfile))
-            profileDirectories.Add(defaultProfile);
-        
-        // Also check the root directory itself, as some browsers use it directly.
-        profileDirectories.Add(dataDirectoryPath);
+        var profileDirectories = new List<string>();
+        try
+        {
+            profileDirectories.AddRange(Directory.EnumerateDirectories(dataDirectoryPath, "Profile *"));
+            var defaultProfile = Path.Combine(dataDirectoryPath, "Default");
+            if (Directory.Exists(defaultProfile))
+                profileDirectories.Add(defaultProfile);
+            // Some configs store Bookmarks directly under the data dir.
+            profileDirectories.Add(dataDirectoryPath);
+            // Fallback: typical Chromium root contains a "User Data" dir.
+            var userData = Path.Combine(dataDirectoryPath, "User Data");
+            if (Directory.Exists(userData))
+            {
+                profileDirectories.Add(userData);
+                var userDataDefault = Path.Combine(userData, "Default");
+                if (Directory.Exists(userDataDefault))
+                    profileDirectories.Add(userDataDefault);
+                profileDirectories.AddRange(Directory.EnumerateDirectories(userData, "Profile *"));
+            }
+        }
+        catch
+        {
+            return BrowserType.Unknown;
+        }

         if (profileDirectories.Any(p => File.Exists(Path.Combine(p, "Bookmarks"))))
         {
             return BrowserType.Chromium;
         }

         // Check for Firefox-based browsers by looking for 'places.sqlite'.
         // This leverages the existing FirefoxProfileFinder logic.
-        if (File.Exists(Path.Combine(dataDirectoryPath, "places.sqlite")) || !string.IsNullOrEmpty(FirefoxProfileFinder.GetPlacesPathFromProfileDir(dataDirectoryPath)))
+        try
+        {
+            if (File.Exists(Path.Combine(dataDirectoryPath, "places.sqlite")) ||
+                !string.IsNullOrEmpty(FirefoxProfileFinder.GetPlacesPathFromProfileDir(dataDirectoryPath)))
+            {
+                return BrowserType.Firefox;
+            }
+        }
+        catch
+        {
+            return BrowserType.Unknown;
+        }
-
-        {
-            return BrowserType.Firefox;
-        }

Also applies to: 30-37

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Views/CustomBrowserSetting.xaml.cs (1)

26-36: Guard Save with CanExecute and mark key events handled

Avoid executing Save when invalid and stop event bubbling.

     private void WindowKeyDown(object sender, KeyEventArgs e)
     {
         if (e.Key == System.Windows.Input.Key.Enter)
         {
-            _viewModel.SaveCommand.Execute(null);
+            if (_viewModel.SaveCommand.CanExecute(null))
+                _viewModel.SaveCommand.Execute(null);
+            e.Handled = true;
         }
         else if (e.Key == System.Windows.Input.Key.Escape)
         {
             _viewModel.CancelCommand.Execute(null);
+            e.Handled = true;
         }
     }

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Models/CustomBrowser.cs (1)

9-12: Initialize non‑nullable strings

Prevents null states if NRT is enabled and avoids null derefs in bindings.

-    private string _name;
-    private string _dataDirectoryPath;
+    private string _name = string.Empty;
+    private string _dataDirectoryPath = string.Empty;
     private BrowserType _browserType = BrowserType.Unknown;

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Views/SettingsControl.xaml (1)

27-41: Localize browser labels (Chrome/Chromium/Edge/Firefox)

Hard‑coded strings bypass Crowdin. Use resource keys like other labels.

-            <CheckBox
-                Margin="{StaticResource SettingPanelItemRightMargin}"
-                Content="Chrome"
-                IsChecked="{Binding Settings.LoadChromeBookmark}" />
+            <CheckBox
+                Margin="{StaticResource SettingPanelItemRightMargin}"
+                Content="{DynamicResource flowlauncher_plugin_browserbookmark_browser_chrome}"
+                IsChecked="{Binding Settings.LoadChromeBookmark}" />
@@
-            <CheckBox
-                Margin="{StaticResource SettingPanelItemRightMargin}"
-                Content="Chromium"
-                IsChecked="{Binding Settings.LoadChromiumBookmark}" />
+            <CheckBox
+                Margin="{StaticResource SettingPanelItemRightMargin}"
+                Content="{DynamicResource flowlauncher_plugin_browserbookmark_browser_chromium}"
+                IsChecked="{Binding Settings.LoadChromiumBookmark}" />
@@
-            <CheckBox
-                Margin="{StaticResource SettingPanelItemRightMargin}"
-                Content="Edge"
-                IsChecked="{Binding Settings.LoadEdgeBookmark}" />
+            <CheckBox
+                Margin="{StaticResource SettingPanelItemRightMargin}"
+                Content="{DynamicResource flowlauncher_plugin_browserbookmark_browser_edge}"
+                IsChecked="{Binding Settings.LoadEdgeBookmark}" />
@@
-            <CheckBox
-                Margin="{StaticResource SettingPanelItemRightMargin}"
-                Content="Firefox"
-                IsChecked="{Binding Settings.LoadFirefoxBookmark}" />
+            <CheckBox
+                Margin="{StaticResource SettingPanelItemRightMargin}"
+                Content="{DynamicResource flowlauncher_plugin_browserbookmark_browser_firefox}"
+                IsChecked="{Binding Settings.LoadFirefoxBookmark}" />

I can add the en.xaml entries if you want.

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Views/SettingsControl.xaml.cs (1)

33-39: Use bound SelectedCustomBrowser consistently

Delete uses the element’s SelectedItem while Edit uses the bound property. Use one pattern for clarity.

-        if (CustomBrowsers.SelectedItem is CustomBrowser selectedCustomBrowser)
-        {
-            Settings.CustomBrowsers.Remove(selectedCustomBrowser);
-        }
+        if (SelectedCustomBrowser is not null)
+            Settings.CustomBrowsers.Remove(SelectedCustomBrowser);

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Services/FirefoxBookmarkLoader.cs (1)

39-83: Consider adding defensive protection against very large bookmark collections.

The current implementation loads all bookmarks into memory before yielding them. For users with extensive bookmark collections, this could cause memory pressure. Consider yielding bookmarks directly as they're read from the database instead of accumulating them first.

Apply this diff to stream bookmarks directly:

 public async IAsyncEnumerable<Bookmark> GetBookmarksAsync([EnumeratorCancellation] CancellationToken cancellationToken = default)
 {
     if (string.IsNullOrEmpty(_placesPath) || !File.Exists(_placesPath))
         yield break;

-    var bookmarks = new List<Bookmark>();
     string? tempDbPath = null;

     try
     {
         // First, try to read directly from the source to avoid a slow file copy
-        await ReadBookmarksFromDb(_placesPath, bookmarks, cancellationToken);
+        await foreach (var bookmark in ReadBookmarksFromDbAsync(_placesPath, cancellationToken))
+        {
+            yield return bookmark;
+        }
     }
     catch (SqliteException ex) when (ex.SqliteErrorCode is 5 or 6) // 5 is SQLITE_BUSY, 6 is SQLITE_LOCKED
     {
         // Fallback to copying the file if the database is locked (e.g., Firefox is open)
         try
         {
             tempDbPath = Path.Combine(_tempPath, $"ff_places_{Guid.NewGuid()}.sqlite");
             File.Copy(_placesPath, tempDbPath, true);
-            await ReadBookmarksFromDb(tempDbPath, bookmarks, cancellationToken);
+            await foreach (var bookmark in ReadBookmarksFromDbAsync(tempDbPath, cancellationToken))
+            {
+                yield return bookmark;
+            }
         }
         catch (Exception copyEx)
         {
             _logException(nameof(FirefoxBookmarkLoader), $"Failed to load {_browserName} bookmarks from fallback copy: {_placesPath}", copyEx);
         }
     }
     catch (Exception e)
     {
         _logException(nameof(FirefoxBookmarkLoader), $"Failed to load {_browserName} bookmarks: {_placesPath}", e);
     }
     finally
     {
         if (tempDbPath != null && File.Exists(tempDbPath))
         {
             try { File.Delete(tempDbPath); } 
             catch(Exception e) { _logException(nameof(FirefoxBookmarkLoader), $"Failed to delete temp db file {tempDbPath}", e); }
         }
     }
-
-    foreach (var bookmark in bookmarks)
-    {
-        yield return bookmark;
-    }
 }

And update the helper method:

-private async Task ReadBookmarksFromDb(string dbPath, ICollection<Bookmark> bookmarks, CancellationToken cancellationToken)
+private async IAsyncEnumerable<Bookmark> ReadBookmarksFromDbAsync(string dbPath, [EnumeratorCancellation] CancellationToken cancellationToken = default)
 {
     var profilePath = Path.GetDirectoryName(dbPath) ?? string.Empty;
     var connectionString = $"Data Source={dbPath};Mode=ReadOnly;Pooling=false;";
     
     await using var dbConnection = new SqliteConnection(connectionString);
     await dbConnection.OpenAsync(cancellationToken);
     await using var command = new SqliteCommand(QueryAllBookmarks, dbConnection);
     await using var reader = await command.ExecuteReaderAsync(cancellationToken);

     while (await reader.ReadAsync(cancellationToken))
     {
         var title = reader["title"]?.ToString() ?? string.Empty;
         var url = reader["url"]?.ToString();

         if (!string.IsNullOrEmpty(url))
         {
-            bookmarks.Add(new Bookmark(title, url, _browserName, profilePath));
+            yield return new Bookmark(title, url, _browserName, profilePath);
         }
     }
 }

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Services/LocalFaviconExtractor.cs (2)

62-90: Consider implementing retry logic for locked database scenarios.

When copying the database file fails due to it being locked or in use, consider implementing retry logic with exponential backoff. This would improve reliability, especially during browser updates or when antivirus software temporarily locks files.

Example retry implementation:

+private async Task<string?> CopyDatabaseWithRetryAsync(string sourcePath, string destPath, int maxRetries = 3, CancellationToken token = default)
+{
+    for (int i = 0; i < maxRetries; i++)
+    {
+        try
+        {
+            File.Copy(sourcePath, destPath, true);
+            return destPath;
+        }
+        catch (IOException) when (i < maxRetries - 1)
+        {
+            await Task.Delay(TimeSpan.FromMilliseconds(100 * Math.Pow(2, i)), token);
+        }
+    }
+    return null;
+}

 try
 {
-    File.Copy(dbPath, tempDbPath, true);
+    var copiedPath = await CopyDatabaseWithRetryAsync(dbPath, tempDbPath, 3, token);
+    if (copiedPath == null)
+    {
+        _context.API.LogDebug(nameof(LocalFaviconExtractor), $"Failed to copy database after retries: {dbPath}");
+        return null;
+    }

---

27-28: Use BrowserType enum instead of string.Contains on Bookmark.Source

LocalFaviconExtractor.GetFaviconDataAsync currently checks bookmark.Source.Contains("Firefox") — brittle. Use the existing BrowserType (Models/CustomBrowser.cs): either add a BrowserType property to Bookmark and set it in the loaders, or resolve bookmark.Source to the matching CustomBrowser and use its BrowserType to choose Firefox vs Chromium DB/query.

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Services/BookmarkLoaderService.cs (1)

104-131: Exception handling for FirefoxProfileFinder calls is redundant.

The try-catch blocks around FirefoxProfileFinder.GetFirefoxPlacesPath() and GetFirefoxMsixPlacesPath() are unnecessary since these methods already have internal exception handling and return null on failure. The current approach logs exceptions that will never be thrown.

Apply this diff to remove redundant exception handling:

 if (_settings.LoadFirefoxBookmark)
 {
-    string? placesPath = null;
-    try
-    {
-        placesPath = FirefoxProfileFinder.GetFirefoxPlacesPath();
-    }
-    catch (Exception ex)
-    {
-        _context.API.LogException(nameof(BookmarkLoaderService), "Failed to find Firefox profile", ex);
-    }
+    var placesPath = FirefoxProfileFinder.GetFirefoxPlacesPath();
     if (!string.IsNullOrEmpty(placesPath))
     {
         yield return new FirefoxBookmarkLoader("Firefox", placesPath, _tempPath, logAction);
     }

-    string? msixPlacesPath = null;
-    try
-    {
-        msixPlacesPath = FirefoxProfileFinder.GetFirefoxMsixPlacesPath();
-    }
-    catch (Exception ex)
-    {
-        _context.API.LogException(nameof(BookmarkLoaderService), "Failed to find Firefox MSIX package", ex);
-    }
+    var msixPlacesPath = FirefoxProfileFinder.GetFirefoxMsixPlacesPath();
     if (!string.IsNullOrEmpty(msixPlacesPath))
     {
         yield return new FirefoxBookmarkLoader("Firefox (Store)", msixPlacesPath, _tempPath, logAction);
     }
 }

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Services/FaviconService.cs (4)

248-257: Avoid O(n²) StringBuilder.ToString() in the read loop.

Converting the entire buffer to a string on each iteration scales poorly. Check only the tail segment.

Apply this diff:

-                if (contentBuilder.ToString().Contains("</head>", StringComparison.OrdinalIgnoreCase))
+                var tailStart = Math.Max(0, contentBuilder.Length - 64);
+                if (contentBuilder
+                    .ToString(tailStart, contentBuilder.Length - tailStart)
+                    .IndexOf("</head>", StringComparison.OrdinalIgnoreCase) >= 0)
                 {
                     break;
                 }

---

348-353: Preserve SVG aspect ratio when scaling to 32x32.

Current independent X/Y scaling can distort icons. Use uniform scale and center.

Apply this diff:

-                using var bitmap = new SKBitmap(32, 32);
-                using var canvas = new SKCanvas(bitmap);
-                canvas.Clear(SKColors.Transparent);
-                var scaleMatrix = SKMatrix.CreateScale(32 / svg.Picture.CullRect.Width, 32 / svg.Picture.CullRect.Height);
-                canvas.DrawPicture(svg.Picture, in scaleMatrix);
+                using var bitmap = new SKBitmap(32, 32);
+                using var canvas = new SKCanvas(bitmap);
+                canvas.Clear(SKColors.Transparent);
+                var rect = svg.Picture.CullRect;
+                var scale = Math.Min(32f / rect.Width, 32f / rect.Height);
+                var tx = (32f - rect.Width * scale) / 2f;
+                var ty = (32f - rect.Height * scale) / 2f;
+                var m = SKMatrix.CreateScale(scale, scale);
+                m = m.PostConcat(SKMatrix.CreateTranslation(tx, ty));
+                canvas.DrawPicture(svg.Picture, in m);

---

364-387: WPF imaging on background threads may require STA.

IconBitmapDecoder/PngBitmapEncoder (WPF) can throw in MTA. Consider a non‑WPF ICO parser (or ImageSharp) to avoid apartment issues, or marshal this block to an STA.

Would you like a minimal ICO reader replacement using ImageSharp or a small ICO parser?

---

111-120: Optional: prefer SHA‑256 for cache keys.

SHA‑1 is fine for non‑security use, but SHA‑256 avoids collision debates at negligible cost.

Apply this diff:

-        var hash = SHA1.HashData(Encoding.UTF8.GetBytes(url));
+        var hash = SHA256.HashData(Encoding.UTF8.GetBytes(url));

(Remember to add using System.Security.Cryptography; if not already present.)

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Main.cs (3)

73-75: Use Volatile.Read to pair with the Volatile.Write.

Ensures readers observe a fully‑published list version.

Apply this diff:

-        var bookmarks = _bookmarks; // use a local copy
+        var bookmarks = Volatile.Read(ref _bookmarks); // read with a memory barrier

---

40-50: Add a one‑time migration to preserve old plugin caches/settings after rename.

Renaming the plugin directory/namespace risks users losing settings and favicon cache. Migrate the old cache on first run.

Apply this diff and add the helper below:

         var tempPath = SetupTempDirectory();
         
         _bookmarkLoader = new BookmarkLoaderService(Context, _settings, tempPath);
         _faviconService = new FaviconService(Context, _settings, tempPath);
+        TryMigrateOldCachesAndSettings();

Add this helper (outside the shown range):

// Place inside Main class
private void TryMigrateOldCachesAndSettings()
{
    try
    {
        // Adjust old IDs/paths if different; this assumes prior plugin folder name
        var oldCache = Path.Combine(Context.CurrentPluginMetadata.PluginDirectory, "..", "Flow.Launcher.Plugin.BrowserBookmark", "Cache", "FaviconCache");
        var newCache = Path.Combine(Context.CurrentPluginMetadata.PluginCacheDirectoryPath, "FaviconCache");
        if (Directory.Exists(oldCache) && !Directory.Exists(newCache))
        {
            Directory.CreateDirectory(Path.GetDirectoryName(newCache)!);
            Directory.Move(oldCache, newCache);
            Context.API.LogInfo(nameof(Main), "Migrated old favicon cache.");
        }
        // If settings storage key changed, consider reading the old JSON and copying relevant fields.
    }
    catch (Exception ex)
    {
        Context.API.LogException(nameof(Main), "Cache/settings migration failed.", ex);
    }
}

---

152-159: Fire‑and‑forget timer loop: capture exceptions to avoid unobserved faults.

Wrap the loop in a try/catch to ensure background exceptions are logged.

Apply this diff:

-        _ = Task.Run(async () =>
-        {
-            while (await _firefoxBookmarkTimer.WaitForNextTickAsync(_cancellationTokenSource.Token))
-            {
-                await ReloadFirefoxBookmarksAsync();
-            }
-        }, _cancellationTokenSource.Token);
+        _ = Task.Run(async () =>
+        {
+            try
+            {
+                while (await _firefoxBookmarkTimer.WaitForNextTickAsync(_cancellationTokenSource.Token))
+                    await ReloadFirefoxBookmarksAsync();
+            }
+            catch (OperationCanceledException) { }
+            catch (Exception ex)
+            {
+                Context.API.LogException(nameof(Main), "Firefox periodic reload loop crashed.", ex);
+            }
+        }, _cancellationTokenSource.Token);

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Views/CustomBrowserSetting.xaml (1)

14-14: MVVM: remove code‑behind KeyDown and bind keys to commands.

Avoid the WindowKeyDown handler; wire Enter/Escape to Save/Cancel.

Apply this diff:

-    KeyDown="WindowKeyDown"

Add key bindings:

   mc:Ignorable="d">
+    <Window.InputBindings>
+        <KeyBinding Key="Enter" Command="{Binding SaveCommand}" />
+        <KeyBinding Key="Escape" Command="{Binding CancelCommand}" />
+    </Window.InputBindings>

Flow.Launcher.sln (1)

72-73: Project type GUID differs from other C# SDK projects.

Most projects use {9A19103F-…} (SDK‑style). If this plugin is SDK‑style too, consider aligning for consistency.

Plugins/Flow.Launcher.Plugin.BrowserBookmarks/Languages/en.xaml (1)

8-8: Clarify description: favicons can come from local DBs too.

Minor copy tweak to reflect behavior accurately.

Apply this diff:

-    <system:String x:Key="flowlauncher_plugin_browserbookmark_plugin_description">Search your browser bookmarks, retrieve favicons from the web.</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_plugin_description">Search your browser bookmarks; show favicons (local cache + optional web fetch).</system:String>