Fix loading when no action keywords present for a plugin in user plugin setting #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web Searches plugin allows users to fully delete all search setting entries, resulting in a scenario where there could be empty action keyword. Current code when flow starts up and there are no action keywords present for the plugin, it switches to populating the action keywords from metadata (plugin.json).
For Web Searches plugin, this causes a mismatch between the flow's setting plugin action keywords data (has action keywords because repopulated from metadata) and the action keywords in Web Searches plugin's own setting (has no action keywords because all deleted).
close #432
also added tool tips to make functionality clearer