upgrade core to 2.30

Author: RubenHalman

package-lock.json

@@ -121,7 +121,7 @@
 		"@types/vscode": "1.47",
 		"convert-array-to-csv": "^2.0.0",
 		"css": "^3.0.0",
-		"lightning-flow-scanner-core": "2.26",
+		"lightning-flow-scanner-core": "2.30",
 		"mz": "^2.7.0",
 		"os": "^0.1.2",
 		"reflect-metadata": "^0.1.13",

package.json

@@ -6,7 +6,7 @@ import {ViewFlowRulesCommand} from "./main/commands/ViewFlowRulesCommand";
 import { ScanOverview } from "./main/panels/ScanOverview";
 import { RuleOverview } from "./main/panels/RuleOverview";
 import { ViolationOverview } from "./main/panels/ViolationOverview";
-import { ScanResult } from "lightning-flow-scanner-core/out/main/models/ScanResult";
+import ScanResult from "lightning-flow-scanner-core/out/main/models/ScanResult";
 
 export function activate(context: vscode.ExtensionContext) {
   let fixFlowsCommand = new FixFlowsCommand(context);

src/extension.ts

@@ -2,7 +2,7 @@ import * as fs from "mz/fs";
 import * as vscode from "vscode";
 import {XMLParser} from "../libs/XMLParser";
 import {BaseCommand} from "./BaseCommand";
-import {Flow} from "lightning-flow-scanner-core/out/main/models/Flow";
+import Flow from "lightning-flow-scanner-core/out/main/models/Flow";
 
 const path = require('path');
 

src/main/commands/CreateTestDataCommand.ts

@@ -1,11 +1,11 @@
 import * as vscode from "vscode";
 import {BaseCommand} from "./BaseCommand";
 import {SaveFlow} from "../libs/SaveFlow";
-import {Flow} from "lightning-flow-scanner-core/out/main/models/Flow";
+import Flow from "lightning-flow-scanner-core/out/main/models/Flow";
 import {SelectFlows} from "../libs/SelectFlows";
 import {ParseFlows} from "../libs/ParseFlows";
 import * as core from "lightning-flow-scanner-core/out";
-import {ScanResult} from "lightning-flow-scanner-core/out/main/models/ScanResult";
+import ScanResult from "lightning-flow-scanner-core/out/main/models/ScanResult";
 import {ScanOverview} from "../panels/ScanOverview";
 
 export class FixFlowsCommand extends BaseCommand {

src/main/commands/FixFlowsCommand.ts

@@ -4,8 +4,8 @@ import { SelectFlows } from "../libs/SelectFlows";
 import { ParseFlows } from "../libs/ParseFlows";
 import { ScanOverview } from "../panels/ScanOverview";
 import * as core from 'lightning-flow-scanner-core/out';
-import { Flow } from "lightning-flow-scanner-core/out/main/models/Flow";
-import { ScanResult } from "lightning-flow-scanner-core/out/main/models/ScanResult";
+import Flow from "lightning-flow-scanner-core/out/main/models/Flow";
+import ScanResult from "lightning-flow-scanner-core/out/main/models/ScanResult";
 import { FindFlowCoverage } from "../libs/FindFlowCoverage";
 
 export class ScanFlowsCommand extends BaseCommand {

src/main/commands/ScanFlowsCommand.ts

@@ -3,7 +3,7 @@ import {XMLParser} from "./XMLParser";
 import * as fs from "mz/fs";
 import {URI} from "vscode-uri";
 import path = require("path");
-import { Flow } from "lightning-flow-scanner-core/out/main/models/Flow";
+import Flow from "lightning-flow-scanner-core/out/main/models/Flow";
 
 
 export class ParseFlows {

src/main/libs/ParseFlows.ts

@@ -1,41 +1,37 @@
 import * as vscode from "vscode";
 import * as child from "child_process";
-import {isWindows} from "./CheckOS";
+import { isWindows } from "./CheckOS";
 
-export function RunSFDXCommand(commandString : string): Promise<any> {
+export function RunSFDXCommand(commandString: string): Promise<any> {
 
-  return new Promise<any>(resolve => {
+  return new Promise<any>((resolve, reject) => {
 
-    if(isWindows()){
+    if (isWindows()) {
       commandString = 'cmd /c ' + commandString;
     }
 
     let workspacePath = vscode.workspace.workspaceFolders;
-    let foo: child.ChildProcess = child.exec(commandString,{
+    let foo: child.ChildProcess = child.exec(commandString, {
       maxBuffer: 1024 * 1024 * 6,
-      cwd: workspacePath?workspacePath[0].uri.fsPath:""
+      cwd: workspacePath ? workspacePath[0].uri.fsPath : ""
     });
 
-    let bufferOutData='';
-    foo.stdout.on("data",(dataArg : any)=> {
-      bufferOutData+=dataArg;
+    let bufferOutData = '';
+    foo.stdout.on("data", (dataArg: any) => {
+      bufferOutData += dataArg;
     });
 
-    foo.stderr.on("data",(data : any)=> {
+    foo.stderr.on("data", (data: any) => {
       vscode.window.showErrorMessage(data);
-      resolve();
     });
 
-    foo.stdin.on("data",(data : any)=> {
-      vscode.window.showErrorMessage(data);
-      resolve();
-    });
-
-    foo.on('exit',(code,signal)=>{
-      let data = JSON.parse(bufferOutData);
-      resolve(data);
+    foo.on('exit', (code, signal) => {
+      if (code === 0) {
+        let data = JSON.parse(bufferOutData);
+        resolve(data);
+      } else {
+        reject(new Error(`Command execution failed with code ${code}.`));
+      }
     });
-
-
   });
 }

src/main/libs/RunCommand.ts

@@ -1,7 +1,7 @@
 import * as fs from "mz/fs";
 const xml2js = require("xml2js");
 import {URI} from 'vscode-uri';
-import { Flow } from "lightning-flow-scanner-core/out/main/models/Flow";
+import Flow from "lightning-flow-scanner-core/out/main/models/Flow";
 
 
 export class SaveFlow {

src/main/libs/SaveFlow.ts

@@ -1,6 +1,6 @@
 import {Parser} from 'xml2js';
 const xml2js = require("xml2js");
-import { Flow } from 'lightning-flow-scanner-core/out/main/models/Flow';
+import Flow from 'lightning-flow-scanner-core/out/main/models/Flow';
 
 export class XMLParser{