pull image on ssh

Author: gy2006

docker/src/main/java/com/flowci/docker/DockerSDKManager.java

@@ -47,7 +47,7 @@ public ImageManager getImageManager() {
     private class ImageMangerImpl implements ImageManager {
 
         @Override
-        public void pull(String image, int timeoutInSeconds, Consumer<PullResponseItem> progress) throws Exception {
+        public void pull(String image, int timeoutInSeconds, Consumer<String> progress) throws Exception {
             String imageUrl = "docker.io/library/" + image;
             if (image.contains("/")) {
                 imageUrl = "docker.io/" + image;
@@ -65,6 +65,10 @@ public void pull(String image, int timeoutInSeconds, Consumer<PullResponseItem>
                     throw new DockerException(String.format("Timeout when pull image %s", image), 0);
                 }
 
+                if (callback.hasError()) {
+                    throw new DockerException(callback.getThrowable().getMessage(), 0);
+                }
+
                 if (findImage(client, image).isEmpty()) {
                     throw new DockerException(String.format("Failed on pull image %s", image), 0);
                 }
@@ -183,16 +187,16 @@ private DockerClient newClient() {
 
     private static class PullImageCallback extends DockerCallback<PullResponseItem> {
 
-        private final Consumer<PullResponseItem> progress;
+        private final Consumer<String> progress;
 
-        private PullImageCallback(Consumer<PullResponseItem> progress) {
+        private PullImageCallback(Consumer<String> progress) {
             this.progress = progress;
         }
 
         @Override
         public void onNext(PullResponseItem item) {
             if (progress != null && item != null) {
-                progress.accept(item);
+                progress.accept(item.getStatus());
             }
         }
     }

docker/src/main/java/com/flowci/docker/DockerSSHManager.java

@@ -8,10 +8,9 @@
 import com.flowci.docker.domain.SSHOption;
 import com.flowci.domain.ObjectWrapper;
 import com.flowci.util.StringHelper;
+import com.github.dockerjava.api.DockerClient;
 import com.github.dockerjava.api.command.InspectContainerResponse;
-import com.github.dockerjava.api.model.Container;
-import com.github.dockerjava.api.model.Frame;
-import com.github.dockerjava.api.model.StreamType;
+import com.github.dockerjava.api.model.*;
 import com.jcraft.jsch.*;
 import lombok.AllArgsConstructor;
 import lombok.Getter;
@@ -35,6 +34,8 @@ public class DockerSSHManager implements DockerManager {
 
     private final ContainerManager containerManager = new ContainerManagerImpl();
 
+    private final ImageManager imageManager = new ImageManagerImpl();
+
     static {
         mapper.setSerializationInclusion(JsonInclude.Include.NON_NULL);
         mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
@@ -61,7 +62,38 @@ public ContainerManager getContainerManager() {
 
     @Override
     public ImageManager getImageManager() {
-        return null;
+        return imageManager;
+    }
+
+    private class ImageManagerImpl implements ImageManager {
+
+        @Override
+        public void pull(String image, int ignore, Consumer<String> progress) throws Exception {
+            List<Image> list = findImage(image);
+            if (list.size() > 0) {
+                return;
+            }
+            String cmd = String.format("docker pull %s", image);
+            Output output = runCmd(cmd, (log) -> {
+                if (progress != null) {
+                    progress.accept(log);
+                }
+            });
+            throwExceptionIfError(output);
+        }
+
+        private List<Image> findImage(String image) throws Exception {
+            String cmd = String.format("docker image ls --filter reference=\"%s\" %s", image, FormatAsJson);
+            List<Image> list = new LinkedList<>();
+            Output output = runCmd(cmd, (line) -> {
+                try {
+                    list.add(mapper.readValue(line, Image.class));
+                } catch (JsonProcessingException ignore) {
+                }
+            });
+            throwExceptionIfError(output);
+            return list;
+        }
     }
 
     private class ContainerManagerImpl implements ContainerManager {

docker/src/main/java/com/flowci/docker/ImageManager.java

@@ -1,13 +1,11 @@
 package com.flowci.docker;
 
-import com.github.dockerjava.api.model.PullResponseItem;
-
 import java.util.function.Consumer;
 
 public interface ImageManager {
 
     /**
      * Sync call
      */
-    void pull(String image, int timeoutInSeconds, Consumer<PullResponseItem> progress) throws Exception;
+    void pull(String image, int timeoutInSeconds, Consumer<String> progress) throws Exception;
 }

docker/src/main/java/com/flowci/docker/domain/DockerCallback.java

@@ -12,14 +12,18 @@ public abstract class DockerCallback<T> implements ResultCallback<T> {
     @Getter
     protected final CountDownLatch counter = new CountDownLatch(1);
 
+    @Getter
+    protected Throwable throwable;
+
     @Override
     public void onStart(Closeable closeable) {
 
     }
 
     @Override
     public void onError(Throwable throwable) {
-
+        this.throwable = throwable;
+        counter.countDown();
     }
 
     @Override
@@ -31,4 +35,8 @@ public void onComplete() {
     public void close() throws IOException {
 
     }
+
+    public boolean hasError() {
+        return this.throwable != null;
+    }
 }

docker/src/test/java/com/flowci/docker/test/DockerSDKManagerTest.java

@@ -29,9 +29,12 @@ public void clean() {
 
     @Test
     public void should_pull_image() throws Exception {
-        manager.getImageManager().pull("hello-world", 60, (item) -> {
-            System.out.println(item.getStatus());
-        });
+        manager.getImageManager().pull("ubuntu:18.04", 60, System.out::println);
+    }
+
+    @Test(expected = Exception.class)
+    public void should_throw_exception_if_image_not_found() throws Exception {
+        manager.getImageManager().pull("ubuntu:notfound", 120, null);
     }
 
     @Test

docker/src/test/java/com/flowci/docker/test/DockerSSHManagerTest.java

@@ -32,6 +32,16 @@ public void should_list_containers() throws Exception {
         Assert.assertNotNull(list);
     }
 
+    @Test
+    public void should_pull_image_and_print_log() throws Exception {
+        manager.getImageManager().pull("ubuntu:18.04", 60, System.out::println);
+    }
+
+    @Test(expected = Exception.class)
+    public void should_throw_exception_if_image_not_found() throws Exception {
+        manager.getImageManager().pull("ubuntu:notfound", 10, null);
+    }
+
     @Test
     public void should_create_start_and_delete_container() throws Exception {
         DockerStartOption option = new DockerStartOption();