Skip to content

Commit 429d801

Browse files
committed
fix commit status api url
1 parent 6bc2bb2 commit 429d801

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

core/src/main/java/com/flowci/core/git/client/GithubAPIClient.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import com.flowci.exception.CIException;
1313
import com.flowci.exception.UnsupportedException;
1414
import lombok.extern.log4j.Log4j2;
15+
import org.springframework.http.HttpStatus;
1516
import org.springframework.web.util.UriTemplate;
1617

1718
import java.net.URI;
@@ -56,13 +57,18 @@ public void writeCommitStatus(GitCommitStatus commit, Secret secret) {
5657
body.description = commit.getDesc();
5758

5859
try {
59-
var api = String.format(CommitStatusAPI, repo.getOwner(), repo.getOwner(), commit.getId());
60+
var api = String.format(CommitStatusAPI, repo.getOwner(), repo.getName(), commit.getId());
6061
var request = getRequestBuilder(api, tokenSecret.getTokenData())
6162
.POST(HttpRequest.BodyPublishers.ofString(objectMapper.writeValueAsString(body)))
6263
.build();
6364

6465
httpClient.sendAsync(request, HttpResponse.BodyHandlers.ofString())
65-
.thenAccept(r -> log.info("Update commit status on {} is {}", commit.getUrl(), r.statusCode()));
66+
.thenAccept(r -> {
67+
log.info("Update commit status on {} is {}", commit.getUrl(), r.statusCode());
68+
if (r.statusCode() != HttpStatus.OK.value()) {
69+
log.debug(r.body());
70+
}
71+
});
6672

6773
} catch (JsonProcessingException e) {
6874
throw new CIException("Unable to convert github commit body to json: " + e.getMessage());

core/src/main/java/com/flowci/core/git/domain/GitRepo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ public class GitRepo {
1313

1414
private String owner;
1515

16-
private String repo;
16+
private String name;
1717
}

core/src/main/java/com/flowci/core/job/service/JobServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ public Job rerun(Flow flow, Job job) {
289289
continue;
290290
}
291291

292-
if (Objects.equals(key, COMMIT_ID)) {
292+
if (Objects.equals(key, COMMIT_ID) || Objects.equals(key, SOURCE) || Objects.equals(key, EVENT)) {
293293
continue;
294294
}
295295

core/src/test/java/com/flowci/core/test/git/GitHubClientTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ public void should_extract_owner_repo_from_commit_url() {
1515

1616
GitRepo repo = GithubAPIClient.getRepo(commit);
1717
Assert.assertEquals("gy2006", repo.getOwner());
18-
Assert.assertEquals("ci-test", repo.getRepo());
18+
Assert.assertEquals("ci-test", repo.getName());
1919

2020
commit.setUrl("[email protected]:gy2006/ci-test.git");
2121
repo = GithubAPIClient.getRepo(commit);
2222
Assert.assertEquals("gy2006", repo.getOwner());
23-
Assert.assertEquals("ci-test", repo.getRepo());
23+
Assert.assertEquals("ci-test", repo.getName());
2424

2525
commit.setUrl("ssh://[email protected]:gy2006/ci-test.git");
2626
repo = GithubAPIClient.getRepo(commit);
2727
Assert.assertEquals("gy2006", repo.getOwner());
28-
Assert.assertEquals("ci-test", repo.getRepo());
28+
Assert.assertEquals("ci-test", repo.getName());
2929
}
3030
}

0 commit comments

Comments
 (0)