fix delete nodeResult error and add test

Author: yunheli

platform-api/src/main/java/com/flow/platform/api/dao/job/NodeResultDaoImpl.java

@@ -28,7 +28,6 @@
 import javax.persistence.criteria.Predicate;
 import javax.persistence.criteria.Root;
 import org.hibernate.Session;
-import org.hibernate.query.Query;
 import org.springframework.stereotype.Repository;
 
 /**
@@ -100,11 +99,8 @@ public int update(BigInteger jobId, NodeStatus target) {
 
     @Override
     public void delete(List<BigInteger> jobIds) {
-        execute((Session session) -> {
-            String delete = String.format("delete from NodeResult where job_id in (:list)");
-            Query query = session.createQuery(delete);
-            query.setParameterList("list", jobIds);
-            return true;
-        });
+        execute((Session session) -> session.createQuery("delete from NodeResult where key.jobId in ( :jobIds )")
+            .setParameterList("jobIds", jobIds)
+            .executeUpdate());
     }
 }

platform-api/src/test/java/com/flow/platform/api/test/service/NodeServiceTest.java

@@ -18,6 +18,8 @@
 import static junit.framework.TestCase.fail;
 
 import com.flow.platform.api.domain.Webhook;
+import com.flow.platform.api.domain.job.Job;
+import com.flow.platform.api.domain.job.NodeResult;
 import com.flow.platform.api.domain.node.Node;
 import com.flow.platform.api.domain.node.Yml;
 import com.flow.platform.api.envs.EnvUtil;
@@ -30,6 +32,7 @@
 import com.flow.platform.api.test.TestBase;
 import com.flow.platform.api.util.NodeUtil;
 import com.flow.platform.core.exception.IllegalParameterException;
+import com.flow.platform.core.exception.NotFoundException;
 import com.flow.platform.util.http.HttpURL;
 import java.nio.file.Files;
 import java.util.HashMap;
@@ -255,8 +258,10 @@ public void should_error_if_node_path_is_not_for_flow() throws Throwable {
         ymlService.get(root);
     }
 
-    @Test
+    @Test(expected = NotFoundException.class)
     public void should_delete_flow() throws Throwable {
+        stubDemo();
+
         Node emptyFlow = nodeService.createEmptyFlow("flow1");
         setFlowToReady(emptyFlow);
 
@@ -266,6 +271,12 @@ public void should_delete_flow() throws Throwable {
         Assert.assertNotNull(nodeService.find(root.getPath()));
         Assert.assertNotNull(ymlService.get(root).getFile());
 
+        setRequiredJobEnvsForFlow(root);
+        Job job = createMockJob(root.getPath());
+
+        Assert.assertNotNull(jobService.find(job.getId()));
+        Assert.assertEquals(2, nodeResultService.list(job, true).size());
+
         // when: delete flow
         nodeService.delete(root.getPath());
 
@@ -275,6 +286,13 @@ public void should_delete_flow() throws Throwable {
 
         // then: should return null if root node is not existed
         Assert.assertNull(ymlService.get(root));
+
+        // then: node result should be null
+        List<NodeResult> nodeResults = nodeResultService.list(job, true);
+        Assert.assertEquals(0, nodeResults.size());
+
+        // then: job should be null
+        jobService.find(job.getId());
     }
 
     @Test