api add empty space check when create agent

Author: Yang Guo

platform-api/src/main/java/com/flow/platform/api/service/AgentServiceImpl.java

@@ -26,6 +26,7 @@
 import com.flow.platform.api.service.job.JobService;
 import com.flow.platform.api.util.PlatformURL;
 import com.flow.platform.core.exception.HttpException;
+import com.flow.platform.core.exception.IllegalParameterException;
 import com.flow.platform.core.exception.IllegalStatusException;
 import com.flow.platform.core.service.ApplicationEventService;
 import com.flow.platform.domain.Agent;
@@ -38,6 +39,7 @@
 import com.flow.platform.domain.Jsonable;
 import com.flow.platform.util.CollectionUtil;
 import com.flow.platform.util.Logger;
+import com.flow.platform.util.StringUtil;
 import com.flow.platform.util.http.HttpClient;
 import com.flow.platform.util.http.HttpResponse;
 import com.flow.platform.util.http.HttpURL;
@@ -144,6 +146,10 @@ public Boolean shutdown(String zone, String name, String password) {
 
     @Override
     public AgentWithFlow create(AgentPath agentPath) {
+        if (StringUtil.hasSpace(agentPath.getZone()) || StringUtil.hasSpace(agentPath.getName())) {
+            throw new IllegalParameterException("Zone name or agent name cannot contain empty space");
+        }
+
         try {
             AgentPathWithWebhook pathWithWebhook = new AgentPathWithWebhook(agentPath, buildAgentWebhook());
 
@@ -158,9 +164,7 @@ public AgentWithFlow create(AgentPath agentPath) {
             }
 
             Agent agent = Agent.parse(response.getBody(), Agent.class);
-
-            AgentWithFlow agentWithFlow = new AgentWithFlow(agent, null);
-            return agentWithFlow;
+            return new AgentWithFlow(agent, null);
 
         } catch (UnsupportedEncodingException | JsonSyntaxException e) {
             throw new IllegalStatusException("Unable to create agent", e);

platform-util/src/main/java/com/flow/platform/util/StringUtil.java

@@ -25,6 +25,10 @@ public class StringUtil {
 
     public final static String EMPTY = "";
 
+    public static boolean hasSpace(final String str) {
+        return str.contains(" ");
+    }
+
     public static boolean isNullOrEmptyForItems(final String... strings) {
         if (CollectionUtil.isNullOrEmpty(strings)) {
             return true;