get rid off compare id and url for pr since two diff repo

Author: Yang Guo

platform-api/src/main/java/com/flow/platform/api/git/GitEventEnvConverter.java

@@ -82,12 +82,6 @@ public static Map<String, String> convert(GitEvent event) {
                 info.put(GitEnvs.FLOW_GIT_COMMIT_URL.name(), pr.getUrl());
             }
 
-            // set compare id and url from PR request
-            if (pr.getCompareId() != null && pr.getCompareUrl() != null) {
-                info.put(GitEnvs.FLOW_GIT_COMPARE_ID.name(), pr.getCompareId());
-                info.put(GitEnvs.FLOW_GIT_COMPARE_URL.name(), pr.getCompareUrl());
-            }
-
             info.put(GitEnvs.FLOW_GIT_CHANGELOG.name(), pr.getTitle());
             info.put(GitEnvs.FLOW_GIT_PR_URL.name(), pr.getUrl());
             return info;

platform-util-git/src/main/java/com/flow/platform/util/git/hooks/CodingEvents.java

@@ -258,11 +258,6 @@ public GitEvent convert(String json) throws GitException {
             event.getTarget().setProjectId(Integer.parseInt(repo.id));
             event.getTarget().setProjectName(repo.name);
 
-            // set compare id
-            final String compareId = GitPullRequestEvent.buildCompareId(event.getSource(), event.getTarget());
-            event.setCompareId(compareId);
-            event.setCompareUrl(repo.url + "/git/compare/" + compareId);
-
             return event;
         }
     }

platform-util-git/src/main/java/com/flow/platform/util/git/hooks/GitHubEvents.java

@@ -219,10 +219,6 @@ else if (Objects.equals(pullRequest.state, STATE_CLOSE)) {
             target.setBranch(pullRequest.target.ref);
             target.setSha(pullRequest.target.sha);
 
-            // set compare id
-            final String compareId = GitPullRequestEvent.buildCompareId(source, target);
-            event.setCompareId(compareId);
-            event.setCompareUrl(mr.repository.url + "/compare/" + compareId);
             return event;
         }
     }

platform-util-git/src/test/java/com/flow/platform/util/git/test/CodingWebHooksEventTest.java

@@ -139,10 +139,6 @@ public void should_convert_to_pr_open_event_obj() throws Throwable {
         Assert.assertEquals("", target.getSha());
         Assert.assertEquals(1243975, target.getProjectId().intValue());
         Assert.assertEquals("flowclibasic", target.getProjectName());
-
-        Assert.assertEquals("develop...master", prEvent.getCompareId());
-        Assert.assertEquals("https://coding.net/u/benqyang2006/p/flowclibasic/git/compare/develop...master",
-            prEvent.getCompareUrl());
     }
 
     @Test
@@ -181,10 +177,6 @@ public void should_convert_to_pr_close_obj() throws Throwable {
         Assert.assertEquals("985ae638e0cc8bd4dc2cd8c7a8a6800b00b33997", target.getSha());
         Assert.assertEquals(1243975, target.getProjectId().intValue());
         Assert.assertEquals("flowclibasic", target.getProjectName());
-
-        Assert.assertEquals("985ae638e0cc...db2da0ba563a", prEvent.getCompareId());
-        Assert.assertEquals("https://coding.net/u/benqyang2006/p/flowclibasic/git/compare/985ae638e0cc...db2da0ba563a",
-            prEvent.getCompareUrl());
     }
 
     private static String loadWebhookSampleJson(String classPath) throws IOException {

platform-util-git/src/test/java/com/flow/platform/util/git/test/GitHubHooksEventTest.java

@@ -145,10 +145,6 @@ public void should_convert_to_pr_event_obj() throws Throwable {
         Assert.assertEquals(86284448, target.getProjectId().intValue());
         Assert.assertEquals("yang-guo-2016/Test", target.getProjectName());
         Assert.assertEquals("4e4e3750cd468f245bd9f0f938c4b5f76e1bc5b0", target.getSha());
-
-        Assert.assertEquals("4e4e3750cd46...1d1de876084e", event.getCompareId());
-        Assert.assertEquals("https://github.com/yang-guo-2016/Test/compare/4e4e3750cd46...1d1de876084e",
-            event.getCompareUrl());
     }
 
     private static String loadWebhookSampleJson(String classPath) throws IOException {