Disabled email addresses which don't have any private keys.| #378

Author: DenBond7

FlowCrypt/src/main/java/com/flowcrypt/email/ui/activity/fragment/base/CreateMessageFragment.java

@@ -53,6 +53,7 @@
 import com.flowcrypt.email.database.dao.source.AccountDao;
 import com.flowcrypt.email.database.dao.source.AccountDaoSource;
 import com.flowcrypt.email.database.dao.source.ContactsDaoSource;
+import com.flowcrypt.email.database.dao.source.UserIdEmailsKeysDaoSource;
 import com.flowcrypt.email.js.Js;
 import com.flowcrypt.email.js.JsForUiManager;
 import com.flowcrypt.email.js.PgpContact;
@@ -66,6 +67,7 @@
 import com.flowcrypt.email.ui.activity.SelectContactsActivity;
 import com.flowcrypt.email.ui.activity.fragment.dialog.NoPgpFoundDialogFragment;
 import com.flowcrypt.email.ui.activity.listeners.OnChangeMessageEncryptedTypeListener;
+import com.flowcrypt.email.ui.adapter.FromAddressesAdapter;
 import com.flowcrypt.email.ui.adapter.PgpContactAdapter;
 import com.flowcrypt.email.ui.loader.LoadGmailAliasesLoader;
 import com.flowcrypt.email.ui.loader.UpdateInfoAboutPgpContactsAsyncTaskLoader;
@@ -76,6 +78,7 @@
 import com.flowcrypt.email.util.GeneralUtil;
 import com.flowcrypt.email.util.UIUtil;
 import com.flowcrypt.email.util.exception.FlowCryptException;
+import com.google.android.gms.common.util.CollectionUtils;
 import com.google.android.material.snackbar.Snackbar;
 import com.google.android.material.textfield.TextInputLayout;
 import com.hootsuite.nachos.NachoTextView;
@@ -135,7 +138,7 @@ public class CreateMessageFragment extends BaseSyncFragment implements View.OnFo
   private IncomingMessageInfo incomingMessageInfo;
   private ServiceInfo serviceInfo;
   private AccountDao accountDao;
-  private ArrayAdapter<String> fromAddressesArrayAdapter;
+  private FromAddressesAdapter<String> fromAddressesArrayAdapter;
   private PgpContact pgpContactWithNoPublicKey;
   private ExtraActionInfo extraActionInfo;
   private MessageType messageType = MessageType.NEW;
@@ -166,6 +169,7 @@ public class CreateMessageFragment extends BaseSyncFragment implements View.OnFo
   private boolean isUpdateInfoAboutBccCompleted = true;
   private boolean isIncomingMessageInfoUsed;
   private boolean isMessageSentToQueue;
+  private int originalColor;
 
   public CreateMessageFragment() {
     pgpContactsTo = new ArrayList<>();
@@ -197,11 +201,15 @@ public void onCreate(@Nullable Bundle savedInstanceState) {
     initDraftCacheDirectory();
 
     accountDao = new AccountDaoSource().getActiveAccountInformation(getContext());
-    fromAddressesArrayAdapter = new ArrayAdapter<>(getContext(),
+    fromAddressesArrayAdapter = new FromAddressesAdapter<>(getContext(),
         android.R.layout.simple_list_item_1, android.R.id.text1, new ArrayList<String>());
     fromAddressesArrayAdapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
+    fromAddressesArrayAdapter.setUseKeysInfo(onChangeMessageEncryptedTypeListener.getMessageEncryptionType()
+        == MessageEncryptionType.ENCRYPTED);
     if (accountDao != null) {
       fromAddressesArrayAdapter.add(accountDao.getEmail());
+      fromAddressesArrayAdapter.updateKeyAvailable(accountDao.getEmail(), !CollectionUtils.isEmpty(
+          new UserIdEmailsKeysDaoSource().getLongIdsByEmail(getContext(), accountDao.getEmail())));
     }
 
     js = JsForUiManager.getInstance(getContext()).getJs();
@@ -553,6 +561,11 @@ public void handleSuccessLoaderResult(int loaderId, Object result) {
         fromAddressesArrayAdapter.clear();
         fromAddressesArrayAdapter.addAll(aliases);
 
+        for (String email : aliases) {
+          fromAddressesArrayAdapter.updateKeyAvailable(email, !CollectionUtils.isEmpty(
+              new UserIdEmailsKeysDaoSource().getLongIdsByEmail(getContext(), email)));
+        }
+
         prepareAliasForReplyIfNeed(aliases);
 
         if (fromAddressesArrayAdapter.getCount() == 1) {
@@ -655,6 +668,13 @@ public void onItemSelected(AdapterView<?> parent, View view, int position, long
     switch (parent.getId()) {
       case R.id.spinnerFrom:
         editTextFrom.setText((CharSequence) parent.getAdapter().getItem(position));
+        if (onChangeMessageEncryptedTypeListener.getMessageEncryptionType() == MessageEncryptionType.ENCRYPTED) {
+          ArrayAdapter adapter = (ArrayAdapter) parent.getAdapter();
+          int colorGray = UIUtil.getColor(getContext(), R.color.gray);
+          editTextFrom.setTextColor(adapter.isEnabled(position) ? originalColor : colorGray);
+        } else {
+          editTextFrom.setTextColor(originalColor);
+        }
         break;
     }
   }
@@ -700,6 +720,12 @@ public void onMessageEncryptionTypeChange(MessageEncryptionType messageEncryptio
           editTextRecipientsTo.getOnFocusChangeListener().onFocusChange(editTextRecipientsTo, false);
           editTextRecipientsCc.getOnFocusChangeListener().onFocusChange(editTextRecipientsCc, false);
           editTextRecipientsBcc.getOnFocusChangeListener().onFocusChange(editTextRecipientsBcc, false);
+          fromAddressesArrayAdapter.setUseKeysInfo(true);
+
+          int colorGray = UIUtil.getColor(getContext(), R.color.gray);
+          boolean isItemEnabled = fromAddressesArrayAdapter.isEnabled(spinnerFrom.getSelectedItemPosition());
+          editTextFrom.setTextColor(isItemEnabled ? originalColor : colorGray);
+
           break;
 
         case STANDARD:
@@ -710,6 +736,8 @@ public void onMessageEncryptionTypeChange(MessageEncryptionType messageEncryptio
           isUpdateInfoAboutToCompleted = true;
           isUpdateInfoAboutCcCompleted = true;
           isUpdateInfoAboutBccCompleted = true;
+          fromAddressesArrayAdapter.setUseKeysInfo(false);
+          editTextFrom.setTextColor(originalColor);
           break;
       }
     }
@@ -1026,6 +1054,11 @@ private boolean isAllInformationCorrect() {
     editTextRecipientsCc.chipifyAllUnterminatedTokens();
     editTextRecipientsBcc.chipifyAllUnterminatedTokens();
 
+    if (!fromAddressesArrayAdapter.isEnabled(spinnerFrom.getSelectedItemPosition())) {
+      showInfoSnackbar(editTextRecipientsTo, getString(R.string.no_key_available));
+      return false;
+    }
+
     if (TextUtils.isEmpty(editTextRecipientsTo.getText().toString())) {
       showInfoSnackbar(editTextRecipientsTo, getString(R.string.text_must_not_be_empty,
           getString(R.string.prompt_recipients_to)));
@@ -1166,6 +1199,7 @@ private void initViews(View view) {
     spinnerFrom.setAdapter(fromAddressesArrayAdapter);
 
     editTextFrom = view.findViewById(R.id.editTextFrom);
+    originalColor = editTextFrom.getCurrentTextColor();
 
     imageButtonAliases = view.findViewById(R.id.imageButtonAliases);
     if (imageButtonAliases != null) {

FlowCrypt/src/main/java/com/flowcrypt/email/ui/adapter/FromAddressesAdapter.java

@@ -0,0 +1,91 @@
+/*
+ * © 2016-2018 FlowCrypt Limited. Limitations apply. Contact [email protected]
+ * Contributors: DenBond7
+ */
+
+package com.flowcrypt.email.ui.adapter;
+
+import android.content.Context;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.ArrayAdapter;
+import android.widget.TextView;
+
+import com.flowcrypt.email.R;
+import com.flowcrypt.email.util.UIUtil;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
+
+/**
+ * This is a custom realization of {@link ArrayAdapter} which can be used for showing the sender addresses.
+ *
+ * @author Denis Bondarenko
+ * Date: 28.11.2018
+ * Time: 5:22 PM
+ * E-mail: [email protected]
+ */
+public class FromAddressesAdapter<T> extends ArrayAdapter<T> {
+  private Map<String, Boolean> infoAboutKeysAvailable = new HashMap<>();
+  private int originalColor;
+  private boolean useKeysInfo;
+
+  public FromAddressesAdapter(@NonNull Context context, int resource, int textViewResId, @NonNull List<T> objects) {
+    super(context, resource, textViewResId, objects);
+  }
+
+  @Override
+  public View getDropDownView(int position, @Nullable View convertView, @NonNull ViewGroup parent) {
+    View view = super.getDropDownView(position, convertView, parent);
+
+    TextView textView = view.findViewById(android.R.id.text1);
+
+    if (textView != null) {
+      textView.setTextColor(isEnabled(position) ? originalColor : UIUtil.getColor(getContext(), R.color.gray));
+    }
+
+    return view;
+  }
+
+  @Override
+  public boolean isEnabled(int position) {
+    if (useKeysInfo && getItem(position) instanceof String) {
+      String email = (String) getItem(position);
+      return infoAboutKeysAvailable.get(email);
+    } else return super.isEnabled(position);
+  }
+
+  @Override
+  public void setDropDownViewResource(int resource) {
+    super.setDropDownViewResource(resource);
+    TextView textView = (TextView) LayoutInflater.from(getContext()).inflate(resource, null);
+    originalColor = textView.getCurrentTextColor();
+  }
+
+  /**
+   * This method can be used to disable the keys checking.
+   *
+   * @param useKeysInfo true if we want to check the key available, otherwise false.
+   */
+  public void setUseKeysInfo(boolean useKeysInfo) {
+    this.useKeysInfo = useKeysInfo;
+    notifyDataSetChanged();
+  }
+
+  /**
+   * Update information about the key availability for the given email.
+   *
+   * @param emailAddress The given email address
+   * @param hasPgp       true if we have a private key for the given email address, otherwise false
+   */
+  public void updateKeyAvailable(String emailAddress, boolean hasPgp) {
+    if (infoAboutKeysAvailable != null) {
+      infoAboutKeysAvailable.put(emailAddress, hasPgp);
+    }
+  }
+}

FlowCrypt/src/main/res/values/strings.xml

@@ -416,4 +416,5 @@ icelanders prefer real sauna</font>
     <string name="see_backups_to_save_your_private_keys">Not implemented yet, see \"Backups\" to save your private key to file</string>
     <string name="copied">Copied</string>
     <string name="saved">Saved</string>
+    <string name="no_key_available">No key available for your email account</string>
 </resources>