fix: stablize test

Author: ioanatflowcrypt

test/source/browser/controllable.ts

@@ -121,6 +121,29 @@ abstract class ControllableBase {
     throw Error(`waiting failed: Elements did not receive the focus: ${selector}`);
   };
 
+  /**
+ * Wait for iframes to be present on the page with retry logic.
+ * This is useful in CI environments where iframe injection can be slower.
+ * @param maxAttempts - Maximum number of retry attempts (default: 3)
+ * @param timeoutPerAttempt - Timeout in seconds for each attempt (default: 20)
+ * @returns Promise that resolves when iframes are found
+ */
+  public waitForIframes = async (maxAttempts = 3, timeoutPerAttempt = 20): Promise<void> => {
+    for (let attempt = 1; attempt <= maxAttempts; attempt++) {
+      try {
+        await this.waitAll('iframe', { timeout: timeoutPerAttempt });
+        return; // Success - iframes found
+      } catch {
+        if (attempt === maxAttempts) {
+          throw new Error(`Failed to find iframes after ${maxAttempts} attempts with ${timeoutPerAttempt}s timeout each`);
+        }
+        // Log and retry
+        console.log(`Attempt ${attempt}/${maxAttempts}: iframes not found yet, retrying...`);
+        await Util.sleep(1); // Brief wait before retry
+      }
+    }
+  };
+
   public notPresent = async (selector: string | string[]) => {
     return await this.waitTillGone(selector, { timeout: 0 });
   };
@@ -404,7 +427,7 @@ abstract class ControllableBase {
     }
     throw new Error(
       `Selector ${selector} was found but did not match "${needle}" within ${timeoutSec}s. ` +
-        `Observed content history: "${JSON.stringify(observedContentHistory, undefined, 2)}"`
+      `Observed content history: "${JSON.stringify(observedContentHistory, undefined, 2)}"`
     );
   };
 
@@ -716,7 +739,7 @@ class ConsoleEvent {
   public constructor(
     public type: string,
     public text: string
-  ) {}
+  ) { }
 }
 
 export class ControllablePage extends ControllableBase {

test/source/tests/decrypt.ts

@@ -1188,7 +1188,7 @@ XZ8r4OC6sguP/yozWlkG+7dDxsgKQVBENeG6Lw==
       testWithBrowser(async (t, browser) => {
         const msgId = '18ecbf57e1dfb9b5';
         const testPrintBlockInPage = async (page: ControllablePage) => {
-          await page.waitAll('iframe');
+          await page.waitForIframes();
           const pgpBlock = await page.getFrame(['pgp_block.htm']);
           await pgpBlock.waitForSelTestState('ready');
           const expectedPrintDateString = new Date(1712818847000).toLocaleString();

test/source/tests/tooling/browser-recipe.ts

@@ -273,7 +273,6 @@ export class BrowserRecipe {
     return { acctEmail, passphrase: key.passphrase, settingsPage };
   };
 
-  // todo: move to gmail-page-recipe
   public static pgpBlockVerifyDecryptedContent = async (
     t: AvaContext,
     browser: BrowserHandle,
@@ -289,15 +288,16 @@ export class BrowserRecipe {
   // todo: move some of these helpers somewhere to page-recipe/...
   // gmail or inbox
   public static checkDecryptMsgOnPage = async (t: AvaContext, page: ControllablePage, m: TestMessageAndSession) => {
-    await page.waitAll('iframe');
+    // Wait for iframes with retry logic to handle slower CI environments
+    await page.waitForIframes();
     if (m.finishSessionBeforeTesting) {
       await BrowserRecipe.finishSession(page);
-      await page.waitAll('iframe');
+      await page.waitForIframes();
     }
     await BrowserRecipe.pgpBlockCheck(t, await page.getFrame(['pgp_block.htm']), m);
     if (m.finishSessionAfterTesting) {
       await BrowserRecipe.finishSession(page);
-      await page.waitAll('iframe');
+      await page.waitForIframes();
       const pgpBlockFrame = await page.getFrame(['pgp_block.htm']);
       await pgpBlockFrame.waitAll('@pgp-block-content');
       await pgpBlockFrame.waitForSelTestState('ready');