fix: lint issue

Author: ioanatflowcrypt

test/source/tests/page-recipe/oauth-page-recipe.ts

@@ -9,45 +9,6 @@ import { Url } from '../../core/common';
 export class OauthPageRecipe extends PageRecipe {
   private static longTimeout = 40;
 
-  /**
-   * Check if an error is a "Navigating frame was detached" error.
-   * This can happen when the OAuth page closes during navigation (e.g., successful auth).
-   * @param e - The error to check
-   * @returns true if this is a frame detached error that can be safely ignored
-   */
-  private static isFrameDetachedError(e: unknown): boolean {
-    if (!e) {
-      return false;
-    }
-    // Check if it's an Error object with a message property
-    if (e instanceof Error) {
-      return e.message.includes('Navigating frame was detached') || e.message.includes('frame was detached');
-    }
-    // Check if it's already a string
-    if (typeof e === 'string') {
-      return e.includes('Navigating frame was detached') || e.includes('frame was detached');
-    }
-    // For other types, we can't reliably check - return false to be safe
-    return false;
-  }
-
-  /**
-   * Safely navigate to a URL, ignoring "frame was detached" errors.
-   * The OAuth page may close during navigation on successful auth.
-   * @param oauthPage - The OAuth page to navigate
-   * @param url - The URL to navigate to
-   */
-  private static async safeGoto(oauthPage: ControllablePage, url: string): Promise<void> {
-    try {
-      await oauthPage.target.goto(url);
-    } catch (e: unknown) {
-      if (!OauthPageRecipe.isFrameDetachedError(e)) {
-        throw e;
-      }
-      // Ignore frame detached errors - page closed successfully
-    }
-  }
-
   public static mock = async (
     t: AvaContext,
     oauthPage: ControllablePage,
@@ -204,4 +165,43 @@ export class OauthPageRecipe extends PageRecipe {
       return await OauthPageRecipe.google(t, oauthPage, acctEmail, action); // retry, it should pick up where it left off
     }
   };
+
+  /**
+   * Check if an error is a "Navigating frame was detached" error.
+   * This can happen when the OAuth page closes during navigation (e.g., successful auth).
+   * @param e - The error to check
+   * @returns true if this is a frame detached error that can be safely ignored
+   */
+  private static isFrameDetachedError(e: unknown): boolean {
+    if (!e) {
+      return false;
+    }
+    // Check if it's an Error object with a message property
+    if (e instanceof Error) {
+      return e.message.includes('Navigating frame was detached') || e.message.includes('frame was detached');
+    }
+    // Check if it's already a string
+    if (typeof e === 'string') {
+      return e.includes('Navigating frame was detached') || e.includes('frame was detached');
+    }
+    // For other types, we can't reliably check - return false to be safe
+    return false;
+  }
+
+  /**
+   * Safely navigate to a URL, ignoring "frame was detached" errors.
+   * The OAuth page may close during navigation on successful auth.
+   * @param oauthPage - The OAuth page to navigate
+   * @param url - The URL to navigate to
+   */
+  private static async safeGoto(oauthPage: ControllablePage, url: string): Promise<void> {
+    try {
+      await oauthPage.target.goto(url);
+    } catch (e: unknown) {
+      if (!OauthPageRecipe.isFrameDetachedError(e)) {
+        throw e;
+      }
+      // Ignore frame detached errors - page closed successfully
+    }
+  }
 }