fix: reviews

Author: ioanatflowcrypt

extension/chrome/elements/compose-modules/compose-recipients-module.ts

@@ -313,7 +313,7 @@ export class ComposeRecipientsModule extends ViewModule<ComposeView> {
         }, 0);
       })();
     }
-    await Promise.all(recipientEls.map(r => r.evaluating).filter((p): p is Promise<void> => p !== undefined));
+    await Promise.all(recipientEls.map(r => r.evaluating).filter(p => p !== undefined));
     if (triggerCallback) {
       for (const callback of this.onRecipientAddedCallbacks) {
         callback(recipientEls);
@@ -405,7 +405,7 @@ export class ComposeRecipientsModule extends ViewModule<ComposeView> {
     if (this.view.S.cached('input_addresses_container_outer').hasClass('invisible')) {
       return;
     }
-    await Promise.all(this.addedRecipients.map(r => r.evaluating).filter((p): p is Promise<void> => p !== undefined)); // Wait until all recipients loaded.
+    await Promise.all(this.addedRecipients.map(r => r.evaluating).filter(p => p !== undefined)); // Wait until all recipients loaded.
     this.showHideCcAndBccInputsIfNeeded();
     this.view.S.cached('input_addresses_container_outer').addClass('invisible');
     this.view.S.cached('recipients_placeholder').css('display', 'flex');

extension/chrome/elements/compose-modules/compose-render-module.ts

@@ -478,9 +478,8 @@ export class ComposeRenderModule extends ViewModule<ComposeView> {
   private loadRecipientsThenSetTestStateReady = async () => {
     const evaluatingPromises = this.view.recipientsModule
       .getRecipients()
-      .filter(r => r.evaluating)
       .map(r => r.evaluating)
-      .filter((p): p is Promise<void> => p !== undefined);
+      .filter(r => !!r);
     await Promise.all(evaluatingPromises);
     document.querySelector('body')?.setAttribute('data-test-state', 'ready'); // set as ready so that automated tests can evaluate results
   };

test/source/browser/browser-handle.ts

@@ -119,7 +119,7 @@ export class BrowserHandle {
     let html = '';
     for (let i = 0; i < this.pages.length; i++) {
       const cPage = this.pages[i];
-      const url = await Promise.race([Promise.resolve(cPage.page.url()), new Promise<string>(resolve => setTimeout(() => resolve('(url get timeout)'), 10 * 1000))]);
+      const url = cPage.page.url();
       const consoleMsgs = await cPage.console(t, alsoLogToConsole);
       const alerts = cPage.alerts
         .map(a => `${a.active ? `<b class="c-error">ACTIVE ${a.target.type()}</b>` : a.target.type()}: ${a.target.message()}`)