"secure reply" buttons not inserted in existing threads

[sosnovsky]

Looks like Gmail updated code of their webpage with new selectors, and FlowCrypt buttons are not inserted anymore in message actions modal and to the bottom menu:

[sosnovsky]

@ioanatflowcrypt please check this one, it's high priority as it breaks secure reply functionality for FlowCrypt extension, so we should prepare a new build with this fix. Thanks!

[sosnovsky]

Also switch to encrypted reply doesn't work too:

[sosnovsky]

created PR for this issue to perform live tests - #6112
haven't found a fix for it yet - seems like Gmail page structure was changed causing parsing issues.

[martgil]

Affected users:

https://mail.google.com/mail/u/human@flowcrypt.com/#inbox/FMfcgzQcqlBLwLspwKpJHSKfdDPZsRhN
https://mail.google.com/mail/u/human@flowcrypt.com/#search/%22Encrypted+Inbox%22/FMfcgzQcpnPWXDWbwFKmcQSWwFqtDDnC
https://mail.google.com/mail/u/human@flowcrypt.com/#inbox/FMfcgzQcqlCTxhqZWMWbZRtVRJrXcDfr
https://mail.google.com/mail/u/human@flowcrypt.com/#archive/FMfcgzQcqkzDqRqdnJDdLszBVNpFwTlV

[ioanatflowcrypt]

@ioanatflowcrypt please check this one, it's high priority as it breaks secure reply functionality for FlowCrypt extension, so we should prepare a new build with this fix. Thanks!

Okay, got it

[sosnovsky]

@ioanatflowcrypt I started working on it at #6112 by fixing tests, as some element selectors were changed too. Feel free to continue working there

[ioanatflowcrypt]

Maybe better to publish hotfix for this issue and then let me continue with tests.

[sosnovsky]

For sure, fixing original issue with non-inserted secure reply button is higher priority, but tests are also helpful in identifying which functionality is broken and which just needs selector update.
So probably you can just fork https://github.com/FlowCrypt/flowcrypt-browser/tree/6111-fix-secure-reply-live-test branch and work on fix there, while I'll continue checking tests in the current branch. What do you think?

[ioanatflowcrypt]

Sounds great