-
Notifications
You must be signed in to change notification settings - Fork 51
#6111 Fix secure reply buttons #6112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # package-lock.json
…t/flowcrypt-browser into 6111-fix-secure-reply-live-test
|
@sosnovsky Fixed all issues(secure reply buttons view not replaced issue, secure buttons not inserted at top convo buttons issue, secure buttons not inserted at message menu issue) |
|
Well done, @ioanatflowcrypt! Please work on remaining tests fixes - some of them should probably already pass as you've fixed broken functionality. |
|
@ioanatflowcrypt font of secure options is different from plain Gmail actions, probably need to change css class for them:
|
…t/flowcrypt-browser into 6111-fix-secure-reply-live-test
…FlowCrypt/flowcrypt-browser into 6111-fix-secure-reply-live-test
|
@ioanatflowcrypt secure reply buttons look great now, just need to increase it's height to be the same as plain reply buttons: |
|
@sosnovsky Fixed all issues. Please check |
|
@ioanatflowcrypt works perfectly now, great job, thanks! |
|
Merged |



This PR fixed secure reply buttons inject issue (due to gmail dom update) and fixed live tests
close #6111
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):