Skip to content

Conversation

@sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Nov 10, 2025

This PR fixed secure reply buttons inject issue (due to gmail dom update) and fixed live tests

close #6111


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanatflowcrypt
Copy link
Collaborator

ioanatflowcrypt commented Nov 11, 2025

@sosnovsky Fixed all issues(secure reply buttons view not replaced issue, secure buttons not inserted at top convo buttons issue, secure buttons not inserted at message menu issue)
Let me know if you are still working on tests or if you wanna me to continue test fix.

@sosnovsky
Copy link
Collaborator Author

Well done, @ioanatflowcrypt! Please work on remaining tests fixes - some of them should probably already pass as you've fixed broken functionality.
I'll be online in a couple hours and test your extension fixes.

@sosnovsky
Copy link
Collaborator Author

@ioanatflowcrypt font of secure options is different from plain Gmail actions, probably need to change css class for them:

Screenshot 2025-11-11 at 10 07 55

@sosnovsky
Copy link
Collaborator Author

@ioanatflowcrypt secure reply buttons look great now, just need to increase it's height to be the same as plain reply buttons:

plain reply:
Screenshot 2025-11-11 at 16 19 46

secure reply:
Screenshot 2025-11-11 at 16 19 38

@ioanatflowcrypt
Copy link
Collaborator

@sosnovsky Fixed all issues. Please check

@ioanatflowcrypt ioanatflowcrypt marked this pull request as ready for review November 12, 2025 00:54
@sosnovsky
Copy link
Collaborator Author

@ioanatflowcrypt works perfectly now, great job, thanks!
But I can't approve it, as I'm PR author :) Set you as a reviewer, please approve it.

@sosnovsky sosnovsky enabled auto-merge (squash) November 12, 2025 13:23
@sosnovsky sosnovsky merged commit 5a6b382 into master Nov 12, 2025
12 checks passed
@sosnovsky sosnovsky deleted the 6111-fix-secure-reply-live-test branch November 12, 2025 13:30
@ioanatflowcrypt
Copy link
Collaborator

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"secure reply" buttons not inserted in existing threads

3 participants