Added API to MCOIMAPSession to enable the malformed address hack in the underlying libetpan struct.

Author: MythicLionMan

src/async/imap/MCIMAPAsyncConnection.cpp

@@ -221,6 +221,16 @@ bool IMAPAsyncConnection::isCheckCertificateEnabled()
     return mSession->isCheckCertificateEnabled();
 }
 
+void IMAPAsyncConnection::setEnableMalformedAddressHack(bool enabled)
+{
+    mSession->setEnableMalformedAddressHack(enabled);
+}
+
+bool IMAPAsyncConnection::enableMalformedAddressHack()
+{
+    return mSession->enableMalformedAddressHack();
+}
+
 void IMAPAsyncConnection::setVoIPEnabled(bool enabled)
 {
     mSession->setVoIPEnabled(enabled);

src/async/imap/MCIMAPAsyncConnection.h

@@ -66,6 +66,9 @@ namespace mailcore {
 
         virtual void setCheckCertificateEnabled(bool enabled);
         virtual bool isCheckCertificateEnabled();
+
+        virtual void setEnableMalformedAddressHack(bool enabled);
+        virtual bool enableMalformedAddressHack();
 
         virtual void setVoIPEnabled(bool enabled);
         virtual bool isVoIPEnabled();

src/async/imap/MCIMAPAsyncSession.cpp

@@ -192,6 +192,20 @@ bool IMAPAsyncSession::isCheckCertificateEnabled()
     return mCheckCertificateEnabled;
 }
 
+void IMAPAsyncSession::setEnableMalformedAddressHack(bool enabled)
+{
+    mEnableMalformedAddressHack = enabled;
+    for(unsigned int i = 0 ; i < mSessions->count() ; i ++) {
+        IMAPAsyncConnection * connection = (IMAPAsyncConnection *) mSessions->objectAtIndex(i);
+        connection->setEnableMalformedAddressHack(enabled);
+    }
+}
+
+bool IMAPAsyncSession::enableMalformedAddressHack()
+{
+    return mEnableMalformedAddressHack;
+}
+
 void IMAPAsyncSession::setVoIPEnabled(bool enabled)
 {
     mVoIPEnabled = enabled;
@@ -352,6 +366,7 @@ IMAPAsyncConnection * IMAPAsyncSession::availableSession()
     if ((mMaximumConnections == 0) || (mSessions->count() < mMaximumConnections)) {
         chosenSession = session();
         mSessions->addObject(chosenSession);
+        chosenSession->setEnableMalformedAddressHack(mEnableMalformedAddressHack);
         return chosenSession;
     }
 

src/async/imap/MCIMAPAsyncSession.h

@@ -78,6 +78,9 @@ namespace mailcore {
 
         virtual void setCheckCertificateEnabled(bool enabled);
         virtual bool isCheckCertificateEnabled();
+
+        virtual void setEnableMalformedAddressHack(bool enabled);
+        virtual bool enableMalformedAddressHack();
 
         virtual void setVoIPEnabled(bool enabled);
         virtual bool isVoIPEnabled();
@@ -207,6 +210,7 @@ namespace mailcore {
         ConnectionType mConnectionType;
         bool mCheckCertificateEnabled;
         bool mVoIPEnabled;
+        bool mEnableMalformedAddressHack;
         IMAPNamespace * mDefaultNamespace;
         time_t mTimeout;
         bool mAllowsFolderConcurrentAccessEnabled;

src/core/imap/MCIMAPSession.cpp

@@ -529,6 +529,19 @@ bool IMAPSession::isCheckCertificateEnabled()
     return mCheckCertificateEnabled;
 }
 
+void IMAPSession::setEnableMalformedAddressHack(bool enabled)
+{
+    malformedAddressWorkaroundEnabled = enabled;
+#ifdef LIBETPAN_HAS_MALFORMED_ADDRESS_HACK
+    mailimap_set_malformed_address_workaround_enabled(mImap, enabled);
+#endif
+}
+
+bool IMAPSession::enableMalformedAddressHack()
+{
+    return malformedAddressWorkaroundEnabled;
+}
+
 void IMAPSession::setVoIPEnabled(bool enabled)
 {
     mVoIPEnabled = enabled;
@@ -616,6 +629,9 @@ void IMAPSession::setup()
     mailimap_set_timeout(mImap, timeout());
     mailimap_set_progress_callback(mImap, body_progress, IMAPSession::items_progress, this);
     mailimap_set_logger(mImap, logger, this);
+#ifdef LIBETPAN_HAS_MALFORMED_ADDRESS_HACK
+    mailimap_set_malformed_address_workaround_enabled(mImap, malformedAddressWorkaroundEnabled);
+#endif
 }
 
 void IMAPSession::unsetup()

src/core/imap/MCIMAPSession.h

@@ -55,6 +55,9 @@ namespace mailcore {
 
         virtual void setCheckCertificateEnabled(bool enabled);
         virtual bool isCheckCertificateEnabled();
+
+        virtual void setEnableMalformedAddressHack(bool enabled);
+        virtual bool enableMalformedAddressHack();
 
         virtual void setVoIPEnabled(bool enabled);
         virtual bool isVoIPEnabled();
@@ -276,6 +279,7 @@ namespace mailcore {
         bool mRamblerRuServer;
         bool mHermesServer;
         bool mQipServer;
+        bool malformedAddressWorkaroundEnabled;
 
         unsigned int mLastFetchedSequenceNumber;
         String * mCurrentFolder;

src/objc/imap/MCOIMAPSession.h

@@ -105,6 +105,9 @@
 /** Does the server support QRESYNC */
 @property (nonatomic, assign, readonly) BOOL isQResyncEnabled;
 
+/** Enables or disables the malformed address hack for this session */
+@property (nonatomic, assign) BOOL enableMalformedAddressHack;
+
 /**
  Display name of the Gmail user. It will be nil if it's not a Gmail server.
 

src/objc/imap/MCOIMAPSession.mm

@@ -119,6 +119,16 @@ - (MCOIMAPNamespace *) defaultNamespace
     return MCO_TO_OBJC(_session->defaultNamespace());
 }
 
+- (void) setEnableMalformedAddressHack:(BOOL)enabled
+{
+    _session->setEnableMalformedAddressHack(enabled);
+}
+
+- (BOOL)enableMalformedAddressHack
+{
+    return _session->enableMalformedAddressHack();
+}
+
 - (MCOIMAPIdentity *) clientIdentity
 {
     return MCO_OBJC_BRIDGE_GET(clientIdentity);