Skip to content

Commit 50d902a

Browse files
authored
Merge pull request #297 from FlowFuse/fix-tests-070
Fix tests after we no longer use node._msg
2 parents 37429c9 + d0027fc commit 50d902a

File tree

6 files changed

+14
-8
lines changed

6 files changed

+14
-8
lines changed

nodes/config/ui_base.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -568,6 +568,14 @@ module.exports = function (RED) {
568568
node.ui.widgets.set(widget.id, widget)
569569
}
570570

571+
/**
572+
* Helper Function for testing
573+
*/
574+
575+
widgetNode.getState = function () {
576+
return datastore.get(widgetNode.id)
577+
}
578+
571579
/**
572580
* Event Handlers
573581
*/

test/nodes/widgets/ui_button.spec.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ describe('ui-button node', function () {
106106

107107
// add a fake connection so that button has somewhere to emit to and we can spy on it
108108
base.uiShared.connections['fake-conn-id'] = socket
109-
base.connections['fake-conn-id'] = socket
110109

111110
// now send a message to the node
112111
const button = helper.getNode('node-ui-button')

test/nodes/widgets/ui_dropdown.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ describe('ui-dropdown node', function () {
131131
const helperAfterComplete = helper.getNode('helper-node-complete')
132132
helperAfterComplete.on('input', (msg) => {
133133
try {
134-
dNode._msg.payload.should.equal(msg.payload)
134+
dNode.getState().payload.should.equal(msg.payload)
135135
msgSent.should.be.false()
136136
resolve()
137137
} catch (err) {

test/nodes/widgets/ui_slider.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ describe('ui-slider node', function () {
121121
const helperAfterComplete = helper.getNode('helper-node-complete')
122122
helperAfterComplete.on('input', (msg) => {
123123
try {
124-
sNode._msg.payload.should.equal(msg.payload)
124+
sNode.getState().payload.should.equal(msg.payload)
125125
msgSent.should.be.false()
126126
resolve()
127127
} catch (err) {

test/nodes/widgets/ui_switch.spec.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ describe('ui-switch node', function () {
117117
const hNode = helper.getNode('helper-node')
118118
hNode.on('input', (msg) => {
119119
try {
120-
sNode._msg.payload.should.equal(msg.payload)
120+
sNode.getState().payload.should.equal(msg.payload)
121121
resolve()
122122
} catch (err) {
123123
reject(err)
@@ -141,7 +141,7 @@ describe('ui-switch node', function () {
141141
// we need to be sure that the helperAfterSwitch node has run first
142142
setTimeout(() => {
143143
try {
144-
sNode._msg.payload.should.equal(msg.payload)
144+
sNode.getState().payload.should.equal(msg.payload)
145145
msgSent.should.be.true()
146146
resolve()
147147
} catch (err) {
@@ -173,7 +173,6 @@ describe('ui-switch node', function () {
173173
// we need to be sure that the helperAfterSwitch node has run first
174174
setTimeout(() => {
175175
try {
176-
(sNode._msg === undefined).should.be.true()
177176
sNode.warn.should.be.called()
178177
msgSent.should.be.false()
179178
resolve()
@@ -211,7 +210,7 @@ describe('ui-switch node', function () {
211210
const helperAfterComplete = helper.getNode('helper-node-complete')
212211
helperAfterComplete.on('input', (msg) => {
213212
try {
214-
sNode._msg.payload.should.equal(msg.payload)
213+
sNode.getState().payload.should.equal(msg.payload)
215214
msgSent.should.be.false()
216215
resolve()
217216
} catch (err) {

test/nodes/widgets/ui_text_input.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ describe('ui-text-input node', function () {
114114
const helperAfterComplete = helper.getNode('helper-node-complete')
115115
helperAfterComplete.on('input', (msg) => {
116116
try {
117-
tNode._msg.payload.should.equal(msg.payload)
117+
tNode.getState().payload.should.equal(msg.payload)
118118
msgSent.should.be.false()
119119
resolve()
120120
} catch (err) {

0 commit comments

Comments
 (0)