Skip to content

Commit 7886ce6

Browse files
committed
Inheritence corrections for ESPressio Base
1 parent 23905ed commit 7886ce6

File tree

2 files changed

+0
-15
lines changed

2 files changed

+0
-15
lines changed

src/ESPressio_IThread.hpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,6 @@ namespace ESPressio {
9292
/// `GetOnTerminated` returns the callback to be invoked when the Thread is terminated.
9393
virtual std::function<void(IThread*)> GetOnTerminate() = 0;
9494

95-
/// `GetOnDestroying` returns the callback to be invoked when the Thread is being destroyed.
96-
virtual std::function<void(IThread*)> GetOnDestroy() = 0;
97-
9895
/// `GetOnStateChange` returns the callback to be invoked when the Thread's state changes.
9996
virtual std::function<void(IThread*, ThreadState, ThreadState)> GetOnStateChange() = 0;
10097

@@ -130,10 +127,6 @@ namespace ESPressio {
130127
/// The callback function takes `IThread*` and ideally named `sender`.
131128
virtual void SetOnTerminate(std::function<void(IThread*)>) = 0;
132129

133-
/// `SetOnDestroying` sets the callback to be invoked when the Thread is being destroyed.
134-
/// The callback function takes `IThread*` and ideally named `sender`.
135-
virtual void SetOnDestroy(std::function<void(IThread*)>) = 0;
136-
137130
/// `SetOnStateChange` sets the callback to be invoked when the Thread's state changes.
138131
/// The callback function takes `IThread*` and ideally named `sender`, `ThreadState` for the previous state and `ThreadState` for the new state.
139132
virtual void SetOnStateChange(std::function<void(IThread*, ThreadState, ThreadState)>) = 0;

src/ESPressio_Thread.hpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,6 @@ namespace ESPressio {
190190
return _onTerminate;
191191
}
192192

193-
std::function<void(IThread*)> GetOnDestroy() {
194-
return _onDestroy;
195-
}
196-
197193
std::function<void(IThread*, ThreadState, ThreadState)> GetOnStateChange() {
198194
return _onStateChange;
199195
}
@@ -238,10 +234,6 @@ namespace ESPressio {
238234
_onTerminate = value;
239235
}
240236

241-
void SetOnDestroy(std::function<void(IThread*)> value) {
242-
_onDestroy = value;
243-
}
244-
245237
void SetOnStateChange(std::function<void(IThread*, ThreadState, ThreadState)> value) {
246238
_onStateChange = value;
247239
}

0 commit comments

Comments
 (0)