Skip to content

Commit 10fb6c3

Browse files
ngonzalezpazFCjavier-godoy
authored andcommitted
feat: add setIconBlank() method
Deprecate setIconSpacing(boolean) method that does not use its parameter. Update demo. Close #61
1 parent f334bda commit 10fb6c3

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

src/main/java/com/flowingcode/addons/applayout/MenuItem.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
@Tag("fc-menuitem")
4747
public class MenuItem extends SlottedMenuItem implements HasOrderedComponents<MenuItem>, HasMenuItemCommands<MenuItem>, HasMenuItemIcon<MenuItem> {
4848

49+
static final String BLANK = "fc-menuitem-icons:empty";
50+
4951
/** No argument constructor */
5052
public MenuItem() {}
5153

@@ -134,9 +136,16 @@ public MenuItem configure(Consumer<MenuItem> consumer) {
134136
return this;
135137
}
136138

139+
/**
140+
* @deprecated This method ignores the parameter. Use {@link #setIconBlank()}.
141+
*/
142+
@Deprecated
137143
public void setIconSpacing(boolean value) {
138-
setIcon("fc-menuitem-icons:empty");
144+
setIcon(MenuItem.BLANK);
139145
}
140146

147+
public void setIconBlank() {
148+
setIcon(MenuItem.BLANK);
149+
}
141150
}
142151

src/test/java/com/flowingcode/addons/applayout/ApplayoutDemoView.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,14 +172,14 @@ private Component[] createMenuItems() {
172172

173173
new MenuItem("No icon"),
174174

175-
new MenuItem("No icon, spaced").configure(mi -> mi.setIconSpacing(true)),
175+
new MenuItem("No icon, spaced").configure(mi -> mi.setIconBlank()),
176176

177177
// menu item with custom content
178178
new MenuItem("Toggle").configure(mi -> mi.add(new PaperToggle())),
179179

180180
new MenuItem("Toggle", VaadinIcon.BACKSPACE).configure(mi -> mi.add(new PaperToggle())),
181181

182-
new MenuItem("Toggle", "fc-menuitem-icons:empty").configure(mi -> mi.add(new PaperToggle())),
182+
new MenuItem("Toggle", MenuItem.BLANK).configure(mi -> mi.add(new PaperToggle())),
183183

184184
new MenuItem("External link").setHref("http://www.google.com"),
185185

0 commit comments

Comments
 (0)