Skip to content

Commit 1b3b874

Browse files
committed
Code cleanup
1 parent 4227179 commit 1b3b874

File tree

8 files changed

+9
-15
lines changed

8 files changed

+9
-15
lines changed

src/main/java/com/flowingcode/addons/applayout/AppDrawer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323

2424
import java.util.ArrayList;
25-
import java.util.Arrays;
25+
import java.util.Collections;
2626
import java.util.List;
2727

2828
import com.flowingcode.addons.applayout.menu.MenuItem;
@@ -43,7 +43,7 @@
4343
@HtmlImport("bower_components/app-layout/app-drawer/app-drawer.html")
4444
public class AppDrawer extends Component implements HasComponents {
4545

46-
private PaperListbox pm = new PaperListbox(Arrays.asList(new Component[] {}));
46+
private PaperListbox pm = new PaperListbox(Collections.emptyList());
4747
private Component header;
4848

4949
public AppDrawer(String title) {

src/main/java/com/flowingcode/addons/applayout/AppToolbar.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ public void setToolbarIconButtons(MenuItem[] menuItems) {
7575
this.add(menu);
7676
if (ctitle!=null) this.add(ctitle);
7777
if (divTitle!=null) this.add(divTitle);
78-
toolbarIconButtons.forEach(tib->this.add(tib));
78+
toolbarIconButtons.forEach(this::add);
7979
}
8080

81-
private List<PaperIconButton> createToolbarIconButtons(MenuItem[] menuItems) {
81+
private static List<PaperIconButton> createToolbarIconButtons(MenuItem[] menuItems) {
8282
List<PaperIconButton> result = new ArrayList<>();
8383
for (MenuItem menuItem : menuItems) {
8484
PaperIconButton paperIconButton = new PaperIconButton(menuItem.getIcon(),menuItem.getCommand());

src/main/java/com/flowingcode/addons/applayout/PaperButton.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,7 @@ public PaperButton(String label) {
4343

4444
public PaperButton(String label, Command command) {
4545
this.setLabel(label);
46-
this.getElement().addEventListener("click", e->{
47-
command.execute();
48-
});
46+
this.getElement().addEventListener("click", e->command.execute());
4947
}
5048

5149
public void setLabel(String label) {

src/main/java/com/flowingcode/addons/applayout/PaperCard.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public void setCardActions(final MenuItem... cardActions) {
8787
final Div inner = new Div();
8888
cardActionsDiv.add(inner);
8989
inner.addClassNames("horizontal", "justified");
90-
buttons.forEach(b -> inner.add(b));
90+
buttons.forEach(inner::add);
9191
hasComponentsVersion.add(cardActionsDiv);
9292
}
9393
}

src/main/java/com/flowingcode/addons/applayout/PaperIconButton.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@ public PaperIconButton(String icon) {
4444

4545
public PaperIconButton(String icon, Command command) {
4646
this.setIcon(icon);
47-
this.getElement().addEventListener("click", e->{
48-
command.execute();
49-
});
47+
this.getElement().addEventListener("click", e->command.execute());
5048
}
5149

5250
public void setIcon(String icon) {

src/main/java/com/flowingcode/addons/applayout/PaperIconItem.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,12 @@
2020
package com.flowingcode.addons.applayout;
2121

2222

23-
2423
import com.vaadin.flow.component.Component;
2524
import com.vaadin.flow.component.HasComponents;
2625
import com.vaadin.flow.component.HasSize;
2726
import com.vaadin.flow.component.HasText;
2827
import com.vaadin.flow.component.Tag;
2928
import com.vaadin.flow.component.Text;
30-
import com.vaadin.flow.component.UI;
3129
import com.vaadin.flow.component.dependency.HtmlImport;
3230
import com.vaadin.flow.server.Command;
3331

src/main/java/com/flowingcode/addons/applayout/PaperListbox.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
public class PaperListbox extends Component implements HasComponents {
4141

4242
public PaperListbox(List<Component> components) {
43-
components.stream().forEach(c->this.add(c));
43+
components.stream().forEach(this::add);
4444
}
4545

4646
public PaperListbox(String label, PaperItem...items) {

src/main/java/com/flowingcode/addons/applayout/menu/MenuItem.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public void setSubMenuItems(List<MenuItem> subMenuItems) {
115115
* @return true if this item has sub menu items
116116
*/
117117
public boolean isSubMenuFolder() {
118-
return getSubMenuItems().size() > 0;
118+
return !getSubMenuItems().isEmpty();
119119
}
120120

121121
/**

0 commit comments

Comments
 (0)