Skip to content

Commit 7d8b027

Browse files
mlopezFCpaodb
authored andcommitted
fix: correct height handling
1 parent 5f9cfab commit 7d8b027

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

src/main/java/com/flowingcode/vaadin/addons/carousel/Carousel.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ public Carousel withStartPosition(int startPosition) {
152152
// SIZING
153153
@Override
154154
public void setHeight(String height) {
155+
HasSize.super.setHeight(height);
155156
getElement().getStyle().set("--paper-slide-height", height);
156157
}
157158

src/test/java/com/flowingcode/vaadin/addons/carousel/AutoProgressDemo.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ public AutoProgressDemo() {
4444
.withSlideDuration(2)
4545
.withStartPosition(1)
4646
.withoutSwipe();
47-
c.setWidth("100%");
48-
c.setHeight("180px");
47+
c.setSizeFull();
4948

5049
add(c);
5150
}

src/test/java/com/flowingcode/vaadin/addons/carousel/ListenerDemo.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ public ListenerDemo() {
4141
Slide s4 = new Slide(createSlideContent("Slide 4", "yellow"));
4242

4343
Carousel c = new Carousel(s1, s2, s3, s4);
44-
c.setWidth("100%");
45-
c.setHeight("180px");
44+
c.setSizeFull();
4645
c.addChangeListener(e -> Notification.show("Slide Changed!", 1000, Position.BOTTOM_START));
4746

4847
add(c);

src/test/java/com/flowingcode/vaadin/addons/carousel/SlideButtonsDemo.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ public SlideButtonsDemo() {
4343
Slide s4 = new Slide(createSlideContent("Slide 4", "yellow"));
4444

4545
final Carousel cf = new Carousel(s1, s2, s3, s4).withoutNavigation();
46-
cf.setWidth("100%");
47-
cf.setHeight("180px");
46+
cf.setSizeFull();
4847
Button next = new Button(">>");
4948
Button prev = new Button("<<");
5049
Button last = new Button(">|");

0 commit comments

Comments
 (0)