Skip to content

Commit d89bceb

Browse files
javier-godoypaodb
authored andcommitted
fix: correct aria-posinset values
Close #45
1 parent f105525 commit d89bceb

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/main/resources/META-INF/resources/frontend/paper-slider/l2t-paper-slider.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ Polymer$0({
180180
<div role="menubar" hidden\$="[[hideNav]]" class="slider__dots">
181181
<span class="slider__indicator"></span>
182182
<template is="dom-repeat" items="[[_totalDots]]">
183-
<span tabindex="0" role="menuitemradio" aria-checked="false" class="slider__dot" aria-posinset\$="[[item]]"></span>
183+
<span tabindex="0" role="menuitemradio" aria-checked="false" class="slider__dot" aria-posinset\$="[[_increment(item)]]"></span>
184184
</template>
185185
</div>
186186
</div>
@@ -461,7 +461,7 @@ Polymer$0({
461461
var sliderElem = this.$.container,
462462
indicatorElem = sliderElem.querySelector('.slider__indicator'),
463463
currentPos = parseInt(sliderElem.getAttribute('data-pos')),
464-
newPos = parseInt(dotElem.getAttribute('aria-posinset')),
464+
newPos = parseInt(dotElem.getAttribute('aria-posinset')) - 1,
465465
newDirection = newPos > currentPos ? 'right' : 'left',
466466
currentDirection = newPos < currentPos ? 'right' : 'left';
467467
indicatorElem.classList.remove('slider__indicator--' + currentDirection);
@@ -479,9 +479,9 @@ Polymer$0({
479479
var this$ = this;
480480
var dotElems = this.$.container.querySelectorAll('.slider__dot'), i;
481481
for (i = 0; i < this.totalSlides; ++i) {
482-
dotElems[i].setAttribute("aria-label", "Slide " + (parseInt(dotElems[i].getAttribute('aria-posinset')) + 1) + " selector");
482+
dotElems[i].setAttribute("aria-label", "Slide " + parseInt(dotElems[i].getAttribute('aria-posinset')) + " selector");
483483
dotElems[i].addEventListener('click', function (e) {
484-
this$.movePos(e.target.getAttribute('aria-posinset'));
484+
this$.movePos(e.target.getAttribute('aria-posinset') - 1);
485485
});
486486
};
487487
if (this.totalSlides) {
@@ -547,7 +547,7 @@ Polymer$0({
547547
}
548548
if (!nextPos)
549549
return;
550-
this.movePos(nextPos);
550+
this.movePos(parseInt(nextPos) - 1);
551551
},
552552

553553
/**
@@ -659,4 +659,8 @@ Polymer$0({
659659
removeListener(this.$.container, 'track', e => this._swipeHandler(e));
660660
},
661661

662+
_increment: function(n) {
663+
return n+1;
664+
}
665+
662666
});

0 commit comments

Comments
 (0)