fix: fire created/removed events when the value changes

Fix that the events are not fired when the value is modified from server side, and the item is not available from the removed listener when the removal originates from the client.

Close #48
Close #49

Author: javier-godoy

src/main/java/com/flowingcode/vaadin/addons/chipfield/ChipField.java

@@ -76,10 +76,14 @@ public abstract static class ChipEvent<T> extends ComponentEvent<ChipField<T>> {
     private final String chipLabel;
     private final T item;
 
-    public ChipEvent(ChipField<T> source, boolean fromClient, String chipLabel) {
+    private ChipEvent(ChipField<T> source, boolean fromClient, T item, String chipLabel) {
       super(source, fromClient);
       this.chipLabel = chipLabel;
-      this.item = source.findItemByLabel(chipLabel).orElse(null);
+      this.item = item;
+    }
+
+    public ChipEvent(ChipField<T> source, boolean fromClient, String chipLabel) {
+      this(source, fromClient, source.findItemByLabel(chipLabel).orElse(null), chipLabel);
     }
 
     public String getChipLabel() {
@@ -91,19 +95,16 @@ public T getItem() {
     }
   }
 
-  @DomEvent("chip-removed")
   public static class ChipRemovedEvent<T> extends ChipEvent<T> {
-    public ChipRemovedEvent(
-        ChipField<T> source, boolean fromClient, @EventData(CHIP_LABEL) String chipLabel) {
-      super(source, fromClient, chipLabel);
+    public ChipRemovedEvent(ChipField<T> source, boolean fromClient, T item) {
+      super(source, fromClient, item, source.itemLabelGenerator.apply(item));
     }
   }
 
-  @DomEvent("chip-created")
   public static class ChipCreatedEvent<T> extends ChipEvent<T> {
     public ChipCreatedEvent(
-        ChipField<T> source, boolean fromClient, @EventData(CHIP_LABEL) String chipLabel) {
-      super(source, fromClient, chipLabel);
+        ChipField<T> source, boolean fromClient, T item) {
+      super(source, fromClient, item, source.itemLabelGenerator.apply(item));
     }
   }
 
@@ -121,6 +122,20 @@ public ChipField(String label, ItemLabelGenerator<T> itemLabelGenerator, T... av
     setChipLabelGenerator(itemLabelGenerator);
     setLabel(label);
     this.availableItems = DataProvider.ofCollection(Arrays.asList(availableItems));
+
+    addValueChangeListener(ev -> {
+      for (T t : ev.getOldValue()) {
+        if (!ev.getValue().contains(t)) {
+          fireEvent(new ChipRemovedEvent<>(this, ev.isFromClient(), t));
+        }
+      }
+
+      for (T t : ev.getValue()) {
+        if (!ev.getOldValue().contains(t)) {
+          fireEvent(new ChipCreatedEvent<>(this, ev.isFromClient(), t));
+        }
+      }
+    });
   }
 
   @SafeVarargs
@@ -396,7 +411,6 @@ private void addSelectedItemInternal(T newItem, boolean fromClient) {
       setModelValue(value, fromClient);
       if (!fromClient) {
         setPresentationValue(value);
-        fireEvent(new ChipCreatedEvent<>(this, fromClient, itemLabelGenerator.apply(newItem)));
       }
     }
   }
@@ -412,7 +426,7 @@ private void removeSelectedItem(T itemToRemove, boolean fromClient) {
       setModelValue(value, fromClient);
       if (!fromClient) {
         setPresentationValue(value);
-        fireEvent(new ChipRemovedEvent<>(this, fromClient, itemLabelGenerator.apply(itemToRemove)));
+
       }
     }
   }
@@ -421,4 +435,5 @@ private void removeSelectedItem(T itemToRemove, boolean fromClient) {
   public Registration addChipClickedListener(ComponentEventListener<ChipClickedEvent<T>> listener) {
     return addListener(ChipClickedEvent.class, (ComponentEventListener) listener);
   }
+
 }