Skip to content

Commit 0415487

Browse files
paodbjavier-godoy
authored andcommitted
refactor: remove label of input in cron expression field
Close #11
1 parent edffff1 commit 0415487

File tree

2 files changed

+0
-23
lines changed

2 files changed

+0
-23
lines changed

src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionField.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@ private boolean validateCron(String cron) {
156156
}
157157

158158
private void configureLayout() {
159-
inputExpressionTf.setLabel(i18n.getCronExpressionLabel());
160159
inputExpressionTf.setValue(defaultExpression == null ? "" : defaultExpression);
161160
Button clearInputBtn = new Button(i18n.getClearBtn(), e -> {
162161
inputExpressionTf.setValue(defaultExpression == null ? "" : defaultExpression);

src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionFieldI18n.java

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
*/
3333
public class CronExpressionFieldI18n implements Serializable {
3434
private Map<LayoutOptions, String> layoutOptions;
35-
private String cronExpressionLabel;
3635
private String clearBtn;
3736
private String startsAtLabel;
3837
private Map<CronExpressionField.Units, String> units;
@@ -56,7 +55,6 @@ public class CronExpressionFieldI18n implements Serializable {
5655
private CronExpressionFieldI18n() {
5756
this.layoutOptions =
5857
Map.of(LayoutOptions.DAILY, "Daily", LayoutOptions.MONTHLY, "Monthly", LayoutOptions.ADVANCED, "Advanced");
59-
this.cronExpressionLabel = "Cron expression";
6058
this.clearBtn = "Clear";
6159
this.startsAtLabel = "Starts at";
6260
this.units = Map.of(CronExpressionField.Units.SECONDS, "Seconds", CronExpressionField.Units.MINUTES, "Minutes",
@@ -86,26 +84,6 @@ public static CronExpressionFieldI18n createDefault() {
8684
return new CronExpressionFieldI18n();
8785
}
8886

89-
/**
90-
* Gets the label for the cron expression input.
91-
*
92-
* @return the cron expression label
93-
*/
94-
public String getCronExpressionLabel() {
95-
return cronExpressionLabel;
96-
}
97-
98-
/**
99-
* Sets the label for the cron expression input.
100-
*
101-
* @param cronExpressionLabel the label to set
102-
* @return this instance for method chaining
103-
*/
104-
public CronExpressionFieldI18n setCronExpressionLabel(String cronExpressionLabel) {
105-
this.cronExpressionLabel = cronExpressionLabel;
106-
return this;
107-
}
108-
10987
/**
11088
* Gets the label for the clear button.
11189
*

0 commit comments

Comments
 (0)