Scrolling "show next dates" makes the demo unresponsive

[paodb]

Describe the bug

While testing #20, once I get the grid showing the list of dates visible, I tried to scroll the grid and the demo became unresponsive.

Expected behavior

Scrolling the data won't break the application.

Minimal reproducible example

This also can be tested on the old version running in staging https://addonsv24-staging.flowingcode.com/cron-exp-editor/next-dates-visible where the grid is visible.

Add-on Version

1.0.0-SNAPSHOT

Vaadin Version

24

Additional information

Not additional information.

[javier-godoy]

From staging logs:

java.lang.RuntimeException: java.lang.IllegalArgumentException: start must not be greater than end
at com.vaadin.flow.server.communication.rpc.PublishedServerEventHandlerRpcHandler.invokeMethod(PublishedServerEventHandlerRpcHandler.java:234) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.communication.rpc.PublishedServerEventHandlerRpcHandler.invokeMethod(PublishedServerEventHandlerRpcHandler.java:204) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.communication.rpc.PublishedServerEventHandlerRpcHandler.invokeMethod(PublishedServerEventHandlerRpcHandler.java:150) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.communication.rpc.PublishedServerEventHandlerRpcHandler.handleNode(PublishedServerEventHandlerRpcHandler.java:133) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.communication.rpc.AbstractRpcInvocationHandler.handle(AbstractRpcInvocationHandler.java:79) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.communication.ServerRpcHandler.handleInvocationData(ServerRpcHandler.java:568) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.communication.ServerRpcHandler.lambda$handleInvocations$6(ServerRpcHandler.java:549) ~[flow-server-24.9.0.jar!/:24.9.0]
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) ~[na:na]
at com.vaadin.flow.server.communication.ServerRpcHandler.handleInvocations(ServerRpcHandler.java:549) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.communication.ServerRpcHandler.handleRpc(ServerRpcHandler.java:376) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.communication.UidlRequestHandler.synchronizedHandleRequest(UidlRequestHandler.java:136) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:63) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.VaadinService.handleRequest(VaadinService.java:1879) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.server.VaadinServlet.service(VaadinServlet.java:398) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.spring.SpringServlet.service(SpringServlet.java:106) ~[vaadin-spring-24.9.0.jar!/:na]
at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:658) ~[tomcat-embed-core-10.1.24.jar!/:6.0.0]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:195) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:632) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:408) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:303) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:267) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.springframework.web.servlet.mvc.ServletForwardingController.handleRequestInternal(ServletForwardingController.java:142) ~[spring-webmvc-6.1.8.jar!/:6.1.8]
at org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:178) ~[spring-webmvc-6.1.8.jar!/:6.1.8]
at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:51) ~[spring-webmvc-6.1.8.jar!/:6.1.8]
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1089) ~[spring-webmvc-6.1.8.jar!/:6.1.8]
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:979) ~[spring-webmvc-6.1.8.jar!/:6.1.8]
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1014) ~[spring-webmvc-6.1.8.jar!/:6.1.8]
at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:914) ~[spring-webmvc-6.1.8.jar!/:6.1.8]
at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:590) ~[tomcat-embed-core-10.1.24.jar!/:6.0.0]
at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:885) ~[spring-webmvc-6.1.8.jar!/:6.1.8]
at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:658) ~[tomcat-embed-core-10.1.24.jar!/:6.0.0]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:195) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51) ~[tomcat-embed-websocket-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:164) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100) ~[spring-web-6.1.8.jar!/:6.1.8]
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) ~[spring-web-6.1.8.jar!/:6.1.8]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:164) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93) ~[spring-web-6.1.8.jar!/:6.1.8]
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) ~[spring-web-6.1.8.jar!/:6.1.8]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:164) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201) ~[spring-web-6.1.8.jar!/:6.1.8]
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) ~[spring-web-6.1.8.jar!/:6.1.8]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:164) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:167) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:482) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:115) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.valves.RemoteIpValve.invoke(RemoteIpValve.java:731) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:344) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:389) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:896) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1741) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1190) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659) ~[tomcat-embed-core-10.1.24.jar!/:na]
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63) ~[tomcat-embed-core-10.1.24.jar!/:na]
at java.base/java.lang.Thread.run(Thread.java:833) ~[na:na]
Caused by: java.lang.IllegalArgumentException: start must not be greater than end
at com.vaadin.flow.internal.Range.(Range.java:151) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.internal.Range.withLength(Range.java:135) ~[flow-server-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.data.provider.DataCommunicator.computeRequestedRange(DataCommunicator.java:374) ~[flow-data-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.data.provider.DataCommunicator.computeViewportRange(DataCommunicator.java:387) ~[flow-data-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.data.provider.DataCommunicator.setRequestedRange(DataCommunicator.java:337) ~[flow-data-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.data.provider.DataCommunicator.setViewportRange(DataCommunicator.java:350) ~[flow-data-24.9.0.jar!/:24.9.0]
at com.vaadin.flow.component.grid.Grid.setViewportRange(Grid.java:4015) ~[vaadin-grid-flow-24.9.0.jar!/:na]
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[na:na]
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:na]
at java.base/java.lang.reflect.Method.invoke(Method.java:568) ~[na:na]
at com.vaadin.flow.server.communication.rpc.PublishedServerEventHandlerRpcHandler.invokeMethod(PublishedServerEventHandlerRpcHandler.java:227) ~[flow-server-24.9.0.jar!/:24.9.0]
... 65 common frames omitted

[javier-godoy]

While we were testing this issue, the CPU went to 200%. This is the stack trace before I killed the application

"http-nio-8080-exec-5" #24 daemon prio=5 os_prio=0 cpu=407679.91ms elapsed=555.17s tid=0x00007f88ceece0d0 nid=0x26 runnable [0x00007f88cb914000]
java.lang.Thread.State: RUNNABLE
at org.springframework.util.StringUtils.tokenizeToStringArray(StringUtils.java:1181)
at org.springframework.util.StringUtils.tokenizeToStringArray(StringUtils.java:1149)
at org.springframework.scheduling.support.CronExpression.parse(CronExpression.java:180)
at com.flowingcode.vaadin.addons.cronexpressionfield.CronExpressionField.calculateNextDate(CronExpressionField.java:449)
at com.flowingcode.vaadin.addons.cronexpressionfield.CronExpressionField$$Lambda$1999/0x00000008013d5e68.apply(Unknown Source)
at java.util.stream.Stream$1.tryAdvance(java.base@17.0.4.1/Stream.java:1464)
at java.util.stream.ReferencePipeline.forEachWithCancel(java.base@17.0.4.1/ReferencePipeline.java:129)
at java.util.stream.AbstractPipeline.copyIntoWithCancel(java.base@17.0.4.1/AbstractPipeline.java:527)
at java.util.stream.AbstractPipeline.copyInto(java.base@17.0.4.1/AbstractPipeline.java:513)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(java.base@17.0.4.1/AbstractPipeline.java:499)
at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(java.base@17.0.4.1/ForEachOps.java:150)
at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(java.base@17.0.4.1/ForEachOps.java:173)
at java.util.stream.AbstractPipeline.evaluate(java.base@17.0.4.1/AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.forEach(java.base@17.0.4.1/ReferencePipeline.java:596)
at com.vaadin.flow.data.provider.DataCommunicator.fetchFromProvider(DataCommunicator.java:1056)

[javier-godoy]

Parse once. Also, check if offset/limit is too large (if I request the 1000000th next date, it still has to calculate and skip the previous 999999). Maybe we can use a weak cache with some dates (or just restrict the number of next dates)..

CronExpressionField/src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionField.java

Lines 448 to 455 in 6add9d0

	private LocalDateTime calculateNextDate(LocalDateTime date) {
	return CronExpression.parse(inputExpressionTf.getValue()).next(date);
	}
	private Stream<LocalDateTime> generateNextDate(LocalDateTime start, int offset, int limit) {
	Stream<LocalDateTime> nextDates = Stream.iterate(calculateNextDate(start), this::calculateNextDate);
	return nextDates.skip(offset).limit(limit);
	}

[paodb]

When checking offset & limit scrolling to the end of the grid I see:
offset: 0 - limit: 50
offset: 2147483450 - limit: 50

[paodb]

When checking offset & limit scrolling to the end of the grid I see: offset: 0 - limit: 50 offset: 2147483450 - limit: 50

The problem is

CronExpressionField/src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionField.java

Lines 442 to 443 in 6add9d0

	grid.setItems(DataProvider.fromCallbacks(q -> generateNextDate(LocalDateTime.now(), q.getOffset(), q.getLimit()),
	q -> Integer.MAX_VALUE));