From e9c0c48463245d0de0a118f97362a56d4a906a89 Mon Sep 17 00:00:00 2001 From: Paola De Bartolo Date: Wed, 26 Nov 2025 20:44:25 -0300 Subject: [PATCH] refactor: remove label of input in cron expression field Close #11 --- .../CronExpressionField.java | 1 - .../CronExpressionFieldI18n.java | 22 ------------------- 2 files changed, 23 deletions(-) diff --git a/src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionField.java b/src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionField.java index 07fc757..5eaf27d 100644 --- a/src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionField.java +++ b/src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionField.java @@ -156,7 +156,6 @@ private boolean validateCron(String cron) { } private void configureLayout() { - inputExpressionTf.setLabel(i18n.getCronExpressionLabel()); inputExpressionTf.setValue(defaultExpression == null ? "" : defaultExpression); Button clearInputBtn = new Button(i18n.getClearBtn(), e -> { inputExpressionTf.setValue(defaultExpression == null ? "" : defaultExpression); diff --git a/src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionFieldI18n.java b/src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionFieldI18n.java index d80ea7e..dc2b031 100644 --- a/src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionFieldI18n.java +++ b/src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionFieldI18n.java @@ -32,7 +32,6 @@ */ public class CronExpressionFieldI18n implements Serializable { private Map layoutOptions; - private String cronExpressionLabel; private String clearBtn; private String startsAtLabel; private Map units; @@ -56,7 +55,6 @@ public class CronExpressionFieldI18n implements Serializable { private CronExpressionFieldI18n() { this.layoutOptions = Map.of(LayoutOptions.DAILY, "Daily", LayoutOptions.MONTHLY, "Monthly", LayoutOptions.ADVANCED, "Advanced"); - this.cronExpressionLabel = "Cron expression"; this.clearBtn = "Clear"; this.startsAtLabel = "Starts at"; this.units = Map.of(CronExpressionField.Units.SECONDS, "Seconds", CronExpressionField.Units.MINUTES, "Minutes", @@ -86,26 +84,6 @@ public static CronExpressionFieldI18n createDefault() { return new CronExpressionFieldI18n(); } - /** - * Gets the label for the cron expression input. - * - * @return the cron expression label - */ - public String getCronExpressionLabel() { - return cronExpressionLabel; - } - - /** - * Sets the label for the cron expression input. - * - * @param cronExpressionLabel the label to set - * @return this instance for method chaining - */ - public CronExpressionFieldI18n setCronExpressionLabel(String cronExpressionLabel) { - this.cronExpressionLabel = cronExpressionLabel; - return this; - } - /** * Gets the label for the clear button. *