Skip to content

refactor: remove label of input in cron expression field #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javier-godoy merged 1 commit into from
Nov 27, 2025
Merged

refactor: remove label of input in cron expression field #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ private boolean validateCron(String cron) {
}

private void configureLayout() {
inputExpressionTf.setLabel(i18n.getCronExpressionLabel());
inputExpressionTf.setValue(defaultExpression == null ? "" : defaultExpression);
Button clearInputBtn = new Button(i18n.getClearBtn(), e -> {
inputExpressionTf.setValue(defaultExpression == null ? "" : defaultExpression);
Expand Down
22 changes: 0 additions & 22 deletions src/main/java/com/flowingcode/vaadin/addons/cronexpressionfield/CronExpressionFieldI18n.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
*/
public class CronExpressionFieldI18n implements Serializable {
private Map<LayoutOptions, String> layoutOptions;
private String cronExpressionLabel;
private String clearBtn;
private String startsAtLabel;
private Map<CronExpressionField.Units, String> units;
Expand All @@ -56,7 +55,6 @@ public class CronExpressionFieldI18n implements Serializable {
private CronExpressionFieldI18n() {
this.layoutOptions =
Map.of(LayoutOptions.DAILY, "Daily", LayoutOptions.MONTHLY, "Monthly", LayoutOptions.ADVANCED, "Advanced");
this.cronExpressionLabel = "Cron expression";
this.clearBtn = "Clear";
this.startsAtLabel = "Starts at";
this.units = Map.of(CronExpressionField.Units.SECONDS, "Seconds", CronExpressionField.Units.MINUTES, "Minutes",
Expand Down Expand Up @@ -86,26 +84,6 @@ public static CronExpressionFieldI18n createDefault() {
return new CronExpressionFieldI18n();
}

/**
* Gets the label for the cron expression input.
*
* @return the cron expression label
*/
public String getCronExpressionLabel() {
return cronExpressionLabel;
}

/**
* Sets the label for the cron expression input.
*
* @param cronExpressionLabel the label to set
* @return this instance for method chaining
*/
public CronExpressionFieldI18n setCronExpressionLabel(String cronExpressionLabel) {
this.cronExpressionLabel = cronExpressionLabel;
return this;
}

/**
* Gets the label for the clear button.
*
Expand Down