fix(demo): improve dark theme support in demos

javier-godoy · paodb · commit af30ac8bd9e0 · 2025-01-09T12:04:08.000-03:00
diff --git a/src/test/java/com/flowingcode/vaadin/addons/extendedlogin/ExtendedLoginOverlayDemo.java b/src/test/java/com/flowingcode/vaadin/addons/extendedlogin/ExtendedLoginOverlayDemo.java
@@ -20,6 +20,7 @@
 package com.flowingcode.vaadin.addons.extendedlogin;
 
 import com.flowingcode.vaadin.addons.demo.DemoSource;
+import com.flowingcode.vaadin.addons.demo.TabbedDemo;
 import com.flowingcode.vaadin.addons.demo.ThemeChangeObserver;
 import com.vaadin.flow.component.html.Div;
 import com.vaadin.flow.component.html.IFrame;
@@ -45,8 +46,7 @@ public ExtendedLoginOverlayDemo() {
 
   @Override
   public void onThemeChange(String themeName) {
-    iframe.getElement().executeJs(
-        "this.contentWindow.document.querySelector('html').setAttribute('theme', $0)", themeName);
+    TabbedDemo.applyTheme(iframe.getElement(), themeName);
   }
 
 }
diff --git a/src/test/java/com/flowingcode/vaadin/addons/extendedlogin/LoginLayoutDemo.java b/src/test/java/com/flowingcode/vaadin/addons/extendedlogin/LoginLayoutDemo.java
@@ -20,6 +20,7 @@
 package com.flowingcode.vaadin.addons.extendedlogin;
 
 import com.flowingcode.vaadin.addons.demo.DemoSource;
+import com.flowingcode.vaadin.addons.demo.TabbedDemo;
 import com.flowingcode.vaadin.addons.demo.ThemeChangeObserver;
 import com.vaadin.flow.component.html.Div;
 import com.vaadin.flow.component.html.IFrame;
@@ -46,8 +47,7 @@ public LoginLayoutDemo() {
 
   @Override
   public void onThemeChange(String themeName) {
-    iframe.getElement().executeJs(
-        "this.contentWindow.document.querySelector('html').setAttribute('theme', $0)", themeName);
+    TabbedDemo.applyTheme(iframe.getElement(), themeName);
   }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@`
`20`	`20`	`package com.flowingcode.vaadin.addons.extendedlogin;`
`21`	`21`
`22`	`22`	`import com.flowingcode.vaadin.addons.demo.DemoSource;`
	`23`	`+import com.flowingcode.vaadin.addons.demo.TabbedDemo;`
`23`	`24`	`import com.flowingcode.vaadin.addons.demo.ThemeChangeObserver;`
`24`	`25`	`import com.vaadin.flow.component.html.Div;`
`25`	`26`	`import com.vaadin.flow.component.html.IFrame;`
`@@ -45,8 +46,7 @@ public ExtendedLoginOverlayDemo() {`
`45`	`46`
`46`	`47`	`@Override`
`47`	`48`	`public void onThemeChange(String themeName) {`
`48`		`- iframe.getElement().executeJs(`
`49`		`- "this.contentWindow.document.querySelector('html').setAttribute('theme', $0)", themeName);`
	`49`	`+ TabbedDemo.applyTheme(iframe.getElement(), themeName);`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`}`