Skip to content

Commit ea5ddb5

Browse files
javier-godoypaodb
authored andcommitted
test: fix flaky tests
1 parent 0d7b292 commit ea5ddb5

File tree

1 file changed

+20
-8
lines changed

1 file changed

+20
-8
lines changed

src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/ResponsiveGridIT.java

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,54 +46,64 @@ public void setup() throws Exception {
4646
private void setWidth(int w) {
4747
executeScript("arguments[0].parentElement.style.width=" + w + "+'px';", grid);
4848
$server.roundtrip();
49-
try {
50-
Thread.sleep(100);
51-
} catch (InterruptedException e) {
52-
return;
53-
}
49+
sleep();
5450
}
5551

5652
@Test
5753
public void testCreateResponsiveStep() {
5854
$server.responsiveStep(300);
5955
$server.roundtrip();
56+
sleep();
6057
assertEquals(300, $server.getCurrentStep());
6158
}
6259

6360
@Test
6461
public void testHide() {
6562
$server.responsiveStep(0).hide(0);
6663
$server.roundtrip();
64+
sleep();
6765
assertTrue(!grid.hasColumn("Col 0"));
6866
}
6967

7068
@Test
7169
public void testHideAll() throws InterruptedException {
7270
$server.responsiveStep(0).hideAll();
7371
$server.roundtrip();
74-
Thread.sleep(100);
72+
sleep();
7573
assertTrue(grid.getVisibleColumns().isEmpty());
7674
}
7775

7876
@Test
7977
public void testShow() {
8078
$server.responsiveStep(0).hide(0);
8179
$server.roundtrip();
80+
sleep();
8281
assertTrue(!grid.hasColumn("Col 0"));
8382

8483
$server.responsiveStep(100).show(0);
8584
$server.roundtrip();
85+
sleep();
8686
assertTrue(grid.hasColumn("Col 0"));
8787
}
8888

89+
private void sleep() {
90+
try {
91+
Thread.sleep(500);
92+
} catch (InterruptedException e) {
93+
return;
94+
}
95+
}
96+
8997
@Test
9098
public void testShowAll() {
9199
$server.responsiveStep(0).hide(0);
92100
$server.roundtrip();
101+
sleep();
93102
assertTrue(!grid.hasColumn("Col 0"));
94103

95104
$server.responsiveStep(100).showAll();
96105
$server.roundtrip();
106+
sleep();
97107
assertTrue(grid.hasColumn("Col 0"));
98108
}
99109

@@ -102,19 +112,20 @@ public void testRemove() throws InterruptedException {
102112
$server.responsiveStep(300);
103113
$server.responsiveStep(400);
104114
$server.roundtrip();
105-
Thread.sleep(100);
115+
sleep();
106116
assertEquals(400, $server.getCurrentStep());
107117

108118
$server.responsiveStep(400).remove();
109119
$server.roundtrip();
110-
Thread.sleep(100);
120+
sleep();
111121
assertEquals(300, $server.getCurrentStep());
112122
}
113123

114124
@Test
115125
public void testAddListenerFireImmediately() {
116126
IListenerRegistration listener = $server.responsiveStep(200).addListener();
117127
$server.roundtrip();
128+
sleep();
118129
assertEquals(1, listener.getCount());
119130
assertEquals(200, listener.getLastMinWidth());
120131
}
@@ -159,6 +170,7 @@ public void testListenerCumulativeFireImmediately() {
159170
$server.responsiveStep(300).addListener();
160171
IListenerRegistration listener = $server.responsiveStep(200).addListener();
161172
assertEquals(0, listener.getCount());
173+
sleep();
162174

163175
listener.cumulative();
164176
assertEquals(1, listener.getCount());

0 commit comments

Comments
 (0)