refactor: replace internal use of getOption/setOption with options

Close #55

Author: javier-godoy

src/main/java/com/flowingcode/vaadin/addons/xterm/XTermBase.java

@@ -124,7 +124,7 @@ private CompletableFuture<JsonValue> invoke(boolean hasResult, String name, Obje
         } else {
           arg = (Serializable) args[0];
         }
-        return executeJs(false, "this.terminal.setOption($0,$1)", name, arg);
+        return executeJs(false, "this.terminal.options[$0]=$1", name, arg);
       } else if (args == null || args.length == 0) {
         return executeJs(hasResult, "return this.terminal[$0]()", name);
       } else if (args.length == 1) {
@@ -157,8 +157,8 @@ public XTermBase() {
           optionsProxyClass
               .getConstructor(InvocationHandler.class)
               .newInstance(new ProxyInvocationHandler());
-      this.terminalProxy = (ITerminal) proxy;
-      this.terminalOptionsProxy = (ITerminalOptions) proxy;
+      terminalProxy = (ITerminal) proxy;
+      terminalOptionsProxy = (ITerminalOptions) proxy;
     } catch (InstantiationException
         | IllegalAccessException
         | InvocationTargetException
@@ -173,7 +173,7 @@ public XTermBase() {
     div.getStyle().set("height", "100%");
     getElement().appendChild(div);
 
-    this.deferredCommands = new LinkedList<>();
+    deferredCommands = new LinkedList<>();
 
     Registration r[] = new Registration[1];
     r[0] = getElement().addEventListener("terminal-initialized", ev -> afterInitialization());

src/main/resources/META-INF/frontend/fc-xterm/xterm-clipboard-mixin.ts

@@ -65,7 +65,7 @@ class ClipboardAddon extends TerminalAddon<IClipboardMixin> {
 		let initializer = ()=>{
 			//paste with right click
 			this._disposables.push(onEvent('contextmenu', ev => {
-				if (this.$.pasteWithRightClick && !terminal.getOption('rightClickSelectsWord')) {
+				if (this.$.pasteWithRightClick && !terminal.options.rightClickSelectsWord) {
 					ev.preventDefault();
 					if (_internalClipboard!==undefined) readText().then(text=>terminal.paste(text));
 				}

src/main/resources/META-INF/frontend/fc-xterm/xterm-element.ts

@@ -153,7 +153,7 @@ export class XTermElement extends LitElement implements TerminalMixin {
     super.connectedCallback();
 
     let term = this.terminal;
-    term.setOption('convertEol', true);
+    term.options.convertEol = true;
 
     //onLineFeed doesn't distinguish lines from user input and lines from terminal.write
     //<N CSI is handled by console-feature
@@ -164,7 +164,7 @@ export class XTermElement extends LitElement implements TerminalMixin {
     //https://gist.github.com/literallylara/7ece1983fab47365108c47119afb51c7
     //(C) Lara Sophie Schütt 2016, CC0 
     for(var i=44100*0.1,d="";i--;)d+=String.fromCharCode(~~((Math.sin(i/44100*2*Math.PI*800)+1)*128)); 
-    term.setOption('bellSound',"data:Audio/WAV;base64,"+btoa("RIFFdataWAVEfmt "+atob("EAAAAAEAAQBErAAARKwAAAEACABkYXRh/////w==")+d));
+    term.options.bellSound = "data:Audio/WAV;base64,"+btoa("RIFFdataWAVEfmt "+atob("EAAAAAEAAQBErAAARKwAAAEACABkYXRh/////w==")+d);
 
     term.attachCustomKeyEventHandler(ev => {
       if (ev.type!=='keydown') return false;
@@ -193,7 +193,7 @@ export class XTermElement extends LitElement implements TerminalMixin {
   }
 
   _disabledChanged(disabled: boolean) {
-    this.terminal.setOption('disableStdin', disabled);
+    this.terminal.options.disableStdin=disabled;
     this.terminal.write(disabled?"\x1b[?25l":"\x1b[?25h");
   }