fix: remove from history after iterator has been nulled

javier-godoy · mlopezFC · commit afe71ec4e389 · 2021-10-27T15:07:06.000-03:00
diff --git a/src/main/java/com/flowingcode/vaadin/addons/xterm/TerminalHistory.java b/src/main/java/com/flowingcode/vaadin/addons/xterm/TerminalHistory.java
@@ -153,9 +153,9 @@ public void add(String line) {
     if (!line.isEmpty()) {
       history.add(Objects.requireNonNull(line));
       iterator = null;
-    }
-    if (maxSize != null && history.size() > maxSize) {
-      history.removeLast();
+      if (maxSize != null && history.size() > maxSize) {
+        history.removeLast();
+      }
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -153,9 +153,9 @@ public void add(String line) {`
`153`	`153`	`if (!line.isEmpty()) {`
`154`	`154`	`history.add(Objects.requireNonNull(line));`
`155`	`155`	`iterator = null;`
`156`		`- }`
`157`		`- if (maxSize != null && history.size() > maxSize) {`
`158`		`- history.removeLast();`
	`156`	`+ if (maxSize != null && history.size() > maxSize) {`
	`157`	`+ history.removeLast();`
	`158`	`+ }`
`159`	`159`	`}`
`160`	`160`	`}`
`161`	`161`