refactor: add bellSound and bellStyle as properties of fc-xterm

Close #73

Author: javier-godoy

src/main/java/com/flowingcode/vaadin/addons/xterm/XTermBase.java

@@ -124,7 +124,11 @@ private CompletableFuture<JsonValue> invoke(boolean hasResult, String name, Obje
         } else {
           arg = (Serializable) args[0];
         }
-        return executeJs(false, "this.terminal.options[$0]=$1", name, arg);
+        if (name.equals("bellStyle") || name.equals("bellSound")) {
+          return executeJs(false, "this[$0]=$1", name, arg);
+        } else {
+          return executeJs(false, "this.terminal.options[$0]=$1", name, arg);
+        }
       } else if (args == null || args.length == 0) {
         return executeJs(hasResult, "return this.terminal[$0]()", name);
       } else if (args.length == 1) {

src/main/resources/META-INF/frontend/fc-xterm/xterm-element.ts

@@ -136,7 +136,10 @@ export class XTermElement extends LitElement implements TerminalMixin {
   terminal: Terminal;
   disabled: boolean = false;
   node: XTermElement;
-
+  
+  bellSound: string;
+  bellStyle: 'none' | 'sound'
+  
   customKeyEventHandlers: CustomKeyEventHandlerRegistry;
 
   render(): TemplateResult {
@@ -150,6 +153,12 @@ export class XTermElement extends LitElement implements TerminalMixin {
     this.customKeyEventHandlers = new CustomKeyEventHandlerRegistry();
     this.terminal = new Terminal();	
 	this.node = this;
+    
+    //https://gist.github.com/literallylara/7ece1983fab47365108c47119afb51c7
+    //(C) Lara Sophie Schütt 2016, CC0 
+    for(var i=44100*0.1,d="";i--;)d+=String.fromCharCode(~~((Math.sin(i/44100*2*Math.PI*800)+1)*128)); 
+    this.bellSound = "data:Audio/WAV;base64,"+btoa("RIFFdataWAVEfmt "+atob("EAAAAAEAAQBErAAARKwAAAEACABkYXRh/////w==")+d);
+    this.bellStyle = 'none';
   }
 
   connectedCallback() {
@@ -163,11 +172,12 @@ export class XTermElement extends LitElement implements TerminalMixin {
     term.onData(e => {
         term.write(e.replace(/\r/g,'\x1b[<N\n'));
     });
-            
-    //https://gist.github.com/literallylara/7ece1983fab47365108c47119afb51c7
-    //(C) Lara Sophie Schütt 2016, CC0 
-    for(var i=44100*0.1,d="";i--;)d+=String.fromCharCode(~~((Math.sin(i/44100*2*Math.PI*800)+1)*128)); 
-    term.options.bellSound = "data:Audio/WAV;base64,"+btoa("RIFFdataWAVEfmt "+atob("EAAAAAEAAQBErAAARKwAAAEACABkYXRh/////w==")+d);
+    
+    term.onBell(() => {
+      if (this.bellStyle == 'sound') {
+        new Audio(this.bellSound).play();
+      }
+    });
 
     term.attachCustomKeyEventHandler(ev => {
       if (ev.type!=='keydown') return false;