chore: remove support for page up/down history navigation

Author: javier-godoy

src/main/java/com/flowingcode/vaadin/addons/xterm/TerminalHistory.java

@@ -28,8 +28,6 @@ public class TerminalHistory implements Serializable {
 
   private List<Registration> registrations;
 
-  private String prefix;
-
   private String lastRet;
 
   private String initialLine;
@@ -84,8 +82,6 @@ public void setEnabled(boolean enabled) {
       registrations.add(((ITerminalConsole) terminal).addLineListener(ev -> add(ev.getLine())));
       registrations.add(terminal.addCustomKeyListener(ev -> handleArrowUp(), Key.ARROW_UP));
       registrations.add(terminal.addCustomKeyListener(ev -> handleArrowDown(), Key.ARROW_DOWN));
-      registrations.add(terminal.addCustomKeyListener(ev -> handlePageUp(), Key.PAGE_UP));
-      registrations.add(terminal.addCustomKeyListener(ev -> handlePageDown(), Key.PAGE_DOWN));
     }
   }
 
@@ -109,15 +105,6 @@ private void handleArrowDown() {
     write(next());
   }
 
-  private void handlePageUp() {
-    ((ITerminalConsole) terminal).getCurrentLine().thenApply(this::findPrevious)
-        .thenAccept(this::write);
-  }
-
-  private void handlePageDown() {
-    ((ITerminalConsole) terminal).getCurrentLine().thenApply(this::findNext)
-        .thenAccept(this::write);
-  }
 
   private void write(String line) {
     if (line != null) {
@@ -168,14 +155,6 @@ public void add(String line) {
     }
   }
 
-  private void setCurrentLine(String currentLine) {
-    if (!currentLine.equals(lastRet)) {
-      initialLine = currentLine;
-      prefix = currentLine;
-      iterator = null;
-    }
-  }
-
   private Optional<String> find(Iterator<String> iterator, Predicate<String> predicate) {
     while (iterator.hasNext()) {
       String line = iterator.next();
@@ -198,16 +177,6 @@ private String next() {
     });
   }
 
-  private String findPrevious(String currentLine) {
-    setCurrentLine(currentLine);
-    return find(reverseIterator(), line -> line.startsWith(prefix)).orElse(null);
-  }
-
-  private String findNext(String currentLine) {
-    setCurrentLine(currentLine);
-    return find(forwardIterator(), line -> line.startsWith(prefix)).orElse("");
-  }
-
   /** Clears the history. */
   public void clear() {
     history.clear();

src/test/java/com/flowingcode/vaadin/addons/xterm/integration/TerminalHistoryIT.java

@@ -61,40 +61,4 @@ public void testArrowKeysAndRestore() {
     assertThat(currentLine(term), is("bar"));
   }
 
-  @Test
-  public void testPageUpDown() {
-    TestBenchElement term = $("fc-xterm").first();
-
-    WebElement input = (WebElement) waitUntil(driver -> ((HasTestBenchCommandExecutor) driver)
-        .getCommandExecutor().executeScript("return arguments[0].terminal.textarea", term));
-
-    int y = cursorPosition(term).y;
-    input.sendKeys("foo1\nfoo2\nbar1\nfoo3\n");
-
-    assertThat(cursorPosition(term), is(at(0, y += 4)));
-    assertThat(lineAtOffset(term, 0), isEmptyString());
-
-    input.sendKeys("f", Keys.PAGE_UP);
-    assertThat(currentLine(term), is("foo3"));
-
-    input.sendKeys(Keys.PAGE_UP);
-    assertThat(currentLine(term), is("foo2"));
-
-    input.sendKeys(Keys.PAGE_UP);
-    assertThat(currentLine(term), is("foo1"));
-
-    input.sendKeys(Keys.PAGE_UP);
-    assertThat(currentLine(term), is("foo1"));
-
-    input.sendKeys(Keys.PAGE_DOWN);
-    assertThat(currentLine(term), is("foo2"));
-
-    input.sendKeys(Keys.PAGE_DOWN);
-    assertThat(currentLine(term), is("foo3"));
-
-    input.sendKeys(Keys.PAGE_DOWN);
-    assertThat(currentLine(term), isEmptyString());
-
-  }
-
 }