From 0fac41193691b04be06fc1822f2ecdd31d4086bb Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Wed, 6 Nov 2024 09:36:10 -0300 Subject: [PATCH 1/2] docs: fix javadoc warnings Close #94 --- src/main/java/com/flowingcode/vaadin/addons/xterm/ITerminal.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/com/flowingcode/vaadin/addons/xterm/ITerminal.java b/src/main/java/com/flowingcode/vaadin/addons/xterm/ITerminal.java index a0f16a0..2fdfc9a 100644 --- a/src/main/java/com/flowingcode/vaadin/addons/xterm/ITerminal.java +++ b/src/main/java/com/flowingcode/vaadin/addons/xterm/ITerminal.java @@ -109,7 +109,6 @@ public interface ITerminal extends Serializable { * @param data The data to write to the terminal. This can either be raw bytes given as Uint8Array * from the pty or a string. Raw bytes will always be treated as UTF-8 encoded, string data as * UTF-16. - * @param callback Optional callback that fires when the data was processed by the parser. */ void writeln(String data); From f7f34b2f9f53077a83c54b9c737f1a9eeacd883f Mon Sep 17 00:00:00 2001 From: Javier Godoy <11554739+javier-godoy@users.noreply.github.com> Date: Wed, 6 Nov 2024 09:38:31 -0300 Subject: [PATCH 2/2] ci: configure Javadoc failOnWarnings Close #95 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a26d095..a29cbf8 100644 --- a/pom.xml +++ b/pom.xml @@ -274,7 +274,7 @@ true none - false + true https://javadoc.io/doc/com.vaadin/vaadin-platform-javadoc/${vaadin.version}