-
-
Notifications
You must be signed in to change notification settings - Fork 23.1k
feat: Add GigaChat #5484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add GigaChat #5484
Conversation
Summary of ChangesHello @NarekChang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the platform's capabilities by integrating the GigaChat language model. It provides users with new nodes for interacting with GigaChat as a chat model, an embedding model, and a general large language model, complete with various model options and API scope configurations. The integration also includes necessary infrastructure for credential management and handling potential TLS certificate issues, ensuring a smooth setup process for GigaChat users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for GigaChat models, including chat, LLM, and embedding nodes. The implementation is comprehensive, but there are a few issues to address. I've found some minor typos in descriptions and a potential issue with how the baseUrl is handled, which could lead to runtime errors. Most critically, there's a significant security vulnerability due to the hardcoded disabling of TLS certificate validation for GigaChat requests, which should be made a configurable, opt-in feature.
This commit adds support for the GigaChat language model. The model is already compatible with LangChain.
Entities added:
llm, embedding, credential, chatmodel.To support the model, you need to install the npm package langchain-gigachat