Skip to content

Commit 283cab2

Browse files
authored
Merge pull request #6789 from Flowminder/fix-str-enum
Fix str enum
2 parents 90afee5 + e877fc6 commit 283cab2

File tree

19 files changed

+2504
-2721
lines changed

19 files changed

+2504
-2721
lines changed

.circleci/config.yml

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ commands:
2020
2121
defaults:
2222
- &base_docker
23-
- image: cimg/python:3.8
23+
- image: cimg/python:3.12
2424
environment:
2525
FLOWDB_PORT: 5432
2626
MPLBACKEND: "agg"
@@ -72,7 +72,7 @@ executors:
7272
parameters:
7373
python_version:
7474
type: enum
75-
enum: ["3.7", "3.8", "3.9", "3.11"]
75+
enum: ["3.7", "3.8", "3.9", "3.11", "3.12"]
7676
default: "3.8"
7777
flowdb_image:
7878
type: enum
@@ -328,13 +328,13 @@ jobs:
328328
steps:
329329
- checkout
330330
- restore_cache:
331-
key: flowmachine-deps-8-{{ checksum "flowmachine/Pipfile.lock" }}
331+
key: flowmachine-deps-9-{{ checksum "flowmachine/Pipfile.lock" }}
332332
# Need to install graphviz and pygraphviz manually because it was removed from the Pipfile
333333
# (see https://github.com/Flowminder/FlowKit/issues/952)
334334
- run: cd flowmachine && pipenv install --dev --deploy
335335
- run: cd flowmachine && sudo apt-get update && sudo apt-get install -y libgraphviz-dev graphviz && pipenv run pip install pygraphviz
336336
- save_cache:
337-
key: flowmachine-deps-8-{{ checksum "flowmachine/Pipfile.lock" }}
337+
key: flowmachine-deps-9-{{ checksum "flowmachine/Pipfile.lock" }}
338338
paths:
339339
- /home/circleci/.local/share/virtualenvs/
340340

@@ -344,7 +344,7 @@ jobs:
344344
steps:
345345
- checkout
346346
- restore_cache:
347-
key: flowmachine-deps-8-{{ checksum "flowmachine/Pipfile.lock" }}
347+
key: flowmachine-deps-9-{{ checksum "flowmachine/Pipfile.lock" }}
348348
- run:
349349
name: Linting files with black
350350
# Installed the version of Black from flowmachine's lockfile
@@ -378,14 +378,15 @@ jobs:
378378
name: python_with_flowdb
379379
flowdb_image: "testdata"
380380
num_days: 7
381+
python_version: "3.12"
381382
working_directory: /home/circleci/project/flowmachine
382383
steps:
383384
- checkout:
384385
path: /home/circleci/project/
385386
- attach_workspace:
386387
at: /home/circleci/
387388
- restore_cache:
388-
key: flowmachine-deps-8-{{ checksum "Pipfile.lock" }}
389+
key: flowmachine-deps-9-{{ checksum "Pipfile.lock" }}
389390
- run:
390391
name: Install graphviz
391392
command: sudo apt-get update && sudo apt-get install -y xvfb libgraphviz-dev graphviz
@@ -694,18 +695,18 @@ jobs:
694695
executor:
695696
name: python_with_flowdb
696697
flowdb_image: "testdata"
697-
python_version: "3.8"
698+
python_version: "3.11"
698699
working_directory: /home/circleci/project/integration_tests
699700
steps:
700701
- checkout:
701702
path: /home/circleci/project/
702703
- attach_workspace:
703704
at: /home/circleci
704705
- restore_cache:
705-
key: integration-test-deps-6-{{ checksum "Pipfile.lock" }}
706+
key: integration-test-deps-7-{{ checksum "Pipfile.lock" }}
706707
- run: pipenv install --deploy --dev
707708
- save_cache:
708-
key: integration-test-deps-6-{{ checksum "Pipfile.lock" }}
709+
key: integration-test-deps-7-{{ checksum "Pipfile.lock" }}
709710
paths:
710711
- /home/circleci/.local/share/virtualenvs/
711712
- run: *wait_for_flowdb
@@ -769,14 +770,15 @@ jobs:
769770
num_mds: 20000
770771
disaster_start_date: 2016-02-11
771772
disaster_end_date: 2016-03-01
773+
python_version: "3.11"
772774
working_directory: /home/circleci/project/docs
773775
steps:
774776
- checkout:
775777
path: /home/circleci/project/
776778
- attach_workspace:
777779
at: /home/circleci/
778780
- restore_cache:
779-
key: flowkit-docs-deps-6-{{ checksum "Pipfile.lock" }}
781+
key: flowkit-docs-deps-7-{{ checksum "Pipfile.lock" }}
780782
- run:
781783
name: Install pandoc
782784
command: |
@@ -870,7 +872,7 @@ jobs:
870872
path: /home/circleci/project/docs/pg_log.zip
871873
destination: pg_log
872874
- save_cache:
873-
key: flowkit-docs-deps-6-{{ checksum "Pipfile.lock" }}
875+
key: flowkit-docs-deps-7-{{ checksum "Pipfile.lock" }}
874876
paths:
875877
- /home/circleci/.local/share/virtualenvs/
876878

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
99
### Added
1010

1111
### Changed
12+
- FlowMachine now requires python >= 3.11
1213

1314
### Fixed
15+
- Diretion enum not being recognised [#6787](https://github.com/Flowminder/FlowKit/issues/6787)
1416

1517
### Removed
1618
- Removed Oracle fdw

docs/Pipfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ mike = "*"
3434
jupyterlab = "*"
3535

3636
[requires]
37-
python_version = "3.8"
37+
python_version = "3.11"
3838

3939
[scripts]
4040
build = "bash build.sh"

docs/Pipfile.lock

Lines changed: 1095 additions & 1169 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flowmachine.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# License, v. 2.0. If a copy of the MPL was not distributed with this
33
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
44

5-
FROM python:3.8-slim-bullseye@sha256:1e749e00ba22618288f0d16fa610c35d984e5e92b290f39ebd1cda1604220cb5
5+
FROM python:3.12-bullseye@sha256:fa925b59486a5c2d8e3d10897fc9da22def0bce17a9c18924c8ece3819823635
66

77
ARG SOURCE_VERSION=0+unknown
88
ENV SOURCE_VERSION=${SOURCE_VERSION}

flowmachine/Pipfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ cachetools = "*"
99
numpy = "*"
1010
networkx = "*"
1111
pandas = "*"
12-
pglast = "==4.1" # Pin pglast because different versions may produce different query IDs
12+
pglast = "==6.3" # Pin pglast because different versions may produce different query IDs
1313
python-dateutil = "*"
1414
pytz = "*"
1515
python-louvain = "*"
@@ -38,12 +38,11 @@ pytest = "*"
3838
pytest-asyncio = "*"
3939
pytest-cov = "*"
4040
pytest-testmon = "*"
41-
asynctest = "*"
4241
cachey = "*"
4342
approvaltests = "*"
4443
watchdog = "*"
4544
ipdb = "*"
4645
flowmachine = {editable = true, extras = ["test"], path = "."}
4746

4847
[requires]
49-
python_version = "3.8"
48+
python_version = "3.12"

0 commit comments

Comments
 (0)