TASK: Clarify the "workspace" used in IndexingJob

Author: kdambekalns

Classes/Flowpack/ElasticSearch/ContentRepositoryQueueIndexer/Indexer/NodeIndexer.php

@@ -34,7 +34,7 @@ class NodeIndexer extends ContentRepositoryAdaptor\Indexer\NodeIndexer
 
     /**
      * @param NodeInterface $node
-     * @param string|null $targetWorkspaceName
+     * @param string|null $targetWorkspaceName In case indexing is triggered during publishing, a target workspace name will be passed in
      */
     public function indexNode(NodeInterface $node, $targetWorkspaceName = null)
     {

Classes/Flowpack/ElasticSearch/ContentRepositoryQueueIndexer/IndexingJob.php

@@ -6,6 +6,7 @@
 use Flowpack\JobQueue\Common\Job\JobInterface;
 use Flowpack\JobQueue\Common\Queue\Message;
 use Flowpack\JobQueue\Common\Queue\QueueInterface;
+use Neos\ContentRepository\Domain\Model\NodeData;
 use Neos\Flow\Annotations as Flow;
 use Neos\Flow\Log\SystemLoggerInterface;
 use Neos\Flow\Utility\Algorithms;
@@ -52,7 +53,7 @@ class IndexingJob implements JobInterface
     /**
      * @var string
      */
-    protected $workspaceName;
+    protected $targetWorkspaceName;
 
     /**
      * @var string
@@ -66,13 +67,13 @@ class IndexingJob implements JobInterface
 
     /**
      * @param string $indexPostfix
-     * @param string $workspaceName
+     * @param string $targetWorkspaceName In case indexing is triggered during publishing, a target workspace name will be passed in
      * @param array $nodes
      */
-    public function __construct($indexPostfix, $workspaceName, array $nodes)
+    public function __construct($indexPostfix, $targetWorkspaceName, array $nodes)
     {
         $this->identifier = Algorithms::generateRandomString(24);
-        $this->workspaceName = $workspaceName;
+        $this->targetWorkspaceName = $targetWorkspaceName;
         $this->indexPostfix = $indexPostfix;
         $this->nodes = $nodes;
     }
@@ -94,7 +95,7 @@ public function execute(QueueInterface $queue, Message $message)
                 /** @var NodeData $nodeData */
                 $nodeData = $this->nodeDataRepository->findByIdentifier($node['nodeIdentifier']);
                 $context = $this->contextFactory->create([
-                    'workspaceName' => $this->workspaceName,
+                    'workspaceName' => $this->targetWorkspaceName,
                     'invisibleContentShown' => true,
                     'inaccessibleContentShown' => false,
                     'dimensions' => $node['dimensions']