TASK: Set strict types declaration

Author: daniellienert

Classes/Domain/Factory/ClientFactory.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 namespace Flowpack\ElasticSearch\Domain\Factory;
 
 /*

Classes/Domain/Factory/DocumentFactory.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 namespace Flowpack\ElasticSearch\Domain\Factory;
 
 /*

Classes/Domain/Model/AbstractType.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 namespace Flowpack\ElasticSearch\Domain\Model;
 
 /*

Classes/Domain/Model/Client.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 namespace Flowpack\ElasticSearch\Domain\Model;
 
 /*
@@ -78,8 +80,9 @@ public function setClientConfigurations(array $clientConfigurations)
     /**
      * @param string $indexName
      * @return Index
+     * @throws \Flowpack\ElasticSearch\Exception
      */
-    public function findIndex($indexName)
+    public function findIndex(string $indexName): Index
     {
         if (!array_key_exists($indexName, $this->indexCollection)) {
             $this->indexCollection[$indexName] = new Index($indexName, $this);
@@ -96,8 +99,11 @@ public function findIndex($indexName)
      * @param array $arguments
      * @param string|array $content
      * @return Response
+     * @throws \Flowpack\ElasticSearch\Transfer\Exception
+     * @throws \Flowpack\ElasticSearch\Transfer\Exception\ApiException
+     * @throws \Neos\Flow\Http\Exception
      */
-    public function request($method, $path = null, array $arguments = [], $content = null)
+    public function request(string $method, ?string $path = null, array $arguments = [], $content = null): Response
     {
         return $this->requestService->request($method, $this, $path, $arguments, $content);
     }

Classes/Domain/Model/Document.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 namespace Flowpack\ElasticSearch\Domain\Model;
 
 /*

Classes/Domain/Model/GenericType.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 namespace Flowpack\ElasticSearch\Domain\Model;
 
 /*

Classes/Domain/Model/Index.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 namespace Flowpack\ElasticSearch\Domain\Model;
 
 /*
@@ -114,7 +116,7 @@ public function __construct($name, Client $client = null)
      * @param array $settings
      * @return void
      */
-    public function injectSettings(array $settings)
+    public function injectSettings(array $settings): void
     {
         $this->settings = $settings;
     }
@@ -123,7 +125,7 @@ public function injectSettings(array $settings)
      * @param string $typeName
      * @return AbstractType
      */
-    public function findType($typeName)
+    public function findType($typeName): AbstractType
     {
         return new GenericType($this, $typeName);
     }
@@ -132,15 +134,16 @@ public function findType($typeName)
      * @param array <AbstractType> $types
      * @return TypeGroup
      */
-    public function findTypeGroup(array $types)
+    public function findTypeGroup(array $types): TypeGroup
     {
         return new TypeGroup($this, $types);
     }
 
     /**
-     * @return boolean
+     * @return bool
+     * @throws \Exception
      */
-    public function exists()
+    public function exists(): bool
     {
         $response = $this->request('HEAD');
 
@@ -152,14 +155,14 @@ public function exists()
      * @param string $path
      * @param array $arguments
      * @param string $content
-     * @param boolean $prefixIndex
+     * @param bool $prefixIndex
      * @return Response
-     * @throws ElasticSearchException
+     * @throws \Exception
      */
-    public function request($method, $path = null, array $arguments = [], $content = null, $prefixIndex = true)
+    public function request(string $method, ?string $path = null, array $arguments = [], ?string $content = null, bool $prefixIndex = true): Response
     {
         if ($this->client === null) {
-            throw new Exception('The client of the index "' . $this->name . '" is not set, hence no requests can be done.');
+            throw new \Exception('The client of the index "' . $this->name . '" is not set, hence no requests can be done.', 1566313883);
         }
         $path = ($path ? trim($path) : '');
         if ($prefixIndex === true) {
@@ -173,8 +176,9 @@ public function request($method, $path = null, array $arguments = [], $content =
 
     /**
      * @return void
+     * @throws \Exception
      */
-    public function create()
+    public function create(): void
     {
         $this->request('PUT', null, [], json_encode($this->getSettings()));
     }
@@ -196,6 +200,7 @@ protected function getSettings()
 
     /**
      * @return void
+     * @throws \Exception
      */
     public function updateSettings()
     {

Classes/Domain/Model/Mapping.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 namespace Flowpack\ElasticSearch\Domain\Model;
 
 /*

Classes/Domain/Model/TypeGroup.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 namespace Flowpack\ElasticSearch\Domain\Model;
 
 /*

Classes/Indexer/Aspect/IndexerAspect.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 namespace Flowpack\ElasticSearch\Indexer\Aspect;
 
 /*