BUGFIX: Fix deprecation warning with PHP 8

jonnitto · web-flow · commit 7c87d7a2b1b1 · 2022-04-06T13:23:27.000+02:00
This removes the warning

`PHP Deprecated:  Required parameter $response follows optional parameter $id in Application/Flowpack.ElasticSearch/Classes/Domain/Factory/DocumentFactory.php on line 40`
diff --git a/Classes/Domain/Factory/DocumentFactory.php b/Classes/Domain/Factory/DocumentFactory.php
@@ -37,7 +37,7 @@ class DocumentFactory
      * @return Model\Document
      * @throws DocumentPropertiesMismatchException
      */
-    public function createFromResponse(Model\AbstractType $type, $id = null, Response $response)
+    public function createFromResponse(Model\AbstractType $type, $id, Response $response)
     {
         $content = $response->getTreatedContent();
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ class DocumentFactory`
`37`	`37`	`* @return Model\Document`
`38`	`38`	`* @throws DocumentPropertiesMismatchException`
`39`	`39`	`*/`
`40`		`- public function createFromResponse(Model\AbstractType $type, $id = null, Response $response)`
	`40`	`+ public function createFromResponse(Model\AbstractType $type, $id, Response $response)`
`41`	`41`	`{`
`42`	`42`	`$content = $response->getTreatedContent();`
`43`	`43`