Merge pull request #105 from daniellienert/bugfix/set-curl-opt-correctly

daniellienert · web-flow · commit b07f7184e2a7 · 2022-12-09T13:30:01.000+01:00
BUGFIX: Convert true / false to correct curlopt value
diff --git a/Classes/Transfer/RequestService.php b/Classes/Transfer/RequestService.php
@@ -67,8 +67,8 @@ public function initializeObject()
     {
         $requestEngine = new CurlEngine();
         $requestEngine->setOption(CURLOPT_TIMEOUT, $this->settings['transfer']['connectionTimeout']);
-        $requestEngine->setOption(CURLOPT_SSL_VERIFYPEER, $this->settings['transfer']['sslVerifyPeer']);
-        $requestEngine->setOption(CURLOPT_SSL_VERIFYHOST, $this->settings['transfer']['sslVerifyHost']);
+        $requestEngine->setOption(CURLOPT_SSL_VERIFYPEER, $this->settings['transfer']['sslVerifyPeer'] ?? true ? 2 : 0);
+        $requestEngine->setOption(CURLOPT_SSL_VERIFYHOST, $this->settings['transfer']['sslVerifyHost'] ?? true ? 2 : 0);
         $this->browser->setRequestEngine($requestEngine);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,8 @@ public function initializeObject()`
`67`	`67`	`{`
`68`	`68`	`$requestEngine = new CurlEngine();`
`69`	`69`	`$requestEngine->setOption(CURLOPT_TIMEOUT, $this->settings['transfer']['connectionTimeout']);`
`70`		`- $requestEngine->setOption(CURLOPT_SSL_VERIFYPEER, $this->settings['transfer']['sslVerifyPeer']);`
`71`		`- $requestEngine->setOption(CURLOPT_SSL_VERIFYHOST, $this->settings['transfer']['sslVerifyHost']);`
	`70`	`+ $requestEngine->setOption(CURLOPT_SSL_VERIFYPEER, $this->settings['transfer']['sslVerifyPeer'] ?? true ? 2 : 0);`
	`71`	`+ $requestEngine->setOption(CURLOPT_SSL_VERIFYHOST, $this->settings['transfer']['sslVerifyHost'] ?? true ? 2 : 0);`
`72`	`72`	`$this->browser->setRequestEngine($requestEngine);`
`73`	`73`	`}`
`74`	`74`