-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Instead of setting the inProjectSourceUrl we could have a setting like this:
Flowpack:
Neos:
WhatsNewDashboard:
inProjectSourceUrl:
baseUrl: 'https://example.com'
path: '/new'
token: 'GI19cT6OfWaU5AVYmt7QmR29EimxClemH'Like that we could check if the page in Flowpack.Neos.WhatsNewEditor.InMyProject:Document.WhatsNewDashboardPage will be showed like this:
${Security.isAuthenticated() || request.arguments.token == Configuration.Setting('Flowpack.Neos.WhatsNewDashboard.inProjectSourceUrl.token')}This would require also a cache entry:
@cache {
mode = 'dynamic'
maximumLifetime = ${q(node).context({'invisibleContentShown': true}).add(q(node).children('[instanceof Neos.Neos:ContentCollection]').find('[instanceof Neos.Neos:Content]')).cacheLifetime()}
entryIdentifier {
node = ${node}
}
entryDiscriminator = ${request.arguments.token}
context {
1 = 'node'
2 = 'documentNode'
3 = 'site'
}
entryTags {
1 = ${Neos.Caching.nodeTag(node)}
2 = ${Neos.Caching.descendantOfTag(node)}
}
}Of course the Javascript from the modal should respect also these settings
Why splitting the inProjectSourceUrl in three parts?
- With the
baseUrlwe are able to make theapirequest for the timestamp - With the
tokenthe user don't need to be logged in - If
baseUrland/ortokenis not set, everything would work as now
Metadata
Metadata
Assignees
Labels
No labels