BUGFIX: fix NIL error on error handling

Author: skurfuerst

prunner.go

@@ -552,7 +552,11 @@ func findFirstFailedTaskByEndDate(tasks jobTasks) *jobTask {
 		// Check if the task failed (has an error or non-zero exit code)
 		if task.Errored {
 			// If this is our first failed task or this one ended earlier than our current earliest
-			if firstFailedTask == nil || task.End.Before(*firstFailedTask.End) {
+			if firstFailedTask == nil {
+				// we did not see any failed task yet. remember this one as the 1st failed task.
+				firstFailedTask = task
+			} else if firstFailedTask.End != nil && task.End != nil && task.End.Before(*firstFailedTask.End) {
+				// this task has failed EARLIER than the one we already remembered.
 				firstFailedTask = task
 			}
 		}
@@ -602,6 +606,11 @@ func (r *PipelineRunner) HandleTaskChange(t *task.Task) {
 	// NOTE: this is NOT the context.Canceled case from above (if a job is explicitly aborted), but only
 	// if one task failed, and we want to kill the other tasks.
 	if jt.Errored {
+		if jt.End == nil {
+			// Remember ending time in case of error (we need this to identify the correct onError hook)
+			now := time.Now()
+			jt.End = &now
+		}
 		pipelineDef, found := r.defs.Pipelines[j.Pipeline]
 		if found && !pipelineDef.ContinueRunningTasksAfterFailure {
 			log.

prunner_test.go

@@ -234,15 +234,20 @@ func TestPipelineRunner_ScheduleAsync_WithFailingScript_TriggersOnErrorHook(t *t
 					"a": {
 						Script: []string{"echo A"},
 					},
+					"c": {
+						Script:    []string{"sleep 10; exit 42"},
+						DependsOn: []string{"b"},
+					},
 					"b": {
 						Script: []string{
 							"echo stdoutContent",
 							"echo This message goes to stderr >&2",
 							"exit 42",
 						},
+						DependsOn: []string{"a"},
 					},
 					"wait": {
-						DependsOn: []string{"a", "b"},
+						DependsOn: []string{"a", "b", "c"},
 					},
 				},
 				OnError: &definition.OnErrorTaskDef{