Address review comments.

Author: tomusdrw

shared/links-metadata/src/link.ts

@@ -98,9 +98,9 @@ export async function parseAndMigrateLink(
       updated = `${ORIGIN}#/${toVersionShort}/${encodePageNumberAndIndex(migratedSelection.selectionStart)}${encodePageNumberAndIndex(migratedSelection.selectionEnd)}`;
       migrated = true;
     } else {
-      const latestSynctex = await synctexStore.getSynctex(toVersion);
-      const hasStart = !!latestSynctex.blocksByPage.get(selectionStart.pageNumber)?.[selectionStart.index];
-      const hasEnd = !!latestSynctex.blocksByPage.get(selectionEnd.pageNumber)?.[selectionEnd.index];
+      const toVersionSynctex = await synctexStore.getSynctex(toVersion);
+      const hasStart = !!toVersionSynctex.blocksByPage.get(selectionStart.pageNumber)?.[selectionStart.index];
+      const hasEnd = !!toVersionSynctex.blocksByPage.get(selectionEnd.pageNumber)?.[selectionEnd.index];
 
       if (hasStart && hasEnd) {
         updated = `${ORIGIN}#/${toVersionShort}/${linkData.blocks}`;

tools/links-check/scan.ts

@@ -66,9 +66,9 @@ export async function scan(files: Path[], metadata: Metadata, version?: string):
   return Promise.resolve(report);
 }
 
-function findVersion(metadata: Metadata, version?: string) {
+function findVersion(metadata: Metadata, version: string = metadata.metadata.latest) {
   const v = version === "latest" ? metadata.metadata.latest : version;
-  const versionData = metadata.metadata.versions[v || metadata.metadata.latest];
+  const versionData = metadata.metadata.versions[v];
   if (versionData) {
     return versionData;
   }