generated notes with empty file name

[danicuki]

I tried to generate notes based on my code.

here is my command run:

npx @fluffylabs/links-check --generate-notes x.json $(find . -name *.ex) 
resolving glob patterns: 356.589ms

fetching metadata: 89.497ms
⏱️ 53.70ms: lib/system/header_seal.ex
         🔗 https://graypaper.fluffylabs.dev/#/5f542d7/0ece000e1501
scanning 639: 72.767ms


📓 Generating notes to x.json

✅ No outdated links found amongst 1 total, congrats!

and here is the x.json output:

{
  "version": 3,
  "notes": [
    {
      "noteVersion": 3,
      "content": ":56",
      "date": 1739312171654,
      "author": "",
      "version": "5f542d710f52bcfd22cd400d1b0b99e15003cc67",
      "labels": [],
      "selectionStart": {
        "pageNumber": 14,
        "index": 206
      },
      "selectionEnd": {
        "pageNumber": 14,
        "index": 277
      }
    }
  ]
}

it correctly identifies the file line (56), but the file name is empty. Is this a bug or am I doing something wrong?

[tomusdrw]

Thanks for the report. That's a bug - an edge case for a situation where only a single file is given to the tool.

From all the filenames that are provided (or resolved from a pattern) we compute & strip the common prefix to make the filename path as minimal as possible.

However as you can imagine with a single file, the common path is the whole path, hence it's stripped.
https://github.com/FluffyLabs/graypaper-reader/blob/main/tools/links-check/notes.ts#L6

Patched here:
#171