Fix retain cycle in PanGestureCoordinator (#167)

JohnEstropia · web-flow · commit 7130be12f9fe · 2023-12-07T19:01:25.000+09:00
diff --git a/Sources/FluidKeyboardSupport/UIScrollView+HidingKeyboard.swift b/Sources/FluidKeyboardSupport/UIScrollView+HidingKeyboard.swift
@@ -32,7 +32,7 @@ extension UIScrollView {
 @MainActor
 private final class PanGestureCoordinator: NSObject, UIGestureRecognizerDelegate {
 
-  private let scrollView: UIScrollView
+  private weak var scrollView: UIScrollView?
   private let panGesture: UIPanGestureRecognizer
 
   init(scrollView: UIScrollView, panGesture: UIPanGestureRecognizer) {
@@ -46,8 +46,8 @@ private final class PanGestureCoordinator: NSObject, UIGestureRecognizerDelegate
   }
 
   deinit {
-    Task { @MainActor [scrollView, panGesture] in
-      scrollView.removeGestureRecognizer(panGesture)
+    Task { @MainActor [weak scrollView, panGesture] in
+      scrollView?.removeGestureRecognizer(panGesture)
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ extension UIScrollView {`
`32`	`32`	`@MainActor`
`33`	`33`	`private final class PanGestureCoordinator: NSObject, UIGestureRecognizerDelegate {`
`34`	`34`
`35`		`- private let scrollView: UIScrollView`
	`35`	`+ private weak var scrollView: UIScrollView?`
`36`	`36`	`private let panGesture: UIPanGestureRecognizer`
`37`	`37`
`38`	`38`	`init(scrollView: UIScrollView, panGesture: UIPanGestureRecognizer) {`
`@@ -46,8 +46,8 @@ private final class PanGestureCoordinator: NSObject, UIGestureRecognizerDelegate`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`deinit {`
`49`		`- Task { @MainActor [scrollView, panGesture] in`
`50`		`- scrollView.removeGestureRecognizer(panGesture)`
	`49`	`+ Task { @MainActor [weak scrollView, panGesture] in`
	`50`	`+ scrollView?.removeGestureRecognizer(panGesture)`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`