Skip to content

Commit f23b177

Browse files
committed
[TASK] Check for interface before function call
1 parent 2d9a24d commit f23b177

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Classes/Builder/ViewBuilder.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,9 @@ protected function createViewInstance(
158158
$request = null
159159
): ViewInterface {
160160
$typoScriptViewConfiguration = null;
161-
if ($request && ($typoScript = $request->getAttribute('frontend.typoscript')) instanceof FrontendTypoScript) {
161+
if ($request instanceof ServerRequestInterface
162+
&& ($typoScript = $request->getAttribute('frontend.typoscript')) instanceof FrontendTypoScript
163+
) {
162164
$extensionSignature = ExtensionNamingUtility::getExtensionSignature($extensionIdentity);
163165
$typoScriptViewConfiguration = GeneralUtility::removeDotsFromTS(
164166
$typoScript->getSetupArray()['plugin.']['tx_' . $extensionSignature . '.']['view.'] ?? []

phpstan.neon

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ parameters:
3131
- "#(invalid (return )?type|unknown class) TYPO3\\\\CMS\\\\Core\\\\Core\\\\Event\\\\BootCompletedEvent#"
3232
- "#(invalid (return )?type|unknown class) TYPO3\\\\CMS\\\\Core\\\\Http\\\\JsonResponse#"
3333
- "#(invalid (return )?type|unknown class) TYPO3\\\\CMS\\\\Core\\\\TypoScript\\\\TemplateService#"
34+
- "#(invalid (return )?type|unknown class) TYPO3\\\\CMS\\\\Core\\\\TypoScript\\\\FrontendTyposcript#"
3435
- "#(invalid (return )?type|unknown class) TYPO3\\\\CMS\\\\Extbase\\\\Mvc\\\\Controller\\\\ControllerContext#"
3536
- "#(invalid (return )?type|unknown class) TYPO3\\\\CMS\\\\Extbase\\\\Mvc\\\\View\\\\ViewInterface#"
3637
- "#(invalid (return )?type|unknown class) TYPO3\\\\CMS\\\\Extbase\\\\Mvc\\\\Response#"

0 commit comments

Comments
 (0)