Skip to content

Commit e94db56

Browse files
committed
fix: merge DC property
I used dc property as basic property. It was unhealthy.
1 parent 5ebfc43 commit e94db56

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

lib/domain/rss1_item.dart

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,13 @@ class Rss1Item {
88
final String title;
99
final String description;
1010
final String link;
11-
final List<String> subjects;
12-
final String creator;
13-
final DateTime date;
1411
final DublinCore dc;
1512
final RssContent content;
1613

1714
Rss1Item({
1815
this.title,
1916
this.description,
2017
this.link,
21-
this.subjects,
22-
this.creator,
23-
this.date,
2418
this.dc,
2519
this.content,
2620
});
@@ -37,12 +31,6 @@ class Rss1Item {
3731
title: findElementOrNull(element, "title")?.text,
3832
description: findElementOrNull(element, "description")?.text,
3933
link: findElementOrNull(element, "link")?.text,
40-
subjects: element
41-
.findAllElements('dc:subject')
42-
.map((subject) => subject.text)
43-
.toList(),
44-
creator: findElementOrNull(element, 'dc:creator')?.text,
45-
date: _dateTimeBuilder(findElementOrNull(element, 'dc:date')?.text),
4634
dc: DublinCore.parse(element),
4735
content: RssContent.parse(findElementOrNull(element, "content:encoded")),
4836
);

test/rss1_test.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,7 @@ void main() {
108108
expect(firstItem.description, '');
109109
expect(firstItem.title, 'はてなスタッフのブックマーク拝見! - 営業マン編「仕事の様々なシーンでフル活用」');
110110
expect(firstItem.link, 'http://b.hatena.ne.jp/guide/staff_bookmark_03');
111-
expect(firstItem.creator, 'sample');
112-
expect(firstItem.date, DateTime.parse('2009-04-10T09:44:20Z'));
113-
expect(firstItem.subjects[0], 'はてな');
114-
expect(firstItem.subjects[1], 'インタビュー');
115-
expect(firstItem.subjects[2], 'はてなブックマーク');
111+
expect(firstItem.dc.creator, 'sample');
116112
expect(firstItem.dc.date, '2009-04-10T09:44:20Z');
117113
});
118114
}

0 commit comments

Comments
 (0)