Fixed all analysis errors

Author: matthew-carroll

doc/marketing_goldens/flutter_test_config.dart

@@ -11,6 +11,7 @@ Future<void> testExecutable(FutureOr<void> Function() testMain) async {
   ));
 
   // Disable animations in Super Editor.
+  // ignore: invalid_use_of_visible_for_testing_member
   BlinkController.indeterminateAnimationsEnabled = false;
 
   return testMain();

doc/marketing_goldens/gallery/gallery_test.dart

@@ -98,7 +98,7 @@ void main() {
               ]),
               shadows: [
                 BoxShadow(
-                  color: Colors.blue.withOpacity(.4),
+                  color: Colors.blue.withValues(alpha: .4),
                   spreadRadius: 4,
                   blurRadius: 10,
                   offset: const Offset(0, 2),

doc/marketing_goldens/platform_adaptive_gallery/platform_adaptive_gallery_test.dart

@@ -1,8 +1,6 @@
 import 'dart:io';
 
-import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
-import 'package:flutter/widgets.dart';
 import 'package:flutter_svg/flutter_svg.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:flutter_test_goldens/flutter_test_goldens.dart';
@@ -110,6 +108,7 @@ Widget _itemDecorator(
           children: [
             SvgPicture.file(
               _getIconFileForPlatform(metadata.simulatedPlatform),
+              // ignore: deprecated_member_use
               color: Colors.black,
               width: 24,
               height: 24,

doc/marketing_goldens/single_shot/single_shot_test.dart

@@ -1,6 +1,3 @@
-import 'dart:io';
-import 'dart:math';
-
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:flutter_test_goldens/flutter_test_goldens.dart';

lib/src/flutter/flutter_camera.dart

@@ -1,5 +1,4 @@
 import 'dart:async';
-import 'dart:typed_data';
 import 'dart:ui';
 
 import 'package:flutter/foundation.dart';
@@ -24,13 +23,11 @@ class FlutterCamera {
   /// that the photo captures widgets that sit in the app overlay, such as the mobile drag
   /// handles, magnifier, or popover toolbar for a text field.
   Future<void> takePhoto(String id, [Finder? finder]) async {
-    print("takePhoto() - id: $id, finder: $finder");
     final fullscreenRenderObject = find
         .byElementPredicate((element) => element.renderObject is RenderRepaintBoundary)
         .evaluate()
         .first
         .findRenderObject() as RenderRepaintBoundary?;
-    print("fullscreenRenderObject: $fullscreenRenderObject");
     if (fullscreenRenderObject == null) {
       throw Exception(
         "Tried to take a photo of a Flutter UI but the widget tree doesn't have any repaint boundaries. Can't take any screenshots.",
@@ -40,36 +37,29 @@ class FlutterCamera {
     final pictureRecorder = PictureRecorder();
     final canvas = Canvas(pictureRecorder);
     final screenSize = fullscreenRenderObject.size;
-    print("screenSize: $screenSize");
 
     final paintingContext = TestRecordingPaintingContext(canvas);
     fullscreenRenderObject.paint(paintingContext, Offset.zero);
 
-    print("Finishing picture recording...");
     final fullscreenPhoto = await pictureRecorder.endRecording().toImage(
           screenSize.width.round(),
           screenSize.height.round(),
         );
-    print("Picture is finished");
 
     final contentFinder = finder ?? find.byType(GoldenImageBounds);
     expect(finder, findsOne);
-    print("Found the content");
     final contentRenderObject = contentFinder.evaluate().first.findRenderObject();
-    print("Content render object: $contentRenderObject");
     if (contentRenderObject is! RenderBox) {
       throw Exception(
         "Tried to take screenshot of $contentFinder but its render object is not a RenderBox. Can't take screenshot.",
       );
     }
-    print(
-        "Cropping content out of fullscreen image - offset: ${contentRenderObject.localToGlobal(Offset.zero)}, size: ${contentRenderObject.size}");
+
     final contentPhoto = await _cropImage(
       fullscreenPhoto,
       contentRenderObject.localToGlobal(Offset.zero),
       contentRenderObject.size,
     );
-    print("Done cropping image");
 
     _photos.add(
       FlutterScreenshot(id, contentPhoto, defaultTargetPlatform),

lib/src/goldens/golden_collections.dart

@@ -1,5 +1,4 @@
 import 'dart:typed_data';
-import 'dart:ui';
 
 import 'package:flutter/widgets.dart';
 import 'package:image/image.dart' as img;

lib/src/goldens/golden_scenes.dart

@@ -53,7 +53,6 @@ ${const JsonEncoder.withIndent("  ").convert(sceneJson)}'''), stackTrace);
   }
 
   // Extract the golden images from the scene image.
-  print("Extracting goldens from file...");
   return _extractCollectionFromSceneBitmap(sceneMetadata, sceneImage);
 }
 
@@ -97,13 +96,11 @@ Future<ScreenshotCollection> extractGoldenCollectionFromSceneWidgetTree(
   final treeImage = decodePng(treeRawImageData)!;
 
   // Extract the golden images from the scene image.
-  print("Extracting candidates from widget tree...");
   return _extractCollectionFromSceneBitmap(sceneMetadata, treeImage);
 }
 
 ScreenshotCollection _extractCollectionFromSceneBitmap(GoldenSceneMetadata sceneMetadata, Image sceneImage) {
   // Cut each golden image out of the scene.
-  print("Extracting screenshots from a scene (maybe goldens, maybe candidates):");
   final goldenImages = <String, GoldenSceneScreenshot>{};
   for (final golden in sceneMetadata.images) {
     final image = copyCrop(
@@ -113,8 +110,6 @@ ScreenshotCollection _extractCollectionFromSceneBitmap(GoldenSceneMetadata scene
       width: golden.size.width.round(),
       height: golden.size.height.round(),
     );
-    print(
-        " - ${golden.id} - offset: ${golden.topLeft}, size: ${golden.size}, extracted image size: Size(${image.width}, ${image.height})");
 
     goldenImages[golden.id] = GoldenSceneScreenshot(
       golden.id,
@@ -123,7 +118,6 @@ ScreenshotCollection _extractCollectionFromSceneBitmap(GoldenSceneMetadata scene
       image.getBytes(),
     );
   }
-  print("----");
 
   return ScreenshotCollection(goldenImages);
 }

lib/src/scenes/gallery.dart

@@ -315,7 +315,6 @@ class Gallery {
   /// For each scene screenshot request, pumps its widget tree, and then screenshots it with
   /// the given [camera].
   Future<void> _takeNewScreenshots(WidgetTester tester, FlutterCamera camera) async {
-    print("Taking screenshots:");
     for (final item in _requests.values) {
       FtgLog.pipeline.info("Building gallery item: ${item.description}");
       final itemScaffold = item.scaffold ?? _itemScaffold ?? GoldenSceneTheme.current.itemScaffold;
@@ -354,8 +353,6 @@ class Gallery {
       // Take a screenshot.
       expect(item.boundsFinder, findsOne);
       final renderObject = item.boundsFinder.evaluate().first.findRenderObject();
-      print(
-          " - Taking screenshot. Bounds: ${item.boundsFinder}, Render object size: ${(renderObject as RenderBox?)?.size}");
       expect(
         renderObject,
         isNotNull,
@@ -365,7 +362,6 @@ class Gallery {
       await tester.runAsync(() async {
         await camera.takePhoto(item.id, item.boundsFinder);
       });
-      print(" - Done taking photo - ${camera.photos.last.id} - size: ${camera.photos.last.size}");
 
       // Revert the simulated platform to whatever it was before this item.
       debugDefaultTargetPlatformOverride = previousPlatform;
@@ -374,7 +370,6 @@ class Gallery {
 
   Widget _buildItem(
       WidgetTester tester, GoldenSceneItemScaffold itemScaffold, BoxConstraints? constraints, Widget content) {
-    print("Building with item constraints: $constraints");
     return itemScaffold(
       tester,
       ConstrainedBox(
@@ -388,7 +383,6 @@ class Gallery {
     WidgetTester tester,
     List<FlutterScreenshot> flutterScreenshots,
   ) async {
-    print("Converting Flutter screenshots to golden candidates:");
     final candidateScreenshots = <String, GoldenSceneScreenshot>{};
     await tester.runAsync(() async {
       for (final flutterScreenshot in flutterScreenshots) {
@@ -407,8 +401,6 @@ class Gallery {
         );
 
         candidateScreenshots[flutterScreenshot.id] = candidate;
-        print(
-            " - ${candidate.id} - size: ${candidate.size}, inner PNG size: ${candidate.image.width}, ${candidate.image.height}");
       }
     });
 
@@ -423,12 +415,6 @@ class Gallery {
     // Layout candidate screenshots in the gallery so we can lookup their final offsets and sizes.
     var sceneMetadata = await _layoutGalleryWithNewGoldens(tester, _layout, newGoldens);
 
-    print("Saving new scene metadata. Here are the golden bounds:");
-    for (final golden in sceneMetadata.images) {
-      print(" - ${golden.id} - at: ${golden.topLeft}, size: ${golden.size}");
-    }
-    print("---");
-
     FtgLog.pipeline.finer("Running momentary delay for render flakiness");
     await tester.runAsync(() async {
       // Without this delay, the screenshot loading is spotty. However, with
@@ -481,7 +467,6 @@ Image.memory(
     SceneLayout layout,
     Map<String, GoldenSceneScreenshot> goldenScreenshots,
   ) async {
-    print("_layoutGalleryWithNewGoldens()");
     final goldensAndGlobalKeys = Map<GoldenSceneScreenshot, GlobalKey>.fromEntries(
       goldenScreenshots.entries.map((entry) => MapEntry(entry.value, GlobalKey())),
     );
@@ -525,7 +510,6 @@ Image.memory(
   }
 
   Widget _buildGalleryLayout(WidgetTester tester, Map<GoldenSceneScreenshot, GlobalKey> candidatesAndGlobalKeys) {
-    print("Building Gallery scene layout");
     return Builder(builder: (context) {
       return _layout.build(tester, context, candidatesAndGlobalKeys);
     });

lib/src/scenes/layouts/animation_timeline_layout.dart

@@ -1,5 +1,4 @@
 import 'package:flutter/material.dart';
-import 'package:flutter/widgets.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:flutter_test_goldens/src/fonts/fonts.dart';
 import 'package:flutter_test_goldens/src/goldens/golden_collections.dart';

lib/src/scenes/layouts/row_and_column_layout.dart

@@ -1,7 +1,5 @@
-import 'package:flutter/material.dart' show Colors;
 import 'package:flutter/widgets.dart';
 import 'package:flutter_test/flutter_test.dart';
-import 'package:flutter_test_goldens/src/fonts/fonts.dart';
 import 'package:flutter_test_goldens/src/goldens/golden_collections.dart';
 import 'package:flutter_test_goldens/src/goldens/golden_rendering.dart';
 import 'package:flutter_test_goldens/src/scenes/golden_scene.dart';
@@ -98,7 +96,6 @@ class FlexGoldenScene extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    print("Building FlexGoldenScene");
     return DefaultTextStyle(
       style: GoldenSceneTheme.current.defaultTextStyle,
       child: GoldenSceneBounds(
@@ -149,8 +146,6 @@ class FlexGoldenScene extends StatelessWidget {
   }
 
   Widget _decorator(BuildContext context, GoldenScreenshotMetadata metadata, Widget child) {
-    print(
-        "Building _decorator() - itemDecorator: ${this.itemDecorator}, theme item decorator: ${GoldenSceneTheme.current.itemDecorator}");
     final itemDecorator = this.itemDecorator ?? GoldenSceneTheme.current.itemDecorator;
     return itemDecorator(context, metadata, child);
   }